Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-14 Thread Dirk Pranke
On Wed, Feb 13, 2013 at 11:33 PM, Benjamin Poulain benja...@webkit.org wrote: On Wed, Feb 13, 2013 at 11:16 PM, Dirk Pranke dpra...@chromium.org wrote: Those changes are not harmless. There are people monitoring tests results full time in order to keep WebKit in good shape. No other part

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-14 Thread Dongsung Huang
I'm curious, what would you imagine the ref test contains? If I am not mistaken, the composition operations are parallel with the ones of SVG and Canvas (aren't they?). I would have attempted comparing the 3 implementations as it seems to me the pixels values should be the same. That

Re: [webkit-dev] sln files with wrong line endings

2013-02-14 Thread Rafael Brandao
This also happened to me, quite annoying. :-( I've followed the thread https://groups.google.com/a/chromium.org/forum/?fromgroups=#!topic/chromium-dev/YpKL4xiJHPQ and did the following: editing .gitattributes to disable the eol=crlf flag for .sln files, then doing a reset/checkout, then un-editing

Re: [webkit-dev] sln files with wrong line endings

2013-02-14 Thread Darin Adler
Typically in Subversion the fix for a problem like this is to set the eol-style explicitly; presumably to CRLF for Windows project and solution files and to LF or native for plain old source files. Once that property is set, people changing file later on can’t cause problems with inconsistent

Re: [webkit-dev] sln files with wrong line endings

2013-02-14 Thread Adam Roben
I'm pretty sure r142864 fixed this (perhaps unintentionally) by changing all line endings in DumpRenderTree.sln from CRLF to LF. On Thu, Feb 14, 2013 at 11:11 AM, Darin Adler da...@apple.com wrote: Typically in Subversion the fix for a problem like this is to set the eol-style explicitly;

Re: [webkit-dev] sln files with wrong line endings

2013-02-14 Thread Osztrogonác Csaba
Hi All, Here is an old bug report about it: Files with CRLF lineendigs without svn:eol-style=native kills git svn repositories https://bugs.webkit.org/show_bug.cgi?id=96934 The general fix would be to force all Windows project file have svn:eol-style=native svn property. git-svn users who

[webkit-dev] Enable CANVAS_PATH by default

2013-02-14 Thread Dirk Schulze
Hi WebKit folks, I worked on the Path interface defined by the Canvas spec of W3C and WHATWG [1][2] for the last couple of weeks. Summary: Canvas supports a new DOM interface called Path. The Path interface takes a series of very well known path methods like moveTo, lineTo, cubicCurveTo, rect

[webkit-dev] Ports: Converting media controls to -webkit-flex

2013-02-14 Thread Christian Biesinger
Hi, currently, media controls all use the deprecated flex box (-webkit-box). In https://bugs.webkit.org/show_bug.cgi?id=109775, I am converting them to use the new flex box (-webkit-flex). I have verified that the result looks correct on the Chromium and Mac ports, but I am unable to build/test

Re: [webkit-dev] Enable CANVAS_PATH by default

2013-02-14 Thread James Robinson
On Thu, Feb 14, 2013 at 9:55 AM, Dirk Schulze dschu...@adobe.com wrote: Hi WebKit folks, I worked on the Path interface defined by the Canvas spec of W3C and WHATWG [1][2] for the last couple of weeks. Summary: Canvas supports a new DOM interface called Path. The Path interface takes a