Re: [webkit-dev] Unmaintained feature list

2013-04-08 Thread Julien Chaffraix
Sounds like a great idea: http://trac.webkit.org/wiki/UnmaintainedFeatureList Thanks for starting this. Added CSS Grid Layout to the list as I don't think I would be able to do merges back. I would be more than happy to remove the code if people feel the need. If anyone wants to take over, I

[webkit-dev] [Coding Style] Clarification about multiple assignments on one line

2013-02-22 Thread Julien Chaffraix
Hi WebKit folks, over several reviews, I have been saying that the following line is a coding style violation: firstVariable = secondVariable = 0; For a concrete example, the computePreferredLogicalWidths uses the following pattern: minWidth = maxWidth = maxint(minWidth,

Re: [webkit-dev] Exposing Mouse Simulation event API from webkit

2013-02-13 Thread Julien Chaffraix
webkit-dev is reserved for discussion about WebKit development. Your question seems to be about some changes you want to do locally so it belongs to webkit-help (https://lists.webkit.org/mailman/listinfo/webkit-help). I have done changes to expose the mouse simulation API from webkit.

Re: [webkit-dev] Need information regarding CSS3 extension

2013-01-20 Thread Julien Chaffraix
I want to write CSS3 extension, I don’t have any idea about it. I saw the code related to css in webkit but I am getting difficulties to map it. I. want to develop own tag like webkit-animation. Please let me know if anyone having any idea about CSS extension. This question is not for

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Julien Chaffraix
On Mon, Dec 3, 2012 at 12:59 PM, Dirk Schulze dschu...@adobe.com wrote: Depends on the future. But for such a small patch, a new flag seems to be overdone. I looked into the patch, and adding the flag caused more code, then the actual feature (even if the computed style is missing). I

Re: [webkit-dev] r- your own patches [was: Re: RenderArena: Teaching an old dog new tricks]

2012-11-16 Thread Julien Chaffraix
Seconded. I also think only the one who submitted the patch can clear the r? flag. Others should NOT do that, please, even you are a reviewer. You can r- the patch if you believe it is bad. I disagree with that. You seem to think that patches falls into either good or bad. However the reality

Re: [webkit-dev] New runtime setting: css3TextDecoration

2012-08-14 Thread Julien Chaffraix
I don't think it's appropriate to add settings for CSS features that are under development, for a number of reasons: * If we did this for every feature, we'd end up with hundreds of Settings. * Traditionally, Settings don't tend to get removed, resulting in an ever-accumulating number of

Re: [webkit-dev] New runtime setting: css3TextDecoration

2012-08-14 Thread Julien Chaffraix
On Tue, Aug 14, 2012 at 12:06 PM, Ryosuke Niwa rn...@webkit.org wrote: On Tue, Aug 14, 2012 at 11:56 AM, Julien Chaffraix julien.chaffr...@gmail.com wrote: I don't think it's appropriate to add settings for CSS features that are under development, for a number of reasons: * If we did

Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-25 Thread Julien Chaffraix
I think this will be too fragile. It relies on the fact that a subsequent paint won't obscure the repaint bug that you're trying to detect. I'm much rather we work towards detecting repaint bugs via dumping the list of repaint rectangles. I don't think every test has to be a ref test.

Re: [webkit-dev] Deprecating features guideline wiki

2012-04-30 Thread Julien Chaffraix
BTW, the page at https://trac.webkit.org/wiki/DeprecatingFeatures seems to be using deprecate in the sense of remove entirely. Is that what is meant? If so, I think it would be helpful to change the wording to removing features. In non-Web contexts, deprecate often means a step short of

[webkit-dev] Deprecating features guideline wiki

2012-04-25 Thread Julien Chaffraix
Hi WebKittens, following the talk about Deprecating (web-facing) features and vendor prefixing [1], we decided to create a guideline covering new deprecations or un-prefixing [2]. The rationale is that this will avoid a lot of the mistakes that we have made in the previous deprecations and that

Re: [webkit-dev] handling failing tests (test_expectations, Skipped files, etc.)

2012-04-09 Thread Julien Chaffraix
In my ideal world, you would be able to get updated baselines *prior* to trying to land a patch. This is of course not really possible today for any test that fails on multiple ports with different results, as it's practically impossible to run more than a couple of ports by hand, and we

Re: [webkit-dev] handling failing tests (test_expectations, Skipped files, etc.)

2012-04-09 Thread Julien Chaffraix
If there's consensus in the mean time that it is better on balance to check in suppressions, perhaps we can figure out a better way to do that. Maybe (shudder) a second test_expectations file? Or maybe it would be better to actually check in suppressions marked as REBASELINE (or something

Re: [webkit-dev] Head-ups: massive TEXT rebaselining

2012-03-02 Thread Julien Chaffraix
Hi everyone, I will land https://bugs.webkit.org/show_bug.cgi?id=75568 tomorrow to give enough time for people to react. This makes us lazily allocate layers when we get layout overflow. The upside is a good speed-up in painting / hit-testing and (likely) some memory improvement but it also

[webkit-dev] Head-ups: massive TEXT rebaselining

2012-02-29 Thread Julien Chaffraix
Hi everyone, TL;DR: If you don't maintain a bot or look at render tree dumps, I guess this is not interesting to you. I will land https://bugs.webkit.org/show_bug.cgi?id=75568 tomorrow to give enough time for people to react. This makes us lazily allocate layers when we get layout overflow. The

Re: [webkit-dev] Making overflow clipping cheaper

2012-01-04 Thread Julien Chaffraix
I'd be careful in how I approach this. Some platforms are going to want compositing of overflow sections eventually for fast scrolling of those sections. RenderLayer has become the natural tie-in point for GraphicsLayer connections. This is something I don't want to prevent. That said it

Re: [webkit-dev] Making overflow clipping cheaper

2011-12-29 Thread Julien Chaffraix
Wouldn't it be better to implement better searching and paint-segmentation in RenderLayers then? It could also provide the same speed up for many other big cases. That would be worth investigating more for sure (do you mind filing a bug about it?). The paint search and segmentation algorithm

[webkit-dev] Making overflow clipping cheaper

2011-12-27 Thread Julien Chaffraix
Hi fellow hackers, while investigating some slowness related to painting big HTML tables [1], RenderLayer's painting code path was pointed out as the source of slowness. The problem stems from RenderLayer not being aware of the peculiarities of the underlying RenderObject (RenderTableSection

[webkit-dev] [New feature] CSS Grid Layout

2011-11-12 Thread Julien Chaffraix
Hello WebKittens, just a heads-up to say that Ojan, Tony and myself will start implementing CSS Grid Layout [1] starting next week. Don't expect too many updates at the beginning as we migrate from our current tasks to this new feature. CSS Grid Layout is a fairly new standard already

Re: [webkit-dev] Is JSRetainPtr part of public WebKit API on some platforms?

2011-11-10 Thread Julien Chaffraix
Julien Chaffraix asked me about API breakage in https://bugs.webkit.org/show_bug.cgi?id=71423 Remove all releaseRef implementations except for RetainPtr. I realize now that JSRetainPtr.h is in the API directory. Is it part of the public API on some platforms? I know it’s not on Mac

Re: [webkit-dev] Regarding OPENVG for GTK Build....

2011-10-18 Thread Julien Chaffraix
I am trying to build OPENVG for GTK port. Can anyone provide me the details  for building OPENVG(which flag to enable etc) Please direct your questions to webkit-help (or webkit-gtk in this case) as webkit-dev is related to the development of WebKit itself. You should know that the OpenVG

Re: [webkit-dev] JavaScriptCore on Android

2011-07-07 Thread Julien Chaffraix
Hi, This mailing list is for WebKit development not WebKit general questions, use webkit-help for your next enquiries. I am trying to use JavaScriptCore in my Android application. First, understand that the Android bindings in WebKit have been removed (that includes JSC), thus I would advise

Re: [webkit-dev] Proposal: Commit messages should start with a one-line summary of the change

2011-07-01 Thread Julien Chaffraix
I don’t think it’s a good idea to add yet another thing to every change log entry. I wouldn't consider this something being added. Most ChangeLog entries (the good ones, anyway) already contain a description of the fix in addition to the bug title, URL and reviewer. While I sympathize

Re: [webkit-dev] Proposal: Commit messages should start with a one-line summary of the change

2011-07-01 Thread Julien Chaffraix
I wasn't trying to add any complexity. My hope is that people are already adding descriptions of their changes to their ChangeLog entries, like you do. I was just trying to suggest a better way to organize that description. In my original email I noted two benefits of making this change:

Re: [webkit-dev] CSS optional property names

2011-06-07 Thread Julien Chaffraix
It looks like only the .idl files get pre-processed. The .in files have comments that start with #, meaning that they cannot be pre-processed by a C++ preprocessor. We need to change the comment styles for .in files to //. That's partly right. Some .in files are preprocessed (tag and

Re: [webkit-dev] Tiger

2011-05-03 Thread Julien Chaffraix
I was referring mostly to build-webkit ifs, assuming that the #ifdefs in the cpp code were still around as well.  But it's possible those already got removed. :) I think Eric's question is broader than just #ifdefs. Bugzilla has some Tiger bugs that we should close if we consider Tiger's

Re: [webkit-dev] Contributors meeting notes

2011-04-27 Thread Julien Chaffraix
On Wed, Apr 27, 2011 at 1:12 PM, Eric Seidel e...@webkit.org wrote: There are some on the webkit-meeting list.  We need to make a more concerted effort to move them to the wiki and link from the meeting page though. I will make an effort to track down notes from my talk and add them to the

Re: [webkit-dev] What is XBL?

2010-08-25 Thread Julien Chaffraix
http://en.wikipedia.org/wiki/XBL , I guess? FYI XBL has been superseded by XBL 2.0 that is not backward compatible with the first version [1]. Thus our code is just obsolete. Regards, Julien [1] http://www.w3.org/TR/xbl/#relationship ___ webkit-dev

Re: [webkit-dev] help with webkit installation for kde-4.4.2 (amd64 linux)

2010-04-13 Thread Julien Chaffraix
Hi, I am having a go at compiling kde4.4.2.  I am now  trying to build webkit for KDE4.4.2 (pure-64bit -non-multilib -amd64 linux  setup).  (it is needed by google-gadgets)  I downloaded qtwebkit from http://gitorious.org/+qtwebkit-developers/webkit/qtwebkit and it compiles OK with the

[webkit-dev] [Seeking comments] WebKit site modification

2010-03-11 Thread Julien Chaffraix
Hi everyone, Following the huge number of people posting on webkit-dev instead of more appropriate mailing lists - even though we made the switch several months ago - or asking incomplete questions, I have undergo a change to the website to prevent that [1]. Considering that it has scared

Re: [webkit-dev] how to debug webcore, or disable some webcore loader?

2010-02-23 Thread Julien Chaffraix
Hi, On Tue, Feb 23, 2010 at 5:26 PM, RyanYee/叶晔 god...@gmail.com wrote: we worked on webcore application base on embbed system(mips), used qt-webkit package (qt-embedded-linux-opensource-src-4.5.1). sometime our browser will crash when access few website. 1.is there any tools can

Re: [webkit-dev] eventlistener

2010-02-03 Thread Julien Chaffraix
Hi, I have implemented my own eventlistener . but the event listener is being deleted . can anyone help me out pls This mailing list is used for Webkit development discussions only. Your question should be addressed to http://lists.webkit.org/mailman/listinfo/webkit-help. Also make sure you

Re: [webkit-dev] Data transfer from the network backend

2009-03-12 Thread Julien Chaffraix
Hi, [resend - forgot to CC the list] Where is the data fetched by the network backend being used to first instantiate the data structures that are need for rendering? Can you tell me with respect to Qt or GTK+curl? There is quite a long way from the network backend to the rendering. The

Re: [webkit-dev] how to implement the flash block for webkit on linux?

2009-03-09 Thread Julien Chaffraix
Hi,   At present, we want to implement the flash block for webkit on linux like flash block extension for firefox.   We find the implemention of firefox, it's based on xbl, it's very easy to understand.Through checking after sometime we find the branches/xbl2  of webkit svn includes

Re: [webkit-dev] How to handle error response on the browser when the HTTP request fails

2009-02-12 Thread Julien Chaffraix
Hi, Thanks for your suggestion. I added delegate method in FrameloaderClient::dispatchDidFailLoading for GTK, however, noticed that the control flow never reached there - either in case of successful response or for http error like server not found etc. Then I added some debug code in

Re: [webkit-dev] Curl Cookie Handling

2009-02-10 Thread Julien Chaffraix
Hi Kevin, Is this patch still valid, i.e. not made obsolete by another approach? As far as I know, there is no work towards storing the cookies inside the database as it is done in Firefox. Furthermore I know no work in cURL toward exposing the cookies so that we could add / remove / update

Re: [webkit-dev] Curl Cookie Handling

2009-02-09 Thread Julien Chaffraix
Hi, I have Integrated the patch given in https://bugs.webkit.org/show_bug.cgi?id=14730 on webkit r36766 with additions on SQLITE db calls As you have seen this patch is not integrated and is a year old. As a result, it may have rotten (the code has changed and some assertions I made are not

Re: [webkit-dev] write function in FrameLoaderClient.cpp

2009-02-03 Thread Julien Chaffraix
Hi, Can I implement the function: bool WebFrameLoaderClient::hasWebView() const { return [m_webFrame.get() webView] != nil; } written in WebKit/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm and write it in WebKit / WebCore / loader / FrameLoaderClient.cpp? This method lies in

Re: [webkit-dev] about the Dashed border

2009-01-14 Thread Julien Chaffraix
Hi, I open a webpage with webkit (e.g. www.google.com), and the text box obtains the focus, if I press the Tab key, and the button obtains the focus, and there is a Dashed border The dashed border is called a focus ring. Now I want to have a Actual wireframe,I want to change the Dashed

[webkit-dev] FontCache refactoring proposal

2008-12-11 Thread Julien Chaffraix
Hi everyone, while working on memory leaks inside WebCore, the Pleyo team has found that the FontCache was responsible for a few of them. In order to solve those leaks and prevent future ones, we have done a refactoring of the FontCache and its internal working (mainly making the SimpleFontData

Re: [webkit-dev] FontCache refactoring proposal

2008-12-11 Thread Julien Chaffraix
Hi Dan, On Thu, Dec 11, 2008 at 6:40 PM, Dan Bernstein m...@apple.com wrote: Hi Julien, On Dec 11, 2008, at 2:14 AM, Julien Chaffraix wrote: Hi everyone, while working on memory leaks inside WebCore, the Pleyo team has found that the FontCache was responsible for a few of them. It would

Re: [webkit-dev] Build errors

2008-11-15 Thread Julien Chaffraix
Hi, On Fri, Nov 14, 2008 at 6:19 PM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: I'm trying to successfully build WebKit using Visual Studio 2005 but I keep getting compile errors. SVGElement.h includes SVGNames.h but I don't see SVGNames.h in any directory. No such file for HTMLNames.cpp

Re: [webkit-dev] Identifying a div element

2008-10-21 Thread Julien Chaffraix
Hi, How can I check if a Node is a HTMLDivElement. I want to traverse from a child node upto the parent node, until I reach a div node. You need first to check that it is an Element with the method isElement(), then cast it as an Element and check its tag name with Element::hasTagName() (in

Re: [webkit-dev] Unable to compile the webkit on the Redhat enterprise linux 9

2008-10-15 Thread Julien Chaffraix
Hi, On Tue, Oct 14, 2008 at 8:02 PM, Gustavo Noronha Silva [EMAIL PROTECTED] wrote: Hello, Disclaimer: I'm more of a GTK+/Debian guy =). On Tue, 2008-10-14 at 10:31 -0400, Ramesh Satyavaram wrote: I am new to webkit. Yester day I downloaded the sources on to my Red hat enterprise linux

Re: [webkit-dev] adjust timeout for non-responsive url's

2008-10-10 Thread Julien Chaffraix
On Wed, Oct 8, 2008 at 6:23 PM, Pitaga [EMAIL PROTECTED] wrote: I'd appreciate a pointer to the code that determines the wait time when attempting to load a page from a non-responsive server. The ResourceRequest class (WebCore/platform/network/ResourceRequestBase.h) has a timeout value that

Re: [webkit-dev] File upload feature

2008-10-07 Thread Julien Chaffraix
Hi, On Mon, Oct 6, 2008 at 3:44 PM, Amit Nargund [EMAIL PROTECTED] wrote: Hi, No it does not crash. If I open rapidshare.com, and then select a file and click on upload... nothing happens! I observed the http traffic through wireshark, and I could not see any POST packet in it. That means

Re: [webkit-dev] Proposal and ideas for a new .in format

2008-06-19 Thread Julien Chaffraix
[Forgot to CC the list] On Thu, Jun 19, 2008 at 4:30 PM, Julien Chaffraix [EMAIL PROTECTED] wrote: On Thu, Jun 19, 2008 at 9:32 AM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Jun 19, 2008, at 12:56 AM, Eric Seidel wrote: Not a big fan of using the negative: noWrapperFactory=1 Should

[webkit-dev] Proposal and ideas for a new .in format

2008-06-18 Thread Julien Chaffraix
Hi all, following several issues raised about the XML format, I have tried a variation of the format Maciej proposed. Here is an exemple: # the first part contains the common parameters (may be empty) namespace=html cppNamespace=WebCore namespaceURI=http://www.w3.org/1999/xhtml # an empty line

Re: [webkit-dev] Qt DOM tree

2008-06-06 Thread Julien Chaffraix
Hi Habiba, I posted in this mailling list because it seemed to me necessary seen that I work with WebKit, because the important for me it is to have ideas of the others. Just to clear that a bit as it can be quite confusing. What you are really using is WebKit embedded in the Qt framework

Re: [webkit-dev] dom, Qt and Qwebkit

2008-05-14 Thread Julien Chaffraix
Hi, I have developed an application that extract links from a javascript file with the manipulation of the dom tree, QDocument and Qwebkit . There is a portion of my code where i have the falawing error: QDomNode n = docElem.firstChild(); while(!n.isNull()) {

Re: [webkit-dev] Fwd: help

2008-05-08 Thread Julien Chaffraix
Hi, [I have assumed you are using the Qt code as your previous post was about Qt] I want to develop an application using webkit, my application in the fact consists to extract the links from a html page. It is not currently possible as WebKit DOM bits are not exported in Qt but it is

Re: [webkit-dev] Building the Qt version on Linux

2008-04-13 Thread Julien Chaffraix
). FYI, when you enter a URL that is rejected, it falls back to the previous page so it seems to do nothing. Julien --sea On Sat, Apr 12, 2008 at 5:13 PM, Julien Chaffraix [EMAIL PROTECTED] wrote: Hi, I got this building error of libQtWebKit shared library. tmp/chartables.o

Re: [webkit-dev] Building the Qt version on Linux

2008-04-12 Thread Julien Chaffraix
Hi, I got this building error of libQtWebKit shared library. tmp/chartables.o:(.rodata+0x0): multiple definition of `kjs_pcre_default_tables' tmp/pcre_tables.o:(.rodata+0xa0): first defined here The error is obvious because JavaScriptCore/pcre/pcre_tables.cpp has included the generated C

Re: [webkit-dev] Problem building/running Webkit with QT4 on Ubuntu

2007-10-13 Thread Julien Chaffraix
Hi, 1. i fetched webkit from here http://svn.webkit.org/repository/webkit/trunkhttp://www.qtforum.org/redir.php?url=http%3A%2F%2Fsvn.webkit.org%2Frepository%2Fwebkit%2Ftrunk 2. i installed libqt4-dev-kdecopy with: apt-get install libqt4-dev-kdecopy, as qt4.3 was needed (libqt4-dev is qt4.2.3)

Re: [webkit-dev] Issue with calling javascript function from a external thread

2007-08-13 Thread Julien Chaffraix
. If you want to perform external processing on a secondary thread, that's OK, but any calls into the DOM will have to happen on the main thread. Geoff On Aug 10, 2007, at 3:00 AM, Julien Chaffraix wrote: Hi all, I am trying to make a wrapper in C++ for the Ivy protocol for OWB (I

[webkit-dev] Issue with calling javascript function from a external thread

2007-08-10 Thread Julien Chaffraix
Hi all, I am trying to make a wrapper in C++ for the Ivy protocol for OWB (I think it could work on Webkit even though I have not tested) that could world entirely in javascript. Ivy is a light-weigh publish/subscribe protocol. It is based on callback functions that you call when a regExp is