Re: [webkit-dev] Can Qt use some of the common DRT code?

2013-02-11 Thread Allan Sandfeld Jensen
On Monday 11 February 2013, Benjamin Poulain wrote: One of the differences is the way the Qt port works. Instead of using the JSC binding APIs, it uses its own JS Qt bindings. Would it be possible for Qt to move to the common code? It would make future refactoring easier as there would be one

[webkit-dev] Can Qt use some of the common DRT code?

2013-02-10 Thread Benjamin Poulain
Hi, Today, adding a support for a new function in TestRunner requires (painfully) changing: -WebKitTestRunner. -Common DRT + 6 implementations (Mac, Win, GTK, EFL, WX, Blackberry). -Chromium DRT. -Qt DRT. I think we can do much better. A first step is to have more common code in DRT. One of the

Re: [webkit-dev] Can Qt use some of the common DRT code?

2013-02-10 Thread Jochen Eisinger
On Mon, Feb 11, 2013 at 3:37 AM, Benjamin Poulain benja...@webkit.orgwrote: Hi, Today, adding a support for a new function in TestRunner requires (painfully) changing: -WebKitTestRunner. -Common DRT + 6 implementations (Mac, Win, GTK, EFL, WX, Blackberry). -Chromium DRT. -Qt DRT. I think

Re: [webkit-dev] Can Qt use some of the common DRT code?

2013-02-10 Thread Benjamin Poulain
On Sun, Feb 10, 2013 at 10:56 PM, Jochen Eisinger joc...@chromium.orgwrote: Today, adding a support for a new function in TestRunner requires (painfully) changing: -WebKitTestRunner. -Common DRT + 6 implementations (Mac, Win, GTK, EFL, WX, Blackberry). -Chromium DRT. -Qt DRT. I think we

Re: [webkit-dev] Can Qt use some of the common DRT code?

2013-02-10 Thread Jochen Eisinger
On Mon, Feb 11, 2013 at 8:19 AM, Benjamin Poulain benja...@webkit.orgwrote: On Sun, Feb 10, 2013 at 10:56 PM, Jochen Eisinger joc...@chromium.orgwrote: Today, adding a support for a new function in TestRunner requires (painfully) changing: -WebKitTestRunner. -Common DRT + 6 implementations

Re: [webkit-dev] Can Qt use some of the common DRT code?

2013-02-10 Thread Benjamin Poulain
On Sun, Feb 10, 2013 at 11:20 PM, Jochen Eisinger joc...@chromium.orgwrote: I'm not sure I understand. In what cases do you then add something to DRT and need to change all of them? Take this for example: http://trac.webkit.org/changeset/130416 It does not make sense to test everything