We just discovered (via a rollout on bug 91103) that there’s a bug
with __MAC_OS_X_VERSION_MAX_ALLOWED in the version of the 10.5 SDK as
present in Xcode 3.2.6. This may be the last version of the 10.5 SDK ever
released (I haven’t checked all of the early Xcode 4 releases). Chromium
uses this SDK
Mark Rowe wrote:
It'd be complicated to do this more widely since the AvailabilityMacros.h
version of the macros are defined even when building for iOS. We'd need to
review all of the uses to ensure that they were handled correctly. Given
that I think it'd be better to just use this as a
On 2012-07-10, at 16:24, Mark Rowe mr...@apple.com wrote:
I'm open to feedback on this proposal, but I'd like to move forward with this
change in the next day or two if no one objects.
Given the lack of outcry I've posted patches on
https://bugs.webkit.org/show_bug.cgi?id=91015 that make
Tony brought me in to comment on what impact this might have on the
Chromium Mac build. It shouldn’t have any impact. Any use of the
compiler-defined macros is fine.
In Chrome code, we usually use MAC_OS_X_VERSION_MAX_ALLOWED and
MAC_OS_X_VERSION_MIN_REQUIRED from AvailabilityMacros.h, along with
On 2012-07-11, at 17:46, Mark Mentovai m...@chromium.org wrote:
Tony brought me in to comment on what impact this might have on the Chromium
Mac build. It shouldn’t have any impact. Any use of the compiler-defined
macros is fine.
I agree. The only impact I expect this to have is if I've
Mark Rowe wrote:
TN2064 appears to have been last modified in 2003, so it predates the
existence of Availability.h.
Well, that’s about as long as I’ve been writing SDK- and
deployment-target-aware code…
Availability.h was introduced with the iOS SDK in order to support
availability macros
I would like to propose removing the BUILDING_ON and TARGETING family of macros
that are used to build code conditionally for different versions of OS X. I
propose this in order to address several problems:
The checks are verbose, and getting worse.
For instance, in order to write code
Tony and Mark (Mentovai) would know more, but I believe the Chromium port
uses these macros in order to build against a specific SDK. For example,
the Chromium port currently builds against the 10.5 SDK. (This is slated
to change shortly as the Chromium project has dropped support for 10.5.)
8 matches
Mail list logo
