Re: [webkit-dev] Blob scheme implementation

2010-09-15 Thread Maciej Stachowiak
On Sep 14, 2010, at 9:58 PM, Jian Li wrote: Indeed when I implement BlobResourceHandle, I have taken the range request support into consideration and got it work. The problem is that current media element implementation does not route through ResourceHandle. However, introducing a

Re: [webkit-dev] Blob scheme implementation

2010-09-15 Thread Alexey Proskuryakov
14.09.2010, в 22:15, Darin Fisher написал(а): I think it makes sense to extend ResourceHandle.cpp to access the BlobRegistry singleton in order to support blob URLs. The problem I see with adding blob support to ResourceHandle is that it makes it too difficult to maintain. It used to be a

Re: [webkit-dev] Blob scheme implementation

2010-09-15 Thread Darin Fisher
On Wed, Sep 15, 2010 at 8:58 AM, Alexey Proskuryakov a...@webkit.org wrote: 14.09.2010, в 22:15, Darin Fisher написал(а): I think it makes sense to extend ResourceHandle.cpp to access the BlobRegistry singleton in order to support blob URLs. The problem I see with adding blob support to

Re: [webkit-dev] Blob scheme implementation

2010-09-15 Thread Maciej Stachowiak
On Sep 15, 2010, at 9:15 AM, Darin Fisher wrote: On Wed, Sep 15, 2010 at 8:58 AM, Alexey Proskuryakov a...@webkit.org wrote: 14.09.2010, в 22:15, Darin Fisher написал(а): I think it makes sense to extend ResourceHandle.cpp to access the BlobRegistry singleton in order to support blob

Re: [webkit-dev] Blob scheme implementation

2010-09-15 Thread Darin Fisher
On Wed, Sep 15, 2010 at 12:56 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 15, 2010, at 9:15 AM, Darin Fisher wrote: On Wed, Sep 15, 2010 at 8:58 AM, Alexey Proskuryakov a...@webkit.orgwrote: 14.09.2010, в 22:15, Darin Fisher написал(а): I think it makes sense to extend

Re: [webkit-dev] Blob scheme implementation

2010-09-15 Thread Darin Fisher
On Wed, Sep 15, 2010 at 1:06 PM, Darin Fisher da...@chromium.org wrote: On Wed, Sep 15, 2010 at 12:56 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 15, 2010, at 9:15 AM, Darin Fisher wrote: On Wed, Sep 15, 2010 at 8:58 AM, Alexey Proskuryakov a...@webkit.orgwrote: 14.09.2010, в

Re: [webkit-dev] Blob scheme implementation

2010-09-15 Thread Michael Nordman
On Wed, Sep 15, 2010 at 9:15 AM, Darin Fisher da...@chromium.org wrote: On Wed, Sep 15, 2010 at 8:58 AM, Alexey Proskuryakov a...@webkit.orgwrote: 14.09.2010, в 22:15, Darin Fisher написал(а): I think it makes sense to extend ResourceHandle.cpp to access the BlobRegistry singleton in

Re: [webkit-dev] Blob scheme implementation

2010-09-15 Thread Adam Barth
On Wed, Sep 15, 2010 at 1:09 PM, Darin Fisher da...@chromium.org wrote: I'm ignoring javascript: URLs because they are super weird... evaluation happens synchronously and can have side effects such as causing other navigations.  It does not fit the normal mold of URL loading.  Mozilla tries to

Re: [webkit-dev] Blob scheme implementation

2010-09-15 Thread Maciej Stachowiak
On Sep 15, 2010, at 1:06 PM, Darin Fisher wrote: On Wed, Sep 15, 2010 at 12:56 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 15, 2010, at 9:15 AM, Darin Fisher wrote: On Wed, Sep 15, 2010 at 8:58 AM, Alexey Proskuryakov a...@webkit.org wrote: 14.09.2010, в 22:15, Darin Fisher

Re: [webkit-dev] Blob scheme implementation

2010-09-15 Thread Maciej Stachowiak
On Sep 15, 2010, at 2:05 PM, Adam Barth wrote: On Wed, Sep 15, 2010 at 1:09 PM, Darin Fisher da...@chromium.org wrote: I'm ignoring javascript: URLs because they are super weird... evaluation happens synchronously and can have side effects such as causing other navigations. It does not fit

Re: [webkit-dev] Blob scheme implementation

2010-09-15 Thread Darin Fisher
On Wed, Sep 15, 2010 at 3:31 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 15, 2010, at 1:06 PM, Darin Fisher wrote: On Wed, Sep 15, 2010 at 12:56 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 15, 2010, at 9:15 AM, Darin Fisher wrote: On Wed, Sep 15, 2010 at 8:58 AM, Alexey

Re: [webkit-dev] Blob scheme implementation

2010-09-14 Thread Jian Li
When I implemented the blob scheme handling, I intentionally tried to have some common implementation that could be used by all applicable platforms. But it seems that introducing BlobResourceHandle derived from ResourceHandle might not be a good hook up point because ResourceHandle is only a

Re: [webkit-dev] Blob scheme implementation

2010-09-14 Thread Adam Barth
What do you think of the idea of having a re-useable BlobCore module that all the ports can share? Adam On Tue, Sep 14, 2010 at 5:39 PM, Jian Li jia...@chromium.org wrote: When I implemented the blob scheme handling, I intentionally tried to have some common implementation that could be used

Re: [webkit-dev] Blob scheme implementation

2010-09-14 Thread Jian Li
I think it is a good idea but it will involve lots of work to figure out how to build and test such module that could be used by all the ports. My concern is that I do not have enough resource to speak of for all other ports. Thanks. On Tue, Sep 14, 2010 at 5:42 PM, Adam Barth aba...@webkit.org

Re: [webkit-dev] Blob scheme implementation

2010-09-14 Thread David Levin
On Tue, Sep 14, 2010 at 5:42 PM, Adam Barth aba...@webkit.org wrote: What do you think of the idea of having a re-useable BlobCore module that all the ports can share? I don't think this is a good idea. This re-usable module would only be used by the Safari WebKit port. As I understand it,

Re: [webkit-dev] Blob scheme implementation

2010-09-14 Thread Adam Barth
On Tue, Sep 14, 2010 at 5:56 PM, David Levin le...@chromium.org wrote: On Tue, Sep 14, 2010 at 5:42 PM, Adam Barth aba...@webkit.org wrote: What do you think of the idea of having a re-useable BlobCore module that all the ports can share? I don't think this is a good idea. This re-usable

Re: [webkit-dev] Blob scheme implementation

2010-09-14 Thread Jian Li
On Tue, Sep 14, 2010 at 6:02 PM, Adam Barth aba...@webkit.org wrote: On Tue, Sep 14, 2010 at 5:56 PM, David Levin le...@chromium.org wrote: On Tue, Sep 14, 2010 at 5:42 PM, Adam Barth aba...@webkit.org wrote: What do you think of the idea of having a re-useable BlobCore module that all the

Re: [webkit-dev] Blob scheme implementation

2010-09-14 Thread Maciej Stachowiak
On Sep 14, 2010, at 6:02 PM, Adam Barth wrote: On Tue, Sep 14, 2010 at 5:56 PM, David Levin le...@chromium.org wrote: On Tue, Sep 14, 2010 at 5:42 PM, Adam Barth aba...@webkit.org wrote: What do you think of the idea of having a re-useable BlobCore module that all the ports can share? I

Re: [webkit-dev] Blob scheme implementation

2010-09-14 Thread Oliver Hunt
On Sep 14, 2010, at 5:56 PM, David Levin wrote: On Tue, Sep 14, 2010 at 5:42 PM, Adam Barth aba...@webkit.org wrote: What do you think of the idea of having a re-useable BlobCore module that all the ports can share? I don't think this is a good idea. This re-usable module would only be

Re: [webkit-dev] Blob scheme implementation

2010-09-14 Thread David Levin
On Tue, Sep 14, 2010 at 6:53 PM, Oliver Hunt oli...@apple.com wrote: On Sep 14, 2010, at 5:56 PM, David Levin wrote: On Tue, Sep 14, 2010 at 5:42 PM, Adam Barth aba...@webkit.org wrote: What do you think of the idea of having a re-useable BlobCore module that all the ports can share? I

Re: [webkit-dev] Blob scheme implementation

2010-09-14 Thread Darin Fisher
On Tue, Sep 14, 2010 at 5:52 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 14, 2010, at 5:22 PM, Adam Barth wrote: In some sense, this is analogous to adding an HTTPResourceHandle and implementing the HTTP protocol inside of WebCore. While its true that most (all?) users of

Re: [webkit-dev] Blob scheme implementation

2010-09-14 Thread Adam Barth
One thing that Maciej suggested in #webkit was to interpose in the same way that appcache interposes. One advantage of that approach is economy of mechanism. (By the way, roundtrips to WebCore are cheap for the WebKit layer; there isn't much reason to avoid them.) Adam On Tue, Sep 14, 2010 at

Re: [webkit-dev] Blob scheme implementation

2010-09-14 Thread Darin Fisher
I think it makes sense to extend ResourceHandle.cpp to access the BlobRegistry singleton in order to support blob URLs. This will work for all ports that use ResourceHandle.cpp (everyone except Chromium AFAIK). I don't think we need to overabstract this. When designing this system, we took a

Re: [webkit-dev] Blob scheme implementation

2010-09-14 Thread Darin Fisher
On Tue, Sep 14, 2010 at 10:09 PM, Adam Barth aba...@webkit.org wrote: One thing that Maciej suggested in #webkit was to interpose in the same way that appcache interposes. One advantage of that approach is economy of mechanism. I think we have mostly done this. See BlobRegistry. (By