Re: [webkit-dev] CMake as a build system?

2010-04-27 Thread Darin Fisher
On Fri, Apr 23, 2010 at 12:54 AM, Darin Fisher da...@chromium.org wrote: On Tue, Apr 20, 2010 at 10:53 AM, Peter Kasting pkast...@google.comwrote: On Tue, Apr 20, 2010 at 1:26 AM, Patrick Roland Gansterer par...@paroga.com wrote: Bradley Nelson: 1. Ability to incrementally transition

Re: [webkit-dev] CMake as a build system?

2010-04-23 Thread Darin Fisher
On Tue, Apr 20, 2010 at 10:53 AM, Peter Kasting pkast...@google.com wrote: On Tue, Apr 20, 2010 at 1:26 AM, Patrick Roland Gansterer par...@paroga.com wrote: Bradley Nelson: 1. Ability to incrementally transition on Windows. It took us about 6 months to switch fully to gyp. Previous

Re: [webkit-dev] CMake as a build system?

2010-04-23 Thread Patrick Roland Gansterer
On Fri, 23 Apr 2010 00:54:02 -0700, Darin Fisher da...@chromium.org wrote: Indeed. It also allows features like Ctrl+F7 (compile only the current source file) to work. A number of other common IDE features are lost if you use a makefile based vcproj. GYP nicely preserves all of those great

Re: [webkit-dev] CMake as a build system?

2010-04-23 Thread Darin Fisher
On Fri, Apr 23, 2010 at 1:44 AM, Patrick Roland Gansterer par...@paroga.com wrote: On Fri, 23 Apr 2010 00:54:02 -0700, Darin Fisher da...@chromium.org wrote: Indeed. It also allows features like Ctrl+F7 (compile only the current source file) to work. A number of other common IDE features

Re: [webkit-dev] CMake as a build system?

2010-04-21 Thread Marc-Antoine Ruel
2010/4/20 par...@paroga.com On Tue, 20 Apr 2010 10:53:55 -0700, Peter Kasting pkast...@google.com wrote: AIUI, readability isn't the issue, it's the ability for e.g. Visual Studio to correctly understand dependencies itself so that incremental builds from inside the IDE (which is where

Re: [webkit-dev] CMake as a build system?

2010-04-21 Thread Patrick Roland Gansterer
On Wed, 21 Apr 2010 12:36:17 -0400, Marc-Antoine Ruel mar...@chromium.org wrote: Are the sources under an open source license? I'd like to take a look if so. I'm sorry, they are closed source. :-( But I have working CMake files for JSC on Windows already. I'd like to clean them up an try to

Re: [webkit-dev] CMake as a build system?

2010-04-20 Thread Peter Kasting
On Tue, Apr 20, 2010 at 1:26 AM, Patrick Roland Gansterer par...@paroga.com wrote: Bradley Nelson: 1. Ability to incrementally transition on Windows. It took us about 6 months to switch fully to gyp. Previous attempts to move to scons had taken a long time and failed, due to the

Re: [webkit-dev] CMake as a build system?

2010-04-20 Thread paroga
On Tue, 20 Apr 2010 10:53:55 -0700, Peter Kasting pkast...@google.com wrote: AIUI, readability isn't the issue, it's the ability for e.g. Visual Studio to correctly understand dependencies itself so that incremental builds from inside the IDE (which is where most Windows Chromium developers do

Re: [webkit-dev] CMake as a build system?

2010-04-19 Thread Bradley Nelson
Here's the innards of an email with a laundry list of stuff I came up with a while back on the gyp-developers list in response to Mike Craddick regarding what motivated gyp's development, since we were aware of cmake at the time (we'd even started a speculative port): I did an exploratory port

Re: [webkit-dev] CMake as a build system?

2010-04-19 Thread Peter Kasting
On Mon, Apr 19, 2010 at 10:38 PM, Bradley Nelson bradnel...@google.comwrote: Here's the innards of an email with a laundry list of stuff I came up with a while back on the gyp-developers list in response to Mike Craddick regarding what motivated gyp's development, since we were aware of cmake

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Adam Treat
On Friday 16 April 2010 05:10:25 pm Bill Hoffman wrote: Hi, Adam Treat (tr...@kde.org) suggested that I join this list to talk about CMake as an option for a unified cross platform build solution. My name is Bill Hoffman. I am the lead CMake developer. My company Kitware created and

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Eric Seidel
I don't see this as a decision needing pre-approval. This is a decision needing code. No one has tried to make Mac, Win, or other ports use a common system yet. Obviously converting them in the end requires buy-in from those ports. But producing a demo doesn't/shouldn't. I eventually plan to

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Adam Treat
Sure. Having Bill's and Kitware's help will hopefully make it easier to produce such a demo using CMake. I pledge to help. We can start with this: http://trac.webkit.org/log/trunk/CMakeLists.txt?rev=17853 Cheers, Adam On Friday 16 April 2010 05:34:45 pm Eric Seidel wrote: I don't see this

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Maciej Stachowiak
On Apr 16, 2010, at 2:45 PM, Adam Treat wrote: Sure. Having Bill's and Kitware's help will hopefully make it easier to produce such a demo using CMake. I pledge to help. We can start with this: http://trac.webkit.org/log/trunk/CMakeLists.txt?rev=17853 Can CMake generate native Xcode

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Adam Treat
On Friday 16 April 2010 06:21:39 pm Maciej Stachowiak wrote: On Apr 16, 2010, at 2:45 PM, Adam Treat wrote: Sure. Having Bill's and Kitware's help will hopefully make it easier to produce such a demo using CMake. I pledge to help. We can start with this:

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Peter Kasting
On Fri, Apr 16, 2010 at 3:35 PM, Maciej Stachowiak m...@apple.com wrote: I'm curious if the Chromium folks who created Gyp had any specific reason that they ruled out CMake as an option. (I have heard that it was considered and rejected.) CCing a couple people involved if they wish to

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Bill Hoffman
On Fri, Apr 16, 2010 at 6:38 PM, Peter Kasting pkast...@google.com wrote: On Fri, Apr 16, 2010 at 3:35 PM, Maciej Stachowiak m...@apple.com wrote: I'm curious if the Chromium folks who created Gyp had any specific reason that they ruled out CMake as an option. (I have heard that it was

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Maciej Stachowiak
On Apr 16, 2010, at 5:50 PM, Bill Hoffman wrote: On Fri, Apr 16, 2010 at 6:38 PM, Peter Kasting pkast...@google.com wrote: On Fri, Apr 16, 2010 at 3:35 PM, Maciej Stachowiak m...@apple.com wrote: I'm curious if the Chromium folks who created Gyp had any specific reason that they ruled

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Nico Weber
This is from an earlier thread on this issue on webkit-dev: We also considered CMake, and had it demonstrably working for some of our smaller projects as well. Unfortunately, transitioning to CMake would have required moving everything over at once, without allowing for some existing projects

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Bill Hoffman
On Fri, Apr 16, 2010 at 9:45 PM, Maciej Stachowiak m...@apple.com wrote: FWIW, I don't have CMake installed, and I have everything a typical Apple developer would have and then some. I'm running SnowLeopard and the latest Xcode. CMake is also not installed by default on Windows and I am not

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Bill Hoffman
On Fri, Apr 16, 2010 at 9:57 PM, Nico Weber tha...@chromium.org wrote: This is from an earlier thread on this issue on webkit-dev: We also considered CMake, and had it demonstrably working for some of our smaller projects as well.  Unfortunately, transitioning to CMake would have required

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Adam Treat
On Friday 16 April 2010 09:58:17 pm Bill Hoffman wrote: Also: how hard is the dependency on being installed? Is this a solvable problem if it turns out to be a showstopper for some folks? It has to be installed, if this is a show stopper, then it is a show stopper. To be clear, it just

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Marc-Antoine Ruel
Thanks Nico for digging up the archive. As I said in the other thread, the people at the session mostly looked about reducing the number of build system, not forcing anyone to use any tool. If some teams wants to switch to CMake, prefect as long as the number of build tool reduces. Nobody seemed

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Bill Hoffman
We can make binaries available through a convenient download script (possibly one that gets a source drop and builds it) if we have to. In fact, when WebKit first switched to Subversion, for a while you had to get your own copy to even check out the tree. Sounds good. All I'm saying is

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Bill Hoffman
On Fri, Apr 16, 2010 at 10:04 PM, Adam Treat tr...@kde.org wrote: On Friday 16 April 2010 09:58:17 pm Bill Hoffman wrote: Also: how hard is the dependency on being installed? Is this a solvable problem if it turns out to be a showstopper for some folks? It has to be installed, if this is a

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Maciej Stachowiak
On Apr 16, 2010, at 7:17 PM, Bill Hoffman wrote: On Fri, Apr 16, 2010 at 10:10 PM, Marc-Antoine Ruel mar...@chromium.org wrote: Thanks Nico for digging up the archive. As I said in the other thread, the people at the session mostly looked about reducing the number of build system, not

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Bill Hoffman
Calling cmake during the build would likely be a showstopper for the Mac port. As far as I know, Apple's build farm does not have CMake installed (at least not on older build trains). And it's not easy to convince the build engineers to install custom build tools. I am told they have it now