On Sun, Feb 3, 2013 at 7:29 AM, Benjamin Poulain benja...@webkit.orgwrote:
On Sat, Feb 2, 2013 at 10:23 PM, Eric Seidel e...@webkit.org wrote:
What I've learned from this thread, is that AppleWin and AppleMac are the
only two ports which require lists of exported symbols. If both were to
On Feb 4, 2013, at 12:17 AM, Jochen Eisinger joc...@chromium.org wrote:
On Sun, Feb 3, 2013 at 7:29 AM, Benjamin Poulain benja...@webkit.org wrote:
On Sat, Feb 2, 2013 at 10:23 PM, Eric Seidel e...@webkit.org wrote:
What I've learned from this thread, is that AppleWin and AppleMac are the
On 02/01/2013 02:28 AM, Darin Fisher wrote:
It would be nice if, in the shared library build of chromium, webcore
and perhaps the modules and platform were separate DLLs.
The shared library build is kind of a developer build, right? In this
case I believe you can solve this by setting the
On Fri, Feb 1, 2013 at 5:12 PM, Balazs Kelemen kbal...@webkit.org wrote:
On 02/01/2013 02:28 AM, Darin Fisher wrote:
It would be nice if, in the shared library build of chromium, webcore and
perhaps the modules and platform were separate DLLs.
The shared library build is kind of a
On Sat, Feb 2, 2013 at 4:16 PM, James Robinson jam...@google.com wrote:
On Fri, Feb 1, 2013 at 5:12 PM, Balazs Kelemen kbal...@webkit.org wrote:
On 02/01/2013 02:28 AM, Darin Fisher wrote:
It would be nice if, in the shared library build of chromium, webcore
and perhaps the modules and
What I've learned from this thread, is that AppleWin and AppleMac are the
only two ports which require lists of exported symbols. If both were to
convert to using EXPORT decorators instead, then we could remove needs for
fixing export lists.
Please correct me if I've misunderstood.
Other ports
I should have been more clear. By which require lists of exported
symbols, I meant which require lists of exported symbols for WebCore.
The Internals discussion is obviously about WebCore symbols which are
exported through WebKit as well. It seems no other symbols from WebCore
should ever be
On Sat, Feb 2, 2013 at 10:23 PM, Eric Seidel e...@webkit.org wrote:
What I've learned from this thread, is that AppleWin and AppleMac are the
only two ports which require lists of exported symbols. If both were to
convert to using EXPORT decorators instead, then we could remove needs for
(From the right address)
I did it for WTF and JSC with kevino@.
https://bugs.webkit.org/show_bug.cgi?id=72855
I hope I had had time to extend the work to WebCore, which was my original
goal :-/
I did it through an automation but the tool was so slow and hacky that it
was not capable for large
On Thu, Jan 31, 2013 at 12:09 AM, Hajime Morrita morr...@google.com wrote:
I did it for WTF and JSC with kevino@.
https://bugs.webkit.org/show_bug.cgi?id=72855
I hope I had had time to extend the work to WebCore, which was my original
goal :-/
I did it through an automation but the tool was
On Thu, Jan 31, 2013 at 9:43 AM, Alexey Proskuryakov a...@apple.com wrote:
31.01.2013, в 0:17, Ryosuke Niwa rn...@webkit.org написал(а):
I did it for WTF and JSC with kevino@.
https://bugs.webkit.org/show_bug.cgi?id=72855
I hope I had had time to extend the work to WebCore, which was my
On Thu, Jan 31, 2013 at 9:48 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, Jan 31, 2013 at 9:43 AM, Alexey Proskuryakov a...@apple.com wrote:
31.01.2013, в 0:17, Ryosuke Niwa rn...@webkit.org написал(а):
I did it for WTF and JSC with kevino@.
https://bugs.webkit.org/show_bug.cgi?id=72855
31.01.2013, в 14:45, Dirk Pranke dpra...@chromium.org написал(а):
One thing to keep an eye on with WEBCORE_EXPORT is that it can increase
the number of exports for each port, because it would export symbols that
are only needed for other ports.
I'm not sure I understand the concern here.
On Thu, Jan 31, 2013 at 2:52 PM, Alexey Proskuryakov a...@apple.com wrote:
31.01.2013, в 14:45, Dirk Pranke dpra...@chromium.org написал(а):
One thing to keep an eye on with WEBCORE_EXPORT is that it can increase
the number of exports for each port, because it would export symbols that
are
31.01.2013, в 14:57, Dirk Pranke dpra...@chromium.org написал(а):
One thing to keep an eye on with WEBCORE_EXPORT is that it can increase
the number of exports for each port, because it would export symbols that
are only needed for other ports.
I'm not sure I understand the concern here.
On Thu, Jan 31, 2013 at 2:57 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, Jan 31, 2013 at 2:52 PM, Alexey Proskuryakov a...@apple.com wrote:
31.01.2013, в 14:45, Dirk Pranke dpra...@chromium.org написал(а):
One thing to keep an eye on with WEBCORE_EXPORT is that it can
increase
On Thu, Jan 31, 2013 at 3:12 PM, Alexey Proskuryakov a...@webkit.org wrote:
31.01.2013, в 14:57, Dirk Pranke dpra...@chromium.org написал(а):
One thing to keep an eye on with WEBCORE_EXPORT is that it can increase
the number of exports for each port, because it would export symbols that
are
31.01.2013, в 15:15, Dirk Pranke dpra...@chromium.org написал(а):
I don't have concrete examples, and I don't know how big an effect on
performance increasing the number of exports would have. It's something to
keep an eye on, not a reason to avoid trying.
I'm not parsing your reply
I believe that it's a design mistake for WebCore to need to know
anything about it's embedder, more than that there is a defined set of
platform APIs and callbacks which it talks to (which should be the
exact same for every embedder).
(The export dependency dates back to the WebCore/WebKit
The history aside, I think it makes sense to use the export macro
specifically for Mac WebCore because
- As Eric mentioned, Currently only Mac and Win WebCore do WebCore/WebKit
separation.
Other ports like GTK or Chromium build single WebKit library which has
both WebCore and WebKit API
It would be nice if, in the shared library build of chromium, webcore and
perhaps the modules and platform were separate DLLs.
On Jan 31, 2013 4:15 PM, Eric Seidel e...@webkit.org wrote:
I believe that it's a design mistake for WebCore to need to know
anything about it's embedder, more than
On Thu, Jan 31, 2013 at 5:20 PM, Hajime Morrita morr...@chromium.orgwrote:
The history aside, I think it makes sense to use the export macro
specifically for Mac WebCore because
- As Eric mentioned, Currently only Mac and Win WebCore do WebCore/WebKit
separation.
Other ports like GTK or
On Thu, Jan 31, 2013 at 5:39 PM, Ryosuke Niwa rn...@webkit.org wrote:
Doesn't GTK+ port also require symbol exports for WebKit2? In particular, I
thought all symbols used in Internals need to be exported there.
WebKitGTK+ does not need to export symbols from WebCore for WebKit2,
because WebCore
On Fri, Feb 1, 2013 at 10:39 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, Jan 31, 2013 at 5:20 PM, Hajime Morrita morr...@chromium.orgwrote:
The history aside, I think it makes sense to use the export macro
specifically for Mac WebCore because
- As Eric mentioned, Currently only Mac and
24 matches
Mail list logo
