[webkit-dev] Thank You

2008-09-05 Thread Darin Fisher
Hey all, I just wanted to say a big thank you for all that you have done in creating such an awesome rendering engine. Our new browser was made possible because of WebKit, and I hope that when people talk about Chrome that they understand that WebKit is at the heart of it. So, I just put up a

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Darin Fisher
[resent from an address mailman knows about] On Wed, Sep 24, 2008 at 3:36 PM, Darin Fisher [EMAIL PROTECTED] wrote: On Wed, Sep 24, 2008 at 2:16 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Sep 24, 2008, at 12:14 PM, Amanda Walker wrote: Hello all, A conversation started on https

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Darin Fisher
[resent, doh... that's it, i'm registering my other email address] On Wed, Sep 24, 2008 at 4:32 PM, Darin Fisher [EMAIL PROTECTED] wrote: On Wed, Sep 24, 2008 at 4:22 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Sep 24, 2008, at 3:30 PM, Amanda Walker wrote: The renderer process

Re: [webkit-dev] setTimeout as browser speed throttle

2008-10-01 Thread Darin Fisher
On Tue, Sep 30, 2008 at 11:55 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Sep 30, 2008, at 10:36 PM, Darin Fisher wrote: On Tue, Sep 30, 2008 at 7:14 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: ... 2) Consider making WebKit's default minimum timer limit lower - something like

Re: [webkit-dev] setTimeout as browser speed throttle

2008-10-01 Thread Darin Fisher
On Wed, Oct 1, 2008 at 2:34 AM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 1, 2008, at 1:24 AM, David Hyatt wrote: On Oct 1, 2008, at 2:52 AM, Darin Fisher wrote: I can appreciate that you aren't interested in revisiting this problem after having resolved it finally by adding

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 2:23 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 1:07 PM, Brett Wilson wrote: About a year ago, Google released the Google URL Parsing and Canonicalization Library (Google-URL) as a separate open-source project:

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 3:01 PM, Geoffrey Garen [EMAIL PROTECTED] wrote: One thing I'd like to highlight: It is a requirement for Chromium to use consistent URL parsing throughout the entire application. Can you explain this requirement more? I think that's an important data point, since

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 3:27 PM, David Hyatt [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 4:23 PM, Maciej Stachowiak wrote: I have mentioned optionally replacing KURL with an ifdef to a number of WebKit members. The reception has been tentatively yes. As one of the people who were asked

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 3:43 PM, David Hyatt [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 5:35 PM, Darin Fisher wrote: On Thu, Oct 2, 2008 at 3:27 PM, David Hyatt [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 4:23 PM, Maciej Stachowiak wrote: I have mentioned optionally replacing KURL

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 3:53 PM, Geoffrey Garen [EMAIL PROTECTED] wrote: KURL depends on WebCore types, and was found to have bugs, so Brett did a study of other URL parsers and wrote the Google URL library as a template library (and wrote GURL as an example class using it with std::string).

Re: [webkit-dev] High Resolution Timer API proposal(s)

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 5:32 PM, Ojan Vafai [EMAIL PROTECTED] wrote: On Thu, Oct 2, 2008 at 5:16 PM, Aaron Boodman [EMAIL PROTECTED] wrote: On Thu, Oct 2, 2008 at 5:05 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: I don't really like the overengineered version. I like the fairly minimalist

Re: [webkit-dev] High Resolution Timer API proposal(s)

2008-10-02 Thread Darin Fisher
On a separate thread, it was discussed that it is useful to support microsecond resolution for future proofness. -Darin On Thu, Oct 2, 2008 at 5:53 PM, Timothy Hatcher [EMAIL PROTECTED]wrote: Why double delayInSeconds and not milliseconds to stay consistent? On Oct 2, 2008, at 5:32 PM, Ojan

Re: [webkit-dev] Long-term Google-URL integration plans

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 6:40 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 6:26 PM, Peter Kasting wrote: The prospect of WTF types in general tends to make me leery, since using one can bring in dependencies on others, and we wouldn't want to bring more dependencies than

Re: [webkit-dev] setTimeout as browser speed throttle

2008-10-02 Thread Darin Fisher
On Wed, Oct 1, 2008 at 5:26 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 1, 2008, at 5:03 PM, Darin Fisher wrote: On Wed, Oct 1, 2008 at 2:34 AM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 1, 2008, at 1:24 AM, David Hyatt wrote: On Oct 1, 2008, at 2:52 AM, Darin Fisher

Re: [webkit-dev] setTimeout as browser speed throttle

2008-10-03 Thread Darin Fisher
On Thu, Oct 2, 2008 at 10:36 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 10:09 PM, Darin Fisher wrote: On Thu, Oct 2, 2008 at 9:58 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 9:39 PM, Darin Fisher wrote: In short, our architecture makes me

Re: [webkit-dev] The WebCore/platform/ directory situation

2008-10-04 Thread Darin Fisher
On Sat, Oct 4, 2008 at 12:27 AM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 3, 2008, at 9:17 PM, David Hyatt wrote: After working for a while on the WebCore/platform/ directory, it's become clear that people don't really know what this directory is supposed to contain (and by

[webkit-dev] PLATFORM(CHROMIUM), etc.

2008-10-28 Thread Darin Fisher
As some of you may have noticed, there is now a PLATFORM(CHROMIUM) define that is being used in WebKit. I thought it might be helpful to describe what it is and explain why it exists. PLATFORM(CHROMIUM) corresponds to the WebKit porting layer implementation used by the Chromium (aka Google

Re: [webkit-dev] Save Page - Ideas

2008-10-30 Thread Darin Fisher
On Thu, Oct 30, 2008 at 9:33 AM, David Kilzer [EMAIL PROTECTED] wrote: On Thu, 10/30/08, zaheer ahmad [EMAIL PROTECTED] wrote: iam working on implementing save page functionality. Looks like its not already supported in the core. Apple's Mac port saves .webarchive files. The format is

Re: [webkit-dev] Save Page - Ideas

2008-11-05 Thread Darin Fisher
On Wed, Nov 5, 2008 at 11:06 AM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Nov 5, 2008, at 10:22 AM, Darin Fisher wrote: On Wed, Nov 5, 2008 at 7:04 AM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 30, 2008, at 9:47 AM, Darin Fisher wrote: We have code to support this feature

Re: [webkit-dev] http cache support - rfc2616

2008-11-15 Thread Darin Fisher
The http caching logic for chromium lives here: http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_cache.cc?view=markup WebKit does not have code for a network stack. Instead, each port provides a network stack, typically by using a system library. -Darin On Sat, Nov 15, 2008 at 9:01

Re: [webkit-dev] http cache support - rfc2616

2008-11-17 Thread Darin Fisher
for it's internal memory cache and will implement more. See https://bugs.webkit.org/show_bug.cgi?id=17998 for details. antti 2008/11/15 Darin Fisher [EMAIL PROTECTED]: The http caching logic for chromium lives here: http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_cache.cc

Re: [webkit-dev] XMLHttpRequest and Workers

2008-12-16 Thread Darin Fisher
2008/12/15 Alexey Proskuryakov a...@webkit.org Dec 15, 2008, в 9:47 AM, David Levin написал(а): This is how I plan to finish making XMLHttpRequest available for workers http://docs.google.com/Doc?id=dg7mj9sd_6dvthmdqj Let me know if you have any comments. As discussed earlier, this

Re: [webkit-dev] #if PLATFORM(CF) || (PLATFORM(QT) PLATFORM(DARWIN))

2009-01-30 Thread Darin Fisher
Just speculating, but probably because there are cases where a QT API should be used instead of a CF API. This probably just happens to be a time when the CF API is preferred (maybe a QT alternative does not exist?). (We are in a similar boat with PLATFORM(CHROMIUM), which is why this topic is

Re: [webkit-dev] #if PLATFORM(CF) || (PLATFORM(QT) PLATFORM(DARWIN))

2009-01-30 Thread Darin Fisher
I didn't have a specific example with CF in mind. Since the Mac port of Chromium is sharing things like PLATFORM(CG), I can imagine there being issues like this coming up. -Darin On Fri, Jan 30, 2009 at 9:17 AM, Darin Adler da...@apple.com wrote: On Jan 30, 2009, at 9:10 AM, Darin Fisher

Re: [webkit-dev] Upstreaming IDL changes for the V8 bindings

2009-02-04 Thread Darin Fisher
Yup, that was my plan. Custom will be respected by both code generators. -Darin On Tue, Feb 3, 2009 at 4:06 PM, Dimitri Glazkov dglaz...@google.com wrote: To minimize the span of the changes, let's keep Custom as well, which in this context should mean -- Custom for all platforms. WDYT?

Re: [webkit-dev] Chromium Unforking: Please hold off on big changes for a day or so

2009-05-08 Thread Darin Fisher
Victory! http://build.chromium.org/buildbot/waterfall.fyi/waterfall?builder=Webkit%20(webkit.org) To those not working on Chromium, that is our buildbot that builds Chromium trunk against WebKit trunk. That implies zero forks, and to have it green--and passing the same layout tests as our normal

Re: [webkit-dev] Chromium Unforking: Please hold off on big changes for a day or so

2009-05-10 Thread Darin Fisher
On Thu, May 7, 2009 at 11:35 PM, Darin Fisher da...@google.com wrote: 3- A WebKit layer API (this is brewing herehttp://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebKit/chromium/ in case you want a sneak peak; it exists in our tree presently to ease the transition from

Re: [webkit-dev] Should we restrict Web Fonts to same-origin by default?

2009-06-23 Thread Darin Fisher
On Mon, Jun 22, 2009 at 1:26 PM, Ojan Vafai o...@chromium.org wrote: On Mon, Jun 22, 2009 at 12:45 PM, David Hyatt hy...@apple.com wrote: On Jun 22, 2009, at 2:38 PM, Maciej Stachowiak wrote: Mozilla restricts downloaded fonts to same-origin by default, with the ability for the hosting site

Re: [webkit-dev] Detecting a finished paint via JavaScript

2009-07-08 Thread Darin Fisher
While this is not a perfect solution, a common technique is to call (from onload) a DOM method like offsetHeight that forces layout to run. That way the bulk of the work required to paint is forced to happen before the benchmark considers the page load complete. -Darin On Wed, Jul 8, 2009 at

Re: [webkit-dev] Coding convention of constants

2009-07-09 Thread Darin Fisher
Ditto. The last time I wondered about this, I grepped through the code and found [1] to be the most prevalent. So, in code reviews I have been recommending people do [1]. -Darin On Thu, Jul 9, 2009 at 8:16 PM, Dimitri Glazkov dglaz...@chromium.orgwrote: If we're voting, then +1 to [1]. If

Re: [webkit-dev] Chrome build bot

2009-07-11 Thread Darin Fisher
good revision* in its weakest meaning. If curious, more info at http://dev.chromium.org/developers/try-server-usage#TOC-LKGR M-A On Tue, Jul 7, 2009 at 2:11 PM, Darin Fisher da...@chromium.org wrote: We are working on it. It is taking more time than we'd like :-( For now, we only have

[webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread Darin Fisher
I noticed that some new form validation code is landing (e.g., http://trac.webkit.org/changeset/45739). That change adds stubs for the ValidityState object. What I didn't see in that patch is any kind of ENABLE flag. I suspect there should be one since otherwise it becomes difficult for a web

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread Darin Fisher
On Mon, Jul 13, 2009 at 2:55 PM, Maciej Stachowiak m...@apple.com wrote: On Jul 13, 2009, at 11:57 AM, David Hyatt wrote: On Jul 13, 2009, at 1:52 PM, Jeremy Orlow wrote: On Mon, Jul 13, 2009 at 11:40 AM, David Hyatt hy...@apple.com wrote: On Jul 13, 2009, at 12:52 PM, Peter Kasting

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread Darin Fisher
On Mon, Jul 13, 2009 at 3:17 PM, David Hyatt hy...@apple.com wrote: On Jul 13, 2009, at 5:02 PM, Darin Fisher wrote: This small interval rule-of-thumb idea sounds pretty good, but I still wish it didn't put the burden on the guy doing the branch to figure out what is or isn't incomplete

Re: [webkit-dev] Build File Maintenance (was Re: Please welcome GYP to the our dysfunctional build family)

2009-07-14 Thread Darin Fisher
On Tue, Jul 14, 2009 at 10:27 AM, Peter Kasting pkast...@google.com wrote: On Tue, Jul 14, 2009 at 9:24 AM, Kevin Ollivier kev...@theolliviers.comwrote: Of course, the big question is if waf would have the same limitations as SCons in regards to doing this, but I think it's at least worth

Re: [webkit-dev] exposing the value of Accept-Language via window.navigation.acceptLanguage ?

2009-07-22 Thread Darin Fisher
2009/7/22 Alexey Proskuryakov a...@webkit.org 22.07.2009, в 16:41, Jungshik Shin (신정식, 申政湜) написал(а): Some web apps/widgets/browser extensions can also benefit from knowing the ordered list of languages in Accept-Language. I should note that Safari only sends one language. The reasons

Re: [webkit-dev] exposing the value of Accept-Language via window.navigation.acceptLanguage ?

2009-07-23 Thread Darin Fisher
On Wed, Jul 22, 2009 at 10:52 PM, Alexey Proskuryakov a...@webkit.org wrote: 22.07.2009, в 22:36, Darin Fisher написал(а): Firefox and Chrome send very similar A-L headers. Given FF's marketshare, I'm surprised you observed compat problems with doing the same. Was that a recent

[webkit-dev] willCacheResponse

2009-08-04 Thread Darin Fisher
There is a Mac-only willCacheResponse notification that gets recorded by several of the layout tests when layoutTestController.dumpResourceLoadCallbacks(true) is called. However, this notification which originates at the ResourceHandle level is currently #if PLATFORM(MAC). I noticed that the

Re: [webkit-dev] unwritten rules of webkit style

2009-09-03 Thread Darin Fisher
GCC will complain (maybe only a warning?) if C++ files don't end in a newline.-Darin On Thu, Sep 3, 2009 at 1:03 PM, Gavin Barraclough barraclo...@apple.comwrote: I believe the C spec requires that files end in a newline, though I couldn't comment on the c++ spec. Possibly redundant to list

Re: [webkit-dev] Runtime setting for incomplete features

2009-09-09 Thread Darin Fisher
Perhaps... any suggestions?-Darin On Wed, Sep 9, 2009 at 8:45 AM, Adam Barth aba...@webkit.org wrote: Maybe it's worth distinguishing these settings with some sort of naming convention so that embedders know they'll be removed at some point? Adam On Tue, Sep 8, 2009 at 11:47 PM, Darin

Re: [webkit-dev] Passing data structures through postMessage()

2009-09-10 Thread Darin Fisher
Given shared workers (and indeed Chromium's out-of-process dedicated workers), it seems like we also have cross process boundaries to consider. -Darin On Thu, Sep 10, 2009 at 5:21 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 10, 2009, at 3:12 PM, Chris Campbell wrote: Hi All, I had

Re: [webkit-dev] Passing data structures through postMessage()

2009-09-11 Thread Darin Fisher
On Thu, Sep 10, 2009 at 5:21 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 10, 2009, at 3:12 PM, Chris Campbell wrote: Hi All, I had it in mind to implement support for passing data structures through postMessage() using the structured clone algorithm laid out in the HTML5 spec:

Re: [webkit-dev] Back/forward cache for pages with unload handlers

2009-09-15 Thread Darin Fisher
I'm very confused by this change. If a page has an unload handler, then Firefox does not put the page in the bfcache. So the author of a page that has an unload handler would have no reason to include a pagehide handler. Does this change mean that unload handlers are never run? Or, are they run

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-16 Thread Darin Fisher
On Wed, Sep 16, 2009 at 2:21 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 16, 2009, at 1:58 PM, John Abd-El-Malek wrote: Either way though, I don't think it'll work in this case. I've seen pages have 8 beforeunload/unload handlers each sleeping for 200ms, just so that they don't

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-16 Thread Darin Fisher
On Wed, Sep 16, 2009 at 9:59 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 16, 2009, at 4:49 PM, Darin Fisher wrote: On Wed, Sep 16, 2009 at 2:21 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 16, 2009, at 1:58 PM, John Abd-El-Malek wrote: Either way though, I don't think

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-16 Thread Darin Fisher
On Wed, Sep 16, 2009 at 10:33 PM, Darin Fisher da...@chromium.org wrote: On Wed, Sep 16, 2009 at 9:59 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 16, 2009, at 4:49 PM, Darin Fisher wrote: On Wed, Sep 16, 2009 at 2:21 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 16, 2009

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Darin Fisher
On Wed, Sep 16, 2009 at 10:57 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 16, 2009, at 10:33 PM, Darin Fisher wrote: On Wed, Sep 16, 2009 at 9:59 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 16, 2009, at 4:49 PM, Darin Fisher wrote: Counting work instead of time is much

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Darin Fisher
On Wed, Sep 16, 2009 at 11:46 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 16, 2009, at 10:47 PM, Darin Fisher wrote: By the way, to be clear these ads aren't on the critical path for link clicks. A navigation occurs, and the ad just observes unload. During unload it presumably

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Darin Fisher
On Thu, Sep 17, 2009 at 2:28 AM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 12:35 AM, Darin Fisher wrote: For a ping to be used as I suggested, you would need to set the href to a javascript URL such as javascript:void(), so that it would not interfere with an existing

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Darin Fisher
On Thu, Sep 17, 2009 at 12:52 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 12:14 PM, Darin Fisher wrote: On Thu, Sep 17, 2009 at 2:28 AM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 12:35 AM, Darin Fisher wrote: For a ping to be used as I suggested

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Darin Fisher
On Thu, Sep 17, 2009 at 4:05 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 2:09 PM, Darin Fisher wrote: On Thu, Sep 17, 2009 at 12:52 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 12:14 PM, Darin Fisher wrote: On Thu, Sep 17, 2009 at 2:28 AM

Re: [webkit-dev] Runtime setting for incomplete features

2009-10-05 Thread Darin Fisher
roll out these changes if they cannot be fixed in a timely manner. -Sam On Tue, Sep 8, 2009 at 11:47 PM, Darin Fisher da...@chromium.org wrote: As is described in https://bugs.webkit.org/show_bug.cgi?id=28941, for the Chromium project, we like to make incomplete features available behind

Re: [webkit-dev] Runtime setting for incomplete features

2009-10-05 Thread Darin Fisher
On Mon, Oct 5, 2009 at 6:43 PM, Maciej Stachowiak m...@apple.com wrote: On Oct 5, 2009, at 6:20 PM, Sam Weinig wrote: On Mon, Oct 5, 2009 at 5:46 PM, Drew Wilson atwil...@google.com wrote: I'm surprised to see these objections coming up now, weeks after the original discussion, and only

Re: [webkit-dev] Runtime setting for incomplete features

2009-10-05 Thread Darin Fisher
On Mon, Oct 5, 2009 at 9:45 PM, Maciej Stachowiak m...@apple.com wrote: On Oct 5, 2009, at 9:17 PM, Darin Fisher wrote: On Mon, Oct 5, 2009 at 6:43 PM, Maciej Stachowiak m...@apple.com wrote: On Oct 5, 2009, at 6:20 PM, Sam Weinig wrote: On Mon, Oct 5, 2009 at 5:46 PM, Drew Wilson

Re: [webkit-dev] Runtime setting for incomplete features

2009-10-05 Thread Darin Fisher
On Mon, Oct 5, 2009 at 9:54 PM, Mark Rowe mr...@apple.com wrote: On 2009-10-05, at 21:48, Darin Fisher wrote: It is a matter of our process that we do not change the configuration when promoting builds. The bits that passed the test get promoted. I'm happy to absorb this cost in the V8

Re: [webkit-dev] Runtime setting for incomplete features

2009-10-05 Thread Darin Fisher
On Mon, Oct 5, 2009 at 9:56 PM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Oct 5, 2009 at 9:54 PM, Mark Rowe mr...@apple.com wrote: On 2009-10-05, at 21:48, Darin Fisher wrote: It is a matter of our process that we do not change the configuration when promoting builds. The bits

Re: [webkit-dev] Runtime setting for incomplete features

2009-10-05 Thread Darin Fisher
that it will be tested as it is brought up. https://bugs.webkit.org/show_bug.cgi?id=27206 Is is ok to turn off by default from this point of view? On Tue, Oct 6, 2009 at 1:57 PM, Darin Fisher da...@chromium.org wrote: On Mon, Oct 5, 2009 at 9:54 PM, Mark Rowe mr...@apple.com wrote: On 2009-10-05, at 21:48

Re: [webkit-dev] Runtime setting for incomplete features

2009-10-05 Thread Darin Fisher
On Mon, Oct 5, 2009 at 10:35 PM, Dmitry Titov dim...@chromium.org wrote: On Mon, Oct 5, 2009 at 9:48 PM, Sam Weinig sam.wei...@gmail.com wrote: I would still very much like a good solution to runtime enabling/disabling features in the bindings as I think this would be a useful addition to the

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-10-15 Thread Darin Fisher
On Wed, Oct 14, 2009 at 7:53 PM, Maciej Stachowiak m...@apple.com wrote: On Oct 14, 2009, at 6:43 PM, John Abd-El-Malek wrote: To resurrect this thread. I'm looking in implementing some of the methods that we discussed so that web developers have no excuse in simulating sleeps in unload

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-10-15 Thread Darin Fisher
On Thu, Oct 15, 2009 at 1:53 PM, Peter Kasting pkast...@google.com wrote: On Thu, Oct 15, 2009 at 1:50 PM, John Abd-El-Malek j...@google.com wrote: Does this argue for making the image loading trick work all the time from JS, not just from unload handlers? I tested with IE and it looks like

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread Darin Fisher
On Mon, Oct 19, 2009 at 1:37 PM, Peter Kasting pkast...@google.com wrote: On Mon, Oct 19, 2009 at 1:31 PM, David Hyatt hy...@apple.com wrote: You aren't only selecting text on a page though. For example, copying can be of all the HTML content. This includes tables, images, plugins, etc. If

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread Darin Fisher
On Mon, Oct 19, 2009 at 1:43 PM, Peter Kasting pkast...@google.com wrote: On Mon, Oct 19, 2009 at 1:40 PM, Darin Fisher da...@chromium.org wrote: I think there is a good use case for copying a selection of HTML from any web page and pasting that into the rich text editor of a web mail program

Re: [webkit-dev] WebKit on the server side

2009-11-17 Thread Darin Fisher
The Chromium port of WebKit already acts very much like a headless build of WebKit owing to the Chromium sandbox, which denies the WebKit process access to most features of the system, including the GUI system. The interface lives here: http://trac.webkit.org/browser/trunk/WebKit/chromium

[webkit-dev] Why are some layout tests renamed with a suffix of -disabled?

2009-11-25 Thread Darin Fisher
Why are some layout tests renamed with a suffix of -disabled? Why aren't such tests simply added to the skipped list? Is -disabled simply the old way? -Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Why are some layout tests renamed with a suffix of -disabled?

2009-11-25 Thread Darin Fisher
On Wed, Nov 25, 2009 at 10:44 AM, Dan Bernstein m...@apple.com wrote: On Nov 25, 2009, at 10:38 AM, Darin Fisher wrote: On Wed, Nov 25, 2009 at 10:35 AM, Dan Bernstein m...@apple.com wrote: On Nov 25, 2009, at 9:55 AM, Darin Fisher wrote: Why are some layout tests renamed with a suffix

Re: [webkit-dev] GlobalScript in WebKit

2009-11-30 Thread Darin Fisher
On Mon, Nov 30, 2009 at 2:30 PM, Alexey Proskuryakov a...@webkit.org wrote: On 30.11.2009, at 14:05, Dmitry Titov wrote: That also pretty much means if we won't have SharedScript, we'll need to explore other opportunities toward efficient sharing of code and data which does not make people

Re: [webkit-dev] GlobalScript in WebKit

2009-11-30 Thread Darin Fisher
On Mon, Nov 30, 2009 at 2:56 PM, Oliver Hunt oli...@apple.com wrote: In Chrome, a SharedWorker is reachable from any WebKit process, whereas a SharedScript would only be reachable within a WebKit process. This is an interesting distinction, and I can imagine some use cases for SharedWorker

Re: [webkit-dev] GlobalScript in WebKit

2009-11-30 Thread Darin Fisher
On Mon, Nov 30, 2009 at 3:08 PM, Geoffrey Garen gga...@apple.com wrote: Just a note: In Chrome, a SharedWorker is reachable from any WebKit process, whereas a SharedScript would only be reachable within a WebKit process. This is an interesting distinction, and I can imagine some use

Re: [webkit-dev] SharedScript/Worker and multiprocess browsers

2009-11-30 Thread Darin Fisher
On Mon, Nov 30, 2009 at 4:07 PM, Oliver Hunt oli...@apple.com wrote: On Nov 30, 2009, at 3:43 PM, Dmitry Titov wrote: I don't think it's correct to say that SharedWorkers are not useful and we need a SharedScript instead. They are different things and can address different use cases. For

Re: [webkit-dev] SharedScript/Worker and multiprocess browsers

2009-11-30 Thread Darin Fisher
On Mon, Nov 30, 2009 at 6:34 PM, Charles Reis cr...@chromium.org wrote: On Mon, Nov 30, 2009 at 6:16 PM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Nov 30, 2009 at 5:58 PM, Oliver Hunt oli...@apple.com wrote: On Nov 30, 2009, at 5:40 PM, Jeremy Orlow wrote: On Mon, Nov 30, 2009 at

Re: [webkit-dev] SharedScript/Worker and multiprocess browsers

2009-11-30 Thread Darin Fisher
On Mon, Nov 30, 2009 at 5:45 PM, Peter Kasting pkast...@google.com wrote: On Mon, Nov 30, 2009 at 5:05 PM, Oliver Hunt oli...@apple.com wrote: It is wrong to design an API based on architectural decisions of your existing browser -- you should be making decisions based on what the developers

Re: [webkit-dev] GlobalScript in WebKit

2009-11-30 Thread Darin Fisher
On Mon, Nov 30, 2009 at 7:55 PM, Maciej Stachowiak m...@apple.com wrote: On Nov 30, 2009, at 6:16 PM, Drew Wilson wrote: Following up, I think this highlights the distinct set of use cases that shared workers and shared script address: SharedWorkers are a great platform for when you have a

Re: [webkit-dev] SharableScriptContext [was: GlobalScript in WebKit]

2009-11-30 Thread Darin Fisher
On Mon, Nov 30, 2009 at 8:52 PM, Oliver Hunt oli...@apple.com wrote: On Nov 30, 2009, at 8:31 PM, Darin Fisher wrote: On Mon, Nov 30, 2009 at 7:55 PM, Maciej Stachowiak m...@apple.com wrote: On Nov 30, 2009, at 6:16 PM, Drew Wilson wrote: Following up, I think this highlights

Re: [webkit-dev] SharableScriptContext [was: GlobalScript in WebKit]

2009-11-30 Thread Darin Fisher
shared script context. and, possibly: add a list (regexp?) to App Cache manifest to describe the set of URLs loaded into the same process to make them able to find each other without relying on window.open(). Yes. -Darin Dmitry On Mon, Nov 30, 2009 at 9:07 PM, Darin Fisher da

Re: [webkit-dev] trac.webkit.org links via Google.com

2009-11-30 Thread Darin Fisher
perhaps the crawlers put too much load on trac? -darin On Mon, Nov 30, 2009 at 10:36 PM, Eric Seidel e...@webkit.org wrote: It's bothered me for a while that I can't just type trac webkit Document.cpp into Google and have it give me a trac link to our Document.cpp page.

Re: [webkit-dev] lxr.webkit.org

2009-11-30 Thread Darin Fisher
+1 On Mon, Nov 30, 2009 at 10:31 PM, Eric Seidel e...@webkit.org wrote: Curious if we've ever tossed around the idea of setting up an lxr for webkit? Maybe the functionality of being able to click on a function name and have it jump to the definition already exists somewhere on the web for

Re: [webkit-dev] localStorage quota limit

2009-12-02 Thread Darin Fisher
This would probably be a performance win since it would reduce the amount of disk i/o. (Note, it doesn't mean that 5 million characters could be stored since a UTF-8 character might be multi-byte.) -Darin On Wed, Dec 2, 2009 at 9:30 AM, Michael Nordman micha...@google.com wrote: Could WebKit

Re: [webkit-dev] localStorage quota limit

2009-12-02 Thread Darin Fisher
2, 2009, at 9:49 AM, Darin Fisher wrote: This would probably be a performance win since it would reduce the amount of disk i/o. (Note, it doesn't mean that 5 million characters could be stored since a UTF-8 character might be multi-byte.) Currently the database can store invalid UTF-16

Re: [webkit-dev] localStorage quota limit

2009-12-02 Thread Darin Fisher
What about Maciej's comment. JS strings are often use to store binary values. Obviously, if people stick to octets, then it should be fine, but perhaps some folks leverage all 16 bits? -Darin On Wed, Dec 2, 2009 at 5:03 PM, Ian Hickson i...@hixie.ch wrote: On Wed, 2 Dec 2009, Michael Nordman

Re: [webkit-dev] localStorage quota limit

2009-12-02 Thread Darin Fisher
On Wed, Dec 2, 2009 at 8:44 PM, Maciej Stachowiak m...@apple.com wrote: On Dec 2, 2009, at 8:14 PM, Darin Fisher wrote: What about Maciej's comment. JS strings are often use to store binary values. Obviously, if people stick to octets, then it should be fine, but perhaps some folks

Re: [webkit-dev] localStorage quota limit

2009-12-02 Thread Darin Fisher
On Wed, Dec 2, 2009 at 10:20 PM, Maciej Stachowiak m...@apple.com wrote: On Dec 2, 2009, at 9:07 PM, Darin Fisher wrote: On Wed, Dec 2, 2009 at 8:44 PM, Maciej Stachowiak m...@apple.com wrote: On Dec 2, 2009, at 8:14 PM, Darin Fisher wrote: What about Maciej's comment. JS strings

Re: [webkit-dev] Proposing style guide change regarding braces on conditional arms

2009-12-03 Thread Darin Fisher
Ditto. On Thu, Dec 3, 2009 at 7:25 PM, Kenneth Christiansen kenneth.christian...@openbossa.org wrote: I'm OK with both. Peter's is my preferred solution, though. Kenneth On Thu, Dec 3, 2009 at 11:39 PM, Dirk Pranke dpra...@chromium.org wrote: +1. Peter's is better than Maciej's is

Re: [webkit-dev] Proposing style guide change regarding braces on conditional arms

2009-12-04 Thread Darin Fisher
On Fri, Dec 4, 2009 at 9:39 AM, Adam Treat tr...@kde.org wrote: On Friday 04 December 2009 12:17:03 pm Jeremy Orlow wrote: I'm not necessarily disagreeing with your conclusion, but I have to ask: can you think of an example of a style change that isn't subjective and/or something that can

Re: [webkit-dev] WebSocket threading design

2009-12-08 Thread Darin Fisher
Sounds right to me since it mirrors the solution used to enable XHR from workers. -Darin On Tue, Dec 8, 2009 at 11:25 PM, Fumitoshi Ukai (鵜飼文敏) u...@chromium.orgwrote: Right now, WebSocket uses WebSocketChannel and SocketStreamHandle directly, but this might not work well if the WebSocket is

Re: [webkit-dev] SharedScript: next steps and result of offline discussion.

2009-12-14 Thread Darin Fisher
I think that use case has been de-emphasized. However, if we wanted to support it, we'd probably have to say that removeChild of an IFRAME element doesn't cause the unload event to be dispatched. (I'm a bit concerned that that may cause incompatibilities with existing pages.) Then, you'd have

Re: [webkit-dev] SharedScript: next steps and result of offline discussion.

2009-12-15 Thread Darin Fisher
On Tue, Dec 15, 2009 at 11:09 AM, Michael Nordman micha...@google.comwrote: On Mon, Dec 14, 2009 at 9:16 PM, Darin Fisher da...@chromium.org wrote: I think that use case has been de-emphasized. However, if we wanted to support it, we'd probably have to say that removeChild of an IFRAME

[webkit-dev] #endif // Foo_h

2010-01-04 Thread Darin Fisher
I noticed recently that the style bot started complaining about header files ending with #endif instead of #endif // Foo_h. I was surprised by this since the style guide does not require it. Should the style guide be changed to require this comment, or should the style bot be taught to ignore

Re: [webkit-dev] Blacklisting some sqlite functions

2010-01-07 Thread Darin Fisher
On Thu, Jan 7, 2010 at 10:02 AM, Brady Eidson beid...@apple.com wrote: On Jan 6, 2010, at 2:55 PM, Dumitru Daniliuc wrote: while doing a security review of chromium's implementation of HTML5 DBs, chris noted that some sqlite functions are potential security risks. thus, we would like to

Re: [webkit-dev] Question about PopupMenuClient

2010-01-07 Thread Darin Fisher
Chromium actually does something like this. See ChromeClientChromium. In our case, we have two modes: one where the embedder just has to wrap the given PopupContainer with a window frame, and in another mode, where the embedder is responsible for drawing the popup menu. We are forced to

Re: [webkit-dev] Running pixel tests on build.webkit.org

2010-01-07 Thread Darin Fisher
On Thu, Jan 7, 2010 at 5:17 PM, Ojan Vafai o...@chromium.org wrote: Do we really need a separate set of bots for pixel tests? Lets just turn the pixel tests on for the current bots. The only thing stopping us doing that is the currently failing tests, hence the suggestion for adding an

Re: [webkit-dev] Remove underscore check in check-webkit-style?

2010-01-13 Thread Darin Fisher
On Wed, Jan 13, 2010 at 4:17 PM, Evan Martin e...@chromium.org wrote: On Wed, Jan 13, 2010 at 3:43 PM, Adam Barth aba...@webkit.org wrote: Current check-webkit-style and the style bot complain if code uses identifiers with underscores in their names. It turns out our code does this fairly

Re: [webkit-dev] Legacy attributes in existing File interface

2010-01-16 Thread Darin Fisher
Since the existing APIs haven't been around for very long, we should probably just remove them. Any app using them is likely already on the bleeding edge, and was probably developed recently enough that the developers are still around and will be able to cope. -Darin On Fri, Jan 15, 2010 at

Re: [webkit-dev] Implementing WebTiming as a part of HTML5

2010-02-16 Thread Darin Fisher
On Mon, Feb 15, 2010 at 1:37 AM, Alois Reitbauer alois.reitba...@dynatrace.com wrote: As discussed with Richard and Zhiheng here the feedback on the proposal by dynaTrace software. We had a look at the new spec draft and have a number of questions and proposals: -In the

Re: [webkit-dev] WebKit API native coding style?

2010-02-19 Thread Darin Fisher
On Fri, Feb 19, 2010 at 6:30 AM, Stephan Assmus supersti...@gmx.de wrote: Hi, I would like to know whether it's ok to adopt the respective platform's coding style in the WebKit API that a port exposes. I am working on the Haiku port and saw that other ports do this, but I thought I'd better

Re: [webkit-dev] Increasing the number of cross-platform/port expected results

2010-02-23 Thread Darin Fisher
The first step is probably to get the infrastructure in place so that new tests can be written as ref tests when possible. -Darin On Tue, Feb 23, 2010 at 11:24 AM, Dimitri Glazkov dglaz...@chromium.orgwrote: I agree. We should organize cross-browser-test-fest and pick each other's brains.

Re: [webkit-dev] WTF::callOnMainThread() and re-entrancy

2010-03-08 Thread Darin Fisher
This is not surprising to me at all. The problem is even more complicated when you consider window.showModalDialog. I recently changed Chromium to suppress WebKit's shared timer during calls to alert, confirm, prompt, and the beforeunload prompt. That may be why you aren't seeing the problem

Re: [webkit-dev] Chromium layout test expectations coming today

2010-03-19 Thread Darin Fisher
As I understand it, the single repository is important for allowing developers to atomically commit a patch that includes both a code fix, a corresponding test, and expected results for that test. -Darin On Fri, Mar 19, 2010 at 11:08 AM, Alexey Proskuryakov a...@webkit.org wrote: Also, one

Re: [webkit-dev] Chromium layout test expectations coming today

2010-03-19 Thread Darin Fisher
Also, note that in Chromium, the expected results for layout tests are not in a separate deps/ dir :-) http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/ -Darin On Fri, Mar 19, 2010 at 10:26 AM, Evan Martin e...@chromium.org wrote: Before you commit it:

Re: [webkit-dev] Chromium layout test expectations coming today

2010-03-19 Thread Darin Fisher
platform/chromium/test_expectations.txt contains bug references to crbug.com. I presume that newly filed bugs will be in bugs.webkit.org instead. Unfortunately, it is going to be a bit hard to tell the difference given only the bug number. Is there a system we should use to annotate the

Re: [webkit-dev] multi-process always [Re: Announcing WebKit2]

2010-04-09 Thread Darin Fisher
This is how we are designing the Pepper API [1] by the way. It is designed to be layered in order to support an optional, out-of-process implementation. I've always been interested in a similar model for WebKit. -Darin [1] https://wiki.mozilla.org/Plugins:PlatformIndependentNPAPI On Fri, Apr

  1   2   3   >