Re: [webkit-dev] Back/forward cache for pages with unload handlers

2009-09-15 Thread Darin Fisher
I'm very confused by this change. If a page has an unload handler, then Firefox does not put the page in the bfcache. So the author of a page that has an unload handler would have no reason to include a pagehide handler. Does this change mean that unload handlers are never run? Or, are they run

Re: [webkit-dev] Passing data structures through postMessage()

2009-09-11 Thread Darin Fisher
On Thu, Sep 10, 2009 at 5:21 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 10, 2009, at 3:12 PM, Chris Campbell wrote: Hi All, I had it in mind to implement support for passing data structures through postMessage() using the structured clone algorithm laid out in the HTML5 spec:

Re: [webkit-dev] Passing data structures through postMessage()

2009-09-10 Thread Darin Fisher
Given shared workers (and indeed Chromium's out-of-process dedicated workers), it seems like we also have cross process boundaries to consider. -Darin On Thu, Sep 10, 2009 at 5:21 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 10, 2009, at 3:12 PM, Chris Campbell wrote: Hi All, I had

Re: [webkit-dev] Runtime setting for incomplete features

2009-09-09 Thread Darin Fisher
Perhaps... any suggestions?-Darin On Wed, Sep 9, 2009 at 8:45 AM, Adam Barth aba...@webkit.org wrote: Maybe it's worth distinguishing these settings with some sort of naming convention so that embedders know they'll be removed at some point? Adam On Tue, Sep 8, 2009 at 11:47 PM, Darin

Re: [webkit-dev] unwritten rules of webkit style

2009-09-03 Thread Darin Fisher
GCC will complain (maybe only a warning?) if C++ files don't end in a newline.-Darin On Thu, Sep 3, 2009 at 1:03 PM, Gavin Barraclough barraclo...@apple.comwrote: I believe the C spec requires that files end in a newline, though I couldn't comment on the c++ spec. Possibly redundant to list

[webkit-dev] willCacheResponse

2009-08-04 Thread Darin Fisher
There is a Mac-only willCacheResponse notification that gets recorded by several of the layout tests when layoutTestController.dumpResourceLoadCallbacks(true) is called. However, this notification which originates at the ResourceHandle level is currently #if PLATFORM(MAC). I noticed that the

Re: [webkit-dev] exposing the value of Accept-Language via window.navigation.acceptLanguage ?

2009-07-23 Thread Darin Fisher
On Wed, Jul 22, 2009 at 10:52 PM, Alexey Proskuryakov a...@webkit.org wrote: 22.07.2009, в 22:36, Darin Fisher написал(а): Firefox and Chrome send very similar A-L headers. Given FF's marketshare, I'm surprised you observed compat problems with doing the same. Was that a recent

Re: [webkit-dev] exposing the value of Accept-Language via window.navigation.acceptLanguage ?

2009-07-22 Thread Darin Fisher
2009/7/22 Alexey Proskuryakov a...@webkit.org 22.07.2009, в 16:41, Jungshik Shin (신정식, 申政湜) написал(а): Some web apps/widgets/browser extensions can also benefit from knowing the ordered list of languages in Accept-Language. I should note that Safari only sends one language. The reasons

Re: [webkit-dev] Build File Maintenance (was Re: Please welcome GYP to the our dysfunctional build family)

2009-07-14 Thread Darin Fisher
On Tue, Jul 14, 2009 at 10:27 AM, Peter Kasting pkast...@google.com wrote: On Tue, Jul 14, 2009 at 9:24 AM, Kevin Ollivier kev...@theolliviers.comwrote: Of course, the big question is if waf would have the same limitations as SCons in regards to doing this, but I think it's at least worth

[webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread Darin Fisher
I noticed that some new form validation code is landing (e.g., http://trac.webkit.org/changeset/45739). That change adds stubs for the ValidityState object. What I didn't see in that patch is any kind of ENABLE flag. I suspect there should be one since otherwise it becomes difficult for a web

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread Darin Fisher
On Mon, Jul 13, 2009 at 2:55 PM, Maciej Stachowiak m...@apple.com wrote: On Jul 13, 2009, at 11:57 AM, David Hyatt wrote: On Jul 13, 2009, at 1:52 PM, Jeremy Orlow wrote: On Mon, Jul 13, 2009 at 11:40 AM, David Hyatt hy...@apple.com wrote: On Jul 13, 2009, at 12:52 PM, Peter Kasting

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread Darin Fisher
On Mon, Jul 13, 2009 at 3:17 PM, David Hyatt hy...@apple.com wrote: On Jul 13, 2009, at 5:02 PM, Darin Fisher wrote: This small interval rule-of-thumb idea sounds pretty good, but I still wish it didn't put the burden on the guy doing the branch to figure out what is or isn't incomplete

Re: [webkit-dev] Chrome build bot

2009-07-11 Thread Darin Fisher
good revision* in its weakest meaning. If curious, more info at http://dev.chromium.org/developers/try-server-usage#TOC-LKGR M-A On Tue, Jul 7, 2009 at 2:11 PM, Darin Fisher da...@chromium.org wrote: We are working on it. It is taking more time than we'd like :-( For now, we only have

Re: [webkit-dev] Coding convention of constants

2009-07-09 Thread Darin Fisher
Ditto. The last time I wondered about this, I grepped through the code and found [1] to be the most prevalent. So, in code reviews I have been recommending people do [1]. -Darin On Thu, Jul 9, 2009 at 8:16 PM, Dimitri Glazkov dglaz...@chromium.orgwrote: If we're voting, then +1 to [1]. If

Re: [webkit-dev] Detecting a finished paint via JavaScript

2009-07-08 Thread Darin Fisher
While this is not a perfect solution, a common technique is to call (from onload) a DOM method like offsetHeight that forces layout to run. That way the bulk of the work required to paint is forced to happen before the benchmark considers the page load complete. -Darin On Wed, Jul 8, 2009 at

Re: [webkit-dev] Should we restrict Web Fonts to same-origin by default?

2009-06-23 Thread Darin Fisher
On Mon, Jun 22, 2009 at 1:26 PM, Ojan Vafai o...@chromium.org wrote: On Mon, Jun 22, 2009 at 12:45 PM, David Hyatt hy...@apple.com wrote: On Jun 22, 2009, at 2:38 PM, Maciej Stachowiak wrote: Mozilla restricts downloaded fonts to same-origin by default, with the ability for the hosting site

Re: [webkit-dev] Chromium Unforking: Please hold off on big changes for a day or so

2009-05-10 Thread Darin Fisher
On Thu, May 7, 2009 at 11:35 PM, Darin Fisher da...@google.com wrote: 3- A WebKit layer API (this is brewing herehttp://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebKit/chromium/ in case you want a sneak peak; it exists in our tree presently to ease the transition from

Re: [webkit-dev] Chromium Unforking: Please hold off on big changes for a day or so

2009-05-08 Thread Darin Fisher
Victory! http://build.chromium.org/buildbot/waterfall.fyi/waterfall?builder=Webkit%20(webkit.org) To those not working on Chromium, that is our buildbot that builds Chromium trunk against WebKit trunk. That implies zero forks, and to have it green--and passing the same layout tests as our normal

Re: [webkit-dev] Upstreaming IDL changes for the V8 bindings

2009-02-04 Thread Darin Fisher
Yup, that was my plan. Custom will be respected by both code generators. -Darin On Tue, Feb 3, 2009 at 4:06 PM, Dimitri Glazkov dglaz...@google.com wrote: To minimize the span of the changes, let's keep Custom as well, which in this context should mean -- Custom for all platforms. WDYT?

Re: [webkit-dev] #if PLATFORM(CF) || (PLATFORM(QT) PLATFORM(DARWIN))

2009-01-30 Thread Darin Fisher
Just speculating, but probably because there are cases where a QT API should be used instead of a CF API. This probably just happens to be a time when the CF API is preferred (maybe a QT alternative does not exist?). (We are in a similar boat with PLATFORM(CHROMIUM), which is why this topic is

Re: [webkit-dev] #if PLATFORM(CF) || (PLATFORM(QT) PLATFORM(DARWIN))

2009-01-30 Thread Darin Fisher
I didn't have a specific example with CF in mind. Since the Mac port of Chromium is sharing things like PLATFORM(CG), I can imagine there being issues like this coming up. -Darin On Fri, Jan 30, 2009 at 9:17 AM, Darin Adler da...@apple.com wrote: On Jan 30, 2009, at 9:10 AM, Darin Fisher

Re: [webkit-dev] XMLHttpRequest and Workers

2008-12-16 Thread Darin Fisher
2008/12/15 Alexey Proskuryakov a...@webkit.org Dec 15, 2008, в 9:47 AM, David Levin написал(а): This is how I plan to finish making XMLHttpRequest available for workers http://docs.google.com/Doc?id=dg7mj9sd_6dvthmdqj Let me know if you have any comments. As discussed earlier, this

Re: [webkit-dev] http cache support - rfc2616

2008-11-17 Thread Darin Fisher
for it's internal memory cache and will implement more. See https://bugs.webkit.org/show_bug.cgi?id=17998 for details. antti 2008/11/15 Darin Fisher [EMAIL PROTECTED]: The http caching logic for chromium lives here: http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_cache.cc

Re: [webkit-dev] http cache support - rfc2616

2008-11-15 Thread Darin Fisher
The http caching logic for chromium lives here: http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_cache.cc?view=markup WebKit does not have code for a network stack. Instead, each port provides a network stack, typically by using a system library. -Darin On Sat, Nov 15, 2008 at 9:01

Re: [webkit-dev] Save Page - Ideas

2008-11-05 Thread Darin Fisher
On Wed, Nov 5, 2008 at 11:06 AM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Nov 5, 2008, at 10:22 AM, Darin Fisher wrote: On Wed, Nov 5, 2008 at 7:04 AM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 30, 2008, at 9:47 AM, Darin Fisher wrote: We have code to support this feature

Re: [webkit-dev] Save Page - Ideas

2008-10-30 Thread Darin Fisher
On Thu, Oct 30, 2008 at 9:33 AM, David Kilzer [EMAIL PROTECTED] wrote: On Thu, 10/30/08, zaheer ahmad [EMAIL PROTECTED] wrote: iam working on implementing save page functionality. Looks like its not already supported in the core. Apple's Mac port saves .webarchive files. The format is

[webkit-dev] PLATFORM(CHROMIUM), etc.

2008-10-28 Thread Darin Fisher
As some of you may have noticed, there is now a PLATFORM(CHROMIUM) define that is being used in WebKit. I thought it might be helpful to describe what it is and explain why it exists. PLATFORM(CHROMIUM) corresponds to the WebKit porting layer implementation used by the Chromium (aka Google

Re: [webkit-dev] The WebCore/platform/ directory situation

2008-10-04 Thread Darin Fisher
On Sat, Oct 4, 2008 at 12:27 AM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 3, 2008, at 9:17 PM, David Hyatt wrote: After working for a while on the WebCore/platform/ directory, it's become clear that people don't really know what this directory is supposed to contain (and by

Re: [webkit-dev] setTimeout as browser speed throttle

2008-10-03 Thread Darin Fisher
On Thu, Oct 2, 2008 at 10:36 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 10:09 PM, Darin Fisher wrote: On Thu, Oct 2, 2008 at 9:58 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 9:39 PM, Darin Fisher wrote: In short, our architecture makes me

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 2:23 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 1:07 PM, Brett Wilson wrote: About a year ago, Google released the Google URL Parsing and Canonicalization Library (Google-URL) as a separate open-source project:

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 3:01 PM, Geoffrey Garen [EMAIL PROTECTED] wrote: One thing I'd like to highlight: It is a requirement for Chromium to use consistent URL parsing throughout the entire application. Can you explain this requirement more? I think that's an important data point, since

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 3:27 PM, David Hyatt [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 4:23 PM, Maciej Stachowiak wrote: I have mentioned optionally replacing KURL with an ifdef to a number of WebKit members. The reception has been tentatively yes. As one of the people who were asked

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 3:43 PM, David Hyatt [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 5:35 PM, Darin Fisher wrote: On Thu, Oct 2, 2008 at 3:27 PM, David Hyatt [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 4:23 PM, Maciej Stachowiak wrote: I have mentioned optionally replacing KURL

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 3:53 PM, Geoffrey Garen [EMAIL PROTECTED] wrote: KURL depends on WebCore types, and was found to have bugs, so Brett did a study of other URL parsers and wrote the Google URL library as a template library (and wrote GURL as an example class using it with std::string).

Re: [webkit-dev] High Resolution Timer API proposal(s)

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 5:32 PM, Ojan Vafai [EMAIL PROTECTED] wrote: On Thu, Oct 2, 2008 at 5:16 PM, Aaron Boodman [EMAIL PROTECTED] wrote: On Thu, Oct 2, 2008 at 5:05 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: I don't really like the overengineered version. I like the fairly minimalist

Re: [webkit-dev] High Resolution Timer API proposal(s)

2008-10-02 Thread Darin Fisher
On a separate thread, it was discussed that it is useful to support microsecond resolution for future proofness. -Darin On Thu, Oct 2, 2008 at 5:53 PM, Timothy Hatcher [EMAIL PROTECTED]wrote: Why double delayInSeconds and not milliseconds to stay consistent? On Oct 2, 2008, at 5:32 PM, Ojan

Re: [webkit-dev] Long-term Google-URL integration plans

2008-10-02 Thread Darin Fisher
On Thu, Oct 2, 2008 at 6:40 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 6:26 PM, Peter Kasting wrote: The prospect of WTF types in general tends to make me leery, since using one can bring in dependencies on others, and we wouldn't want to bring more dependencies than

Re: [webkit-dev] setTimeout as browser speed throttle

2008-10-02 Thread Darin Fisher
On Wed, Oct 1, 2008 at 5:26 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 1, 2008, at 5:03 PM, Darin Fisher wrote: On Wed, Oct 1, 2008 at 2:34 AM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 1, 2008, at 1:24 AM, David Hyatt wrote: On Oct 1, 2008, at 2:52 AM, Darin Fisher

Re: [webkit-dev] setTimeout as browser speed throttle

2008-10-01 Thread Darin Fisher
On Tue, Sep 30, 2008 at 11:55 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Sep 30, 2008, at 10:36 PM, Darin Fisher wrote: On Tue, Sep 30, 2008 at 7:14 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: ... 2) Consider making WebKit's default minimum timer limit lower - something like

Re: [webkit-dev] setTimeout as browser speed throttle

2008-10-01 Thread Darin Fisher
On Wed, Oct 1, 2008 at 2:34 AM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 1, 2008, at 1:24 AM, David Hyatt wrote: On Oct 1, 2008, at 2:52 AM, Darin Fisher wrote: I can appreciate that you aren't interested in revisiting this problem after having resolved it finally by adding

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Darin Fisher
[resent from an address mailman knows about] On Wed, Sep 24, 2008 at 3:36 PM, Darin Fisher [EMAIL PROTECTED] wrote: On Wed, Sep 24, 2008 at 2:16 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Sep 24, 2008, at 12:14 PM, Amanda Walker wrote: Hello all, A conversation started on https

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Darin Fisher
[resent, doh... that's it, i'm registering my other email address] On Wed, Sep 24, 2008 at 4:32 PM, Darin Fisher [EMAIL PROTECTED] wrote: On Wed, Sep 24, 2008 at 4:22 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Sep 24, 2008, at 3:30 PM, Amanda Walker wrote: The renderer process

[webkit-dev] Thank You

2008-09-05 Thread Darin Fisher
Hey all, I just wanted to say a big thank you for all that you have done in creating such an awesome rendering engine. Our new browser was made possible because of WebKit, and I hope that when people talk about Chrome that they understand that WebKit is at the heart of it. So, I just put up a

<    1   2   3