Re: [webkit-dev] Can't upload patch

2013-01-17 Thread Konrad Piascik
Instead of piping the output of git show, I'd use git format-patch -1 This will generate a patch file for the topmost commit of your current branch. Cheers, Konrad From: webkit-dev-boun...@lists.webkit.org [webkit-dev-boun...@lists.webkit.org] on behalf

Re: [webkit-dev] Can't upload patch

2013-01-17 Thread Konrad Piascik
You could have kept your commits separate and generated a patch for each. The parameter for format-patch is the number of commits for which to generate patches. -Konrad Sent from my BlackBerry smartphone. From: Raymond Toy Sent: Thursday, January 17, 2013 6:00 PM To: Konrad Piascik Cc: jpe

Re: [webkit-dev] bugs.webkit.org and trac.webkit org down?

2012-08-07 Thread Konrad Piascik
It's down in Waterloo, ON as well, so I guess it's just down :( Konrad Sent from my BlackBerry on the Rogers Wireless Network From: Shawn Singh [mailto:shawnsi...@chromium.org] Sent: Tuesday, August 07, 2012 12:27 PM To: Osztrogonac Csaba o...@inf.u-szeged.hu Cc: WebKit Development

Re: [webkit-dev] C++ unit tests for WebKit?

2012-07-11 Thread Konrad Piascik
Don't we have gunit tests in Tools/TestWebKitAPI already? From: webkit-dev-boun...@lists.webkit.org [webkit-dev-boun...@lists.webkit.org] on behalf of Hans Muller [hmul...@adobe.com] Sent: Wednesday, July 11, 2012 5:23 PM To: webkit-dev Subject:

Re: [webkit-dev] Please include function-level comments in change log entries

2012-07-06 Thread Konrad Piascik
I find that the function level comments, while potentially more time consuming to create are more beneficial than the comments at the top. It makes it not only easier to review but for also when going through the history and trying to see what changes were made. About iterations of the

[webkit-dev] Web Inspector files

2012-06-08 Thread Konrad Piascik
Hi, I'm trying to combine all the web inspector resources CSS, JS HTML into as few files as possible. I know that there are scripts in Source/WebCore/inspector but I'm not sure which ones should be used and some don't contain usage information. Also there's both combine-front-end.py and

Re: [webkit-dev] Web Inspector files

2012-06-08 Thread Konrad Piascik
Network From: Pavel Feldman [mailto:pfeld...@chromium.org] Sent: Friday, June 08, 2012 07:59 AM To: Konrad Piascik Cc: webkit-dev@lists.webkit.org webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Web Inspector files [From chromium.orghttp://chromium.org] We throw away closure compiler output

Re: [webkit-dev] Removing target-densitydpi (was Re: Device and page scaling)

2012-06-04 Thread Konrad Piascik
sure that there are others who may find this useful. Konrad Sent from my BlackBerry on the Rogers Wireless Network - Original Message - From: Adam Barth [mailto:aba...@webkit.org] Sent: Friday, June 01, 2012 01:54 PM To: Konrad Piascik Cc: Maciej Stachowiak m...@apple.com; kenn

Re: [webkit-dev] Device and page scaling

2012-06-01 Thread Konrad Piascik
Reposting comment from Bug 88047 After discussing this internally we believe that while the current implementation of target-densitydpi is not ideal it's ability to allow you scale your viewport to a given target density as well as to allow you to not scale (deviceDPI) are both desired

Re: [webkit-dev] Device and page scaling

2012-05-29 Thread Konrad Piascik
How will these changes affect window.devicePixelRatio and the associated media queries? Will they still key off of Page::deviceScaleFactor? Konrad Sent from my BlackBerry on the Rogers Wireless Network - Original Message - From: Adam Barth [mailto:aba...@webkit.org] Sent: Tuesday, May

[webkit-dev] win-ews linker error

2012-04-23 Thread Konrad Piascik
I'm writing a patch for inspector that is giving me a linker error that I'm not able to track down since I don't have a windows build setup. Bug: https://bugs.webkit.org/show_bug.cgi?id=83282 This is the build output from win-ews. http://queues.webkit.org/results/12476169 Inline for

Re: [webkit-dev] Debugging inspector injected scripts

2012-03-29 Thread Konrad Piascik
Hi Vivek, You can use the inspector to inspect itself. I've done this on chrome many times using the keyboard shortcut ctrl+shift+c (win linux) or command+shift+c (mac). In order for the keyboard shortcut to work you need to have the inspector undocked and the focus of the inspector be on the

Re: [webkit-dev] Debugging inspector injected scripts

2012-03-29 Thread Konrad Piascik
Galatage [mailto:vivekgalat...@gmail.com] Sent: Thursday, March 29, 2012 08:32 AM To: Konrad Piascik Cc: webkit-dev@lists.webkit.org webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Debugging inspector injected scripts Hi Konrad, Thank you for your reply. Yes as you pointed out, I have tried

Re: [webkit-dev] ChangeLogs

2012-03-21 Thread Konrad Piascik
There are some changes which have bug descriptions which are complete enough to not need additional comments and any changes to existing scripts should keep this in mind. One way to do this is to check for the number of lines/files the diff has. Konrad Sent from my BlackBerry on the Rogers

Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)

2012-03-16 Thread Konrad Piascik
Bugs.webkit.org has an integrated bug tracking and code review tool. I find this integration is good as it stands. I use git for development and don't think there's anything wrong with the current tools. Konrad Sent from my BlackBerry on the Rogers Wireless Network From: Jarred Nicholls

Re: [webkit-dev] Version control survey

2012-03-10 Thread Konrad Piascik
Where can we see the results to date? Also there should be a closing date for the survey and it should also be announced to this DL. Konrad Sent from my BlackBerry on the Rogers Wireless Network - Original Message - From: Maciej Stachowiak [mailto:m...@apple.com] Sent: Saturday,

Re: [webkit-dev] Version control survey

2012-03-10 Thread Konrad Piascik
: Maciej Stachowiak [mailto:m...@apple.com] Sent: Saturday, March 10, 2012 02:52 PM To: Ryosuke Niwa rn...@webkit.org Cc: Konrad Piascik; webkit-dev@lists.webkit.org webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Version control survey On Mar 10, 2012, at 10:56 AM, Ryosuke Niwa wrote: On Sat

Re: [webkit-dev] Moving to Git?

2012-03-09 Thread Konrad Piascik
Hi Ryosuke, There are solutions in git for all of your raised issues. If you want to have git diff work against master then you just need to setup an alias to do that for you. http://gitready.com/intermediate/2009/02/06/helpful-command-aliases.html This way you can create aliases for all the

Re: [webkit-dev] Moving to Git?

2012-03-08 Thread Konrad Piascik
I personally use either git or git-svn and would welcome the move. -Konrad From: webkit-dev-boun...@lists.webkit.org [webkit-dev-boun...@lists.webkit.org] on behalf of Ashod Nakashian [ashodnakash...@yahoo.com] Sent: Thursday, March 08, 2012 8:56 AM To:

Re: [webkit-dev] Moving to Git?

2012-03-08 Thread Konrad Piascik
It is possible to keep linear history with git. This just requires you to fast forward and rebase before pushing. Konrad Sent from my BlackBerry on the Rogers Wireless Network - Original Message - From: Carlos Garcia Campos [mailto:carlo...@webkit.org] Sent: Thursday, March 08, 2012

Re: [webkit-dev] (no subject)

2012-02-27 Thread Konrad Piascik
I typically use webkit-patch to upload a single patch but really like your proposed change in 2a) to diff against what is staged for commit. This looks like it will be useful and cool. Konrad Sent from my BlackBerry on the Rogers Wireless Network - Original Message - From: Dirk Pranke

Re: [webkit-dev] git.webkit.org is offline

2012-02-15 Thread Konrad Piascik
I'm still getting: $ git fetch origin git.webkit.org[0: 17.254.20.231]: errno=Connection refused fatal: unable to connect a socket (Connection refused) Same with commit-queue: Failed to run ['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-...

[webkit-dev] Commit-queue

2012-01-23 Thread Konrad Piascik
Hi All, I'm seeing the commit-queue bot http://webkit-commit-queue.appspot.com/queue-status/commit-queue/bots/ec2-cq-02 consistently rebooting about every hour. I know I'm not the only one with a patch that has commit-queue+ waiting for this to be resolved. Can someone look into this