Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

Yeah, we can re-design status-bubble tooltip (https://webkit.org/b/201940) and include such information there. Another idea to help with making style failures more noticeable is to have the Style failure displayed in-line on the review page along-with the reviewer's comments

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

I actually “missed” output from the stylebot insofar as I was expecting the errors to be posted, and then I was going to reply to that automated message. I think it’s too easy to ignore style errors if you have to click to load another website, though, so I filed this bug with some thoughts:

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

> On Jun 16, 2019, at 2:14 PM, Darin Adler wrote: > >> On Jun 15, 2019, at 9:13 PM, Aakash Jain > > wrote: >> >> 1) Do not upload archive (for layout-test-results) on bugzilla, instead >> upload it to another server, unzip it and post a link to the results.html.

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

To elaborate a little on Aakash’s comments here: We’ve found that tracking results for the number of tests we have, on the number of configurations we test with the number of weekly commits to the WebKit project is actually not a trivial problem to solve. The naive SQL approach to this problem

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

> On Jun 16, 2019, at 2:14 PM, Darin Adler wrote: > >> On Jun 15, 2019, at 9:13 PM, Aakash Jain > > wrote: >> >> 1) Do not upload archive (for layout-test-results) on bugzilla, instead >> upload it to another server, unzip it and post a link to the results.html.

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

> On Jun 17, 2019, at 1:52 PM, Keith Rollin wrote: > >> On Jun 16, 2019, at 11:14, Darin Adler wrote: >> >> If we want to augment it, we should think of what we are aiming at. I do >> find it useful to see which tests are failing, and when I click on the red >> bubble I don’t see that

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

> On Jun 16, 2019, at 11:14, Darin Adler wrote: > > If we want to augment it, we should think of what we are aiming at. I do find > it useful to see which tests are failing, and when I click on the red bubble > I don’t see that information. I have to click once to see the “log of >

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

> On Jun 15, 2019, at 9:13 PM, Aakash Jain wrote: > > 1) Do not upload archive (for layout-test-results) on bugzilla, instead > upload it to another server, unzip it and post a link to the results.html. > Pros: > a) Engineers won't have to download the attachment, unzip it, look for >

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

I agree with Tim's suggestion of limiting the comments to only one immediate comment saying "at least one EWS failed" and referring to a web page that summarizes everything. That could cover what is done by 1) and 2) in a more elegant way. I'm not sure 3) would make a big difference for me, but

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

1-4 all seem uncontroversial, especially with Tim's suggested improvement to immediately leave a "some queues failed" comment. On Sat, Jun 15, 2019 at 11:13 PM, Aakash Jain wrote: 5) Do not comment on bugzilla bug at all, instead send email to the author of the patch. Pros: less noisy, also

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

> On Jun 15, 2019, at 21:13, Aakash Jain wrote: > >  > Hi Everyone, > > I am gathering feedback about EWS - specially about the comments which EWS > makes on the Bugzilla bugs. Currently, the comments are not very > user-friendly/polished/readable and are sometimes very noisy (e.g.: 72 >

[webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

Hi Everyone, I am gathering feedback about EWS - specially about the comments which EWS makes on the Bugzilla bugs. Currently, the comments are not very user-friendly/polished/readable and are sometimes very noisy (e.g.: 72 comments and 36 attachments by EWS in