Re: [webkit-qt] QtScript dependency optional?

2011-01-17 Thread Konstantin Tokarev
14.01.2011, 21:38, Benjamin Poulain benjamin.poul...@nokia.com: On 01/14/2011 07:30 PM, ext Konstantin Tokarev wrote:  Long term QtWebKit will depends on QtScript for the bridge. To avoid  inconsistencies and regressions, I think it would be more reasonable to  guard the functions of the

Re: [webkit-qt] QtScript dependency optional?

2011-01-17 Thread Benjamin Poulain
On 01/17/2011 04:14 PM, ext Konstantin Tokarev wrote: 14.01.2011, 21:38, Benjamin Poulainbenjamin.poul...@nokia.com: On 01/14/2011 07:30 PM, ext Konstantin Tokarev wrote: Long term QtWebKit will depends on QtScript for the bridge. To avoid inconsistencies and regressions, I think it would

Re: [webkit-qt] QtScript dependency optional?

2011-01-17 Thread achellies
快捷回复给:Konstantin Tokarev, Simon Hausmann, webkit-qt, Benjamin Poulain At 2011-01-17 23:14:35,Konstantin Tokarev annu...@yandex.ru wrote: 14.01.2011, 21:38, Benjamin Poulain benjamin.poul...@nokia.com: On 01/14/2011 07:30 PM, ext Konstantin Tokarev wrote:  Long term QtWebKit will depends on

[webkit-qt] QtScript dependency optional?

2011-01-14 Thread Konstantin Tokarev
I've found that QtWebKit does not actually depend on QtScript module (at least if configured without V8 support). The only thing actually used is enum QScriptEngine::ValueOwnership. If its definition is included into Source/WebCore/bridge/qt/qt_instance.h and WebKit/qt/Api/qwebframe.h,

Re: [webkit-qt] QtScript dependency optional?

2011-01-14 Thread Benjamin Poulain
On 01/14/2011 07:30 PM, ext Konstantin Tokarev wrote: Long term QtWebKit will depends on QtScript for the bridge. To avoid inconsistencies and regressions, I think it would be more reasonable to guard the functions of the bridge with #ifndef QT_NO_SCRIPT. Do you mean it's OK to disable whole