Re: string_t breaks compilation under Solaris

2005-02-21 Thread Hrvoje Niksic
Mauro Tortonesi [EMAIL PROTECTED] writes: On Sunday 20 February 2005 06:31 pm, Hrvoje Niksic wrote: string_t.c uses the function iswblank, which doesn't seem to exist on Solaris 8 I tried to compile it on. (Compilation is likely broken on other non-Linux platforms as well for the same

Re: Large file support

2005-02-21 Thread Maciej W. Rozycki
On Sun, 20 Feb 2005, Hrvoje Niksic wrote: 1. I'd say that code like if ( sizeof(number) == 8 ) should have been a compile-time #ifdef rather than a run-time decision. Where do you see such code? grep 'if.*sizeof' *.c doesn't seem to show such examples. As I recall, it was in

Re: Large file support

2005-02-21 Thread Hrvoje Niksic
Maciej W. Rozycki [EMAIL PROTECTED] writes: Actually if (sizeof(number) == 8) is much more readable than any preprocessor clutter and yields exactly the same. Agreed, in some cases. In others it yields to pretty annoying compiler warnings.

Re: string_t breaks compilation under Solaris

2005-02-21 Thread Hrvoje Niksic
Simone Piunno [EMAIL PROTECTED] writes: I think by pushing this line of reasoning to the extreme you shouldn't have added i18n through gettext, should you? You are right, and I was indeed leery of adding support for gettext until I was convinced that it would work well both on systems without

Suggestion regarding size

2005-02-21 Thread Baptiste Bullot
Hello all, Would it be possible to specify minimum size for files to retrieve? Please add me in the CC list of your replies as I'm not a subscriber. Thanks, Baptiste __ Do you Yahoo!? Yahoo! Mail - Easier than ever with enhanced search. Learn

Suggestion regarding size

2005-02-21 Thread Baptiste Bullot
Hello all, Would it be possible to specify minimum size for files to retrieve? Please add me in the CC list of your replies as I'm not a subscriber. Thanks, Baptiste __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection

Suggestion regarding size

2005-02-21 Thread Baptiste Bullot
Hello all, Would it be possible to specify minimum size for files to retrieve? Please add me in the CC list of your replies as I'm not a subscriber. Thanks, Baptiste __ Do you Yahoo!? Yahoo! Mail - Helps protect you from nasty viruses.

Re: string_t breaks compilation under Solaris

2005-02-21 Thread Dražen Kačar
Hrvoje Niksic wrote: 2) Server messages printed by Wget in normal operation, such as the 200 Ok message. That one is printed just for the fun factor anyway, we could as well print just the response code. However, I don't see a problem with simply filtering out the non-ASCII's from

Re: Large file support

2005-02-21 Thread Steven M. Schweda
From: Hrvoje Niksic [...] It is no small task to study Info-ZIP's source code. I did plan to look at it later, but at the time it was quicker to just ask. It's fairly easy to SEARCH [...]*.c, *.h LARGE_FILE_SUPPORT (or your local find/grep equivalent). Locating zip_fzofft would also be

Re: Large file support

2005-02-21 Thread Maciej W. Rozycki
On Mon, 21 Feb 2005, Hrvoje Niksic wrote: Actually if (sizeof(number) == 8) is much more readable than any preprocessor clutter and yields exactly the same. Agreed, in some cases. In others it yields to pretty annoying compiler warnings. What kind of warnings? It's valid C. Maciej

Re: Large file support

2005-02-21 Thread Hrvoje Niksic
Maciej W. Rozycki [EMAIL PROTECTED] writes: On Mon, 21 Feb 2005, Hrvoje Niksic wrote: Actually if (sizeof(number) == 8) is much more readable than any preprocessor clutter and yields exactly the same. Agreed, in some cases. In others it yields to pretty annoying compiler warnings.

Re: Large file support

2005-02-21 Thread Hrvoje Niksic
Maciej W. Rozycki [EMAIL PROTECTED] writes: Besides, despite sizeof(foo) being a constant, you can't move a comparison against it to cpp. You can, Autoconf allows you to check for size of foo, which gives you a SIZEOF_FOO preprocessor constant. Then you can write things like: #if SIZEOF_FOO

Re: Large file support

2005-02-21 Thread Maciej W. Rozycki
On Mon, 21 Feb 2005, Hrvoje Niksic wrote: Besides, despite sizeof(foo) being a constant, you can't move a comparison against it to cpp. You can, Autoconf allows you to check for size of foo, which gives you a SIZEOF_FOO preprocessor constant. Then you can write things like: #if

Re: string_t breaks compilation under Solaris

2005-02-21 Thread Mauro Tortonesi
On Monday 21 February 2005 09:49 am, Draen Kaar wrote: Hrvoje Niksic wrote: 2) Server messages printed by Wget in normal operation, such as the 200 Ok message. That one is printed just for the fun factor anyway, we could as well print just the response code. However, I don't

Re: string_t breaks compilation under Solaris

2005-02-21 Thread Leonid
Mauro, I tend to agree with Hrvoje. If you decide to open the Pandora's box and implement iconv support, please, please, provide an option, preferably default one, to configure or use wget without iconv. FYI, there are languages which actively use more than one coding. For example, I know 14

Re: wget.1 translation

2005-02-21 Thread Nick Shaforostoff
On Sunday 20 February 2005 22:47, Nol Kthe wrote: Am Mittwoch, den 09.02.2005, 10:40 +0200 schrieb Nick Shaforostoff: hi, i've translated wget.1 to Russian what should i do to get it added to the official wget distro? Just send your ru.po or a patch/diff to the po/ru.po in the wget cvs to

Re: string_t breaks compilation under Solaris

2005-02-21 Thread Mauro Tortonesi
On Monday 21 February 2005 12:35 pm, Leonid wrote: Mauro, I tend to agree with Hrvoje. If you decide to open the Pandora's box and implement iconv support, please, please, provide an option, preferably default one, to configure or use wget without iconv. of course. FYI, there are

Re: string_t breaks compilation under Solaris

2005-02-21 Thread Hrvoje Niksic
Mauro Tortonesi [EMAIL PROTECTED] writes: It is rather common that either the charset at the remote host or the charset at the local host are set incorrectly. this is not a problem. actually (apart from the case of a document returned as an HTTP response) we cannot be sure that the charset

Re: string_t breaks compilation under Solaris

2005-02-21 Thread Hrvoje Niksic
Mauro Tortonesi [EMAIL PROTECTED] writes: the problem is not with HTTP response messages, but with HTTP resources (which can be for example binary data or multibyte char text - in this case you really want to escape unprintable data while printing all the valid multibyte chars you can using

Re: string_t breaks compilation under Solaris

2005-02-21 Thread Mauro Tortonesi
On Monday 21 February 2005 02:39 pm, you wrote: Mauro Tortonesi [EMAIL PROTECTED] writes: the problem is not with HTTP response messages, but with HTTP resources (which can be for example binary data or multibyte char text - in this case you really want to escape unprintable data while

Re: string_t breaks compilation under Solaris

2005-02-21 Thread Hrvoje Niksic
Mauro Tortonesi [EMAIL PROTECTED] writes: but i suspect we wiil probably have to add foreign charset support to wget one of these days. for example, suppose we are doing a recursive HTTP retrieval and the HTML pages we retrieve are not encoded in ASCII but in UTF16 (an encoding in which is

Re: string_t breaks compilation under Solaris

2005-02-21 Thread Mauro Tortonesi
On Monday 21 February 2005 02:37 pm, you wrote: Mauro Tortonesi [EMAIL PROTECTED] writes: It is rather common that either the charset at the remote host or the charset at the local host are set incorrectly. this is not a problem. actually (apart from the case of a document returned as

Re: string_t breaks compilation under Solaris

2005-02-21 Thread Mauro Tortonesi
On Monday 21 February 2005 03:57 pm, Hrvoje Niksic wrote: Mauro Tortonesi [EMAIL PROTECTED] writes: but i suspect we wiil probably have to add foreign charset support to wget one of these days. for example, suppose we are doing a recursive HTTP retrieval and the HTML pages we retrieve are

Re: string_t breaks compilation under Solaris

2005-02-21 Thread Hrvoje Niksic
Mauro Tortonesi [EMAIL PROTECTED] writes: The only reason why that bug occurred was the broken hotfix that escaped *all* non-ASCII content printed by Wget, instead of only that actually read from the network. We don't need iconv to fix that, we need correct quoting. yes, you may be right.

Re: wget.1 translation

2005-02-21 Thread Mauro Tortonesi
On Monday 21 February 2005 01:27 pm, you wrote: On Sunday 20 February 2005 22:47, Nol Kthe wrote: Am Mittwoch, den 09.02.2005, 10:40 +0200 schrieb Nick Shaforostoff: hi, i've translated wget.1 to Russian what should i do to get it added to the official wget distro? Just send your

Re: string_t breaks compilation under Solaris

2005-02-21 Thread Mauro Tortonesi
On Monday 21 February 2005 04:23 pm, Hrvoje Niksic wrote: Mauro Tortonesi [EMAIL PROTECTED] writes: The only reason why that bug occurred was the broken hotfix that escaped *all* non-ASCII content printed by Wget, instead of only that actually read from the network. We don't need iconv to

Re: string_t breaks compilation under Solaris

2005-02-21 Thread Hrvoje Niksic
Mauro Tortonesi [EMAIL PROTECTED] writes: If that weren't safe, Wget would (along with many other programs) have been broken a long time ago. In fact, if that were the case, I would never have even accepted adding support for gettext in the first place. well, theoretically it could happen.

Re: wget.1 translation

2005-02-21 Thread Hrvoje Niksic
Mauro Tortonesi [EMAIL PROTECTED] writes: i don't know what's the correct procedure to add a new translation to a GNU project (hrvoje, do you have any ideas?), I used to add translations for Croatian, both for Wget and for other programs, so I should know, but I must admit that the details now

Re: string_t breaks compilation under Solaris

2005-02-21 Thread Simone Piunno
On Monday 21 February 2005 16:18, Hrvoje Niksic wrote: Also, gettext doesn't change behavior of low-level routines in a fundamental way -- it's just a way of getting different strings. On the other hand, wide chars do introduce pretty invasive changes to the way things work. The most basic

Re: string_t breaks compilation under Solaris

2005-02-21 Thread Hrvoje Niksic
Simone Piunno [EMAIL PROTECTED] writes: On Monday 21 February 2005 16:18, Hrvoje Niksic wrote: Also, gettext doesn't change behavior of low-level routines in a fundamental way -- it's just a way of getting different strings. On the other hand, wide chars do introduce pretty invasive changes