Alain Guibert [EMAIL PROTECTED] writes:
On Wednesday, April 2, 2008 at 23:09:52 +0200, Hrvoje Niksic wrote:
Micah Cowan [EMAIL PROTECTED] writes:
It's hard for me to imagine an fnmatch that ignores FNM_PATHNAME
The libc 5.4.33 fnmatch() supports FNM_PATHNAME, and there is code
apparently
Alain Guibert [EMAIL PROTECTED] writes:
Maybe you could put a breakpoint in fnmatch and see what goes wrong?
The for loop intended to eat several characters from the string also
advances the pattern pointer. This one reaches the end of the pattern,
and points to a NUL. It is not a '*'
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hrvoje Niksic wrote:
Alain Guibert [EMAIL PROTECTED] writes:
Maybe you could put a breakpoint in fnmatch and see what goes wrong?
The for loop intended to eat several characters from the string also
advances the pattern pointer. This one reaches
On Thursday, April 3, 2008 at 22:37:41 +0200, Hrvoje Niksic wrote:
Or it could be that you're picking up a different fnmatch.h that sets
up a different value for FNM_PATHNAME. Do you have more than one
fnmatch.h installed on your system?
I have only /usr/include/fnmatch.h installed,
On Thursday, April 3, 2008 at 9:14:52 -0700, Micah Cowan wrote:
Are you certain you rebuilt cmpt.o? This seems pretty unlikely, to me.
Certain: make test after touching src/sysdep.h rebuilds both cmpt.o, the
normal in src/ and the one in tests/. And both those cmpt.o become
784 bytes bigger
Alain Guibert [EMAIL PROTECTED] writes:
This old system does HAVE_WORKING_FNMATCH_H (and thus
SYSTEM_FNMATCH). When #undefining SYSTEM_FNMATCH, the test still
fails at the very same line. And then it also fails on modern
systems. I guess this points at the embedded src/cmpt.c:fnmatch()
On Wednesday, April 2, 2008 at 23:09:52 +0200, Hrvoje Niksic wrote:
Micah Cowan [EMAIL PROTECTED] writes:
It's hard for me to imagine an fnmatch that ignores FNM_PATHNAME
The libc 5.4.33 fnmatch() supports FNM_PATHNAME, and there is code
apparently intending to return FNM_NOMATCH on a slash.
On Thursday, April 3, 2008 at 11:08:27 +0200, Hrvoje Niksic wrote:
Well, it would point to a problem with both the fnmatch replacement
and the older system fnmatch. Our fnmatch (coming from an old
release of Bash
The fnmatch()es in libc 5.4.33 and in Wget are twins. They differ on
some
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Alain Guibert wrote:
The for loop intended to eat several characters from the string also
advances the pattern pointer. This one reaches the end of the pattern,
and points to a NUL. It is not a '*' anymore, so the loop exits
prematurely. Just
Hello Micah,
On Monday, March 31, 2008 at 11:39:43 -0700, Micah Cowan wrote:
could you try to isolate which part of test_dir_matches_p is failing?
The only failing src/utils.c test_array[] line is:
| { { *COMPLETE, NULL, NULL }, foo/!COMPLETE, false },
I don't understand enough of
Alain Guibert [EMAIL PROTECTED] writes:
Hello Micah,
On Monday, March 31, 2008 at 11:39:43 -0700, Micah Cowan wrote:
could you try to isolate which part of test_dir_matches_p is failing?
The only failing src/utils.c test_array[] line is:
| { { *COMPLETE, NULL, NULL }, foo/!COMPLETE,
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hrvoje Niksic wrote:
Alain Guibert [EMAIL PROTECTED] writes:
Hello Micah,
On Monday, March 31, 2008 at 11:39:43 -0700, Micah Cowan wrote:
could you try to isolate which part of test_dir_matches_p is failing?
The only failing src/utils.c
Micah Cowan [EMAIL PROTECTED] writes:
It sounds like a libc problem rather than a gcc problem. Try
#undefing SYSTEM_FNMATCH in sysdep.h and see if it works then.
It's hard for me to imagine an fnmatch that ignores FNM_PATHNAME: I
mean, don't most shells rely on this to handle file globbing
Micah Cowan [EMAIL PROTECTED] writes:
I'm wondering whether it might make sense to go back to completely
ignoring the system-provided fnmatch?
One argument against that approach is that it increases code size on
systems that do correctly implement fnmatch, i.e. on most modern
Unixes that we
Hello,
With an old gcc 2.7.2.1 compiler, wget 1.11.1 make test fails:
| gcc -I. -I. -I./../src -DHAVE_CONFIG_H
-DSYSTEM_WGETRC=\/usr/local/etc/wgetrc\
-DLOCALEDIR=\/usr/local/share/locale\ -O2 -Wall -DTESTING -c ../src/test.c
| ../src/test.c: In function `all_tests':
| ../src/test.c:51: parse
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Alain Guibert wrote:
Hello,
With an old gcc 2.7.2.1 compiler, wget 1.11.1 make test fails:
| gcc -I. -I. -I./../src -DHAVE_CONFIG_H
-DSYSTEM_WGETRC=\/usr/local/etc/wgetrc\
-DLOCALEDIR=\/usr/local/share/locale\ -O2 -Wall -DTESTING -c ../src
16 matches
Mail list logo
