[Wikitech-l] Performance issue with regard to JSON-based localisation format

2014-04-14 Thread Adrian Lang
Hi *, I recently investigated a performance issue with one of Wikibase's test cases. The test in question performed a formatting task for all known languages. While the first assertions ran as fast as expected, they rapidly got slower until finally taking seconds per assertion. I figured this was

[Wikitech-l] mGerrit - Gerrit for Android

2014-04-14 Thread Sam Reed
As we all know, Gerrit doesn't have the best interface, but even more so, it's not very mobile friendly. There is however mGerrit [1] for Android which does a nice job. Also, we're not in the list of default supported Gerrit instannces (yes, I know WikiMedia is in CamelCase, this is already

[Wikitech-l] MediaWiki Support for PhpStorm

2014-04-14 Thread Sam Reed
There's been discussions before about being able to share code style settings between MediaWiki users for PhpStorm. To this end, I've started a PhpStorm plugin [1] that adds this functionality, allowing preferences to be set from a MediaWiki predefined style. Thanks to Siebrand and Physikerwelt

Re: [Wikitech-l] Performance issue with regard to JSON-based localisation format

2014-04-14 Thread Niklas Laxström
I think technically easiest solution is to modify the i18n.php files: -$GLOBALS['wgHooks']['LocalisationCacheRecache'][] = function ( $cache, $code, $cachedData ) { +$GLOBALS['wgHooks']['LocalisationCacheRecache'][__FILE__] = function ( $cache, $code, $cachedData ) { This makes it so that if the

Re: [Wikitech-l] Performance issue with regard to JSON-based localisation format

2014-04-14 Thread Adrian Lang
Hi, On Mon, Apr 14, 2014 at 2:33 PM, Niklas Laxström niklas.laxst...@gmail.com wrote: Modifying LC itself does not help users like you who are running older versions of MediaWiki [1]. you are right, although I'm not using an older version of MediaWiki, I'm on

Re: [Wikitech-l] Performance issue with regard to JSON-based localisation format

2014-04-14 Thread Siebrand Mazeland
PleaseStand has already submitted a patch to mitigate this issue in https://gerrit.wikimedia.org/r/#/c/125706/ Please review. On Mon, Apr 14, 2014 at 2:33 PM, Niklas Laxström niklas.laxst...@gmail.comwrote: I think technically easiest solution is to modify the i18n.php files:

Re: [Wikitech-l] Performance issue with regard to JSON-based localisation format

2014-04-14 Thread Niklas Laxström
2014-04-14 15:35 GMT+03:00 Adrian Lang adrian.l...@wikimedia.de: you are right, although I'm not using an older version of MediaWiki, I'm on 77bc489c2731827b1c61a6509177eed23193d694 from 2014-04-11. Is something loading the i18n files manually then? Or is there a missing $wgMessagesDirs

Re: [Wikitech-l] Performance issue with regard to JSON-based localisation format

2014-04-14 Thread Adrian Lang
The files are loaded, only the merging is skipped if JSON-based localisation data is present. On Mon, Apr 14, 2014 at 3:01 PM, Niklas Laxström niklas.laxst...@gmail.com wrote: 2014-04-14 15:35 GMT+03:00 Adrian Lang adrian.l...@wikimedia.de: you are right, although I'm not using an older version

Re: [Wikitech-l] Keeping Code-Review votes across trivial changes of patch sets?

2014-04-14 Thread C. Scott Ananian
On Fri, Apr 11, 2014 at 4:08 PM, Daniel Friesen dan...@nadir-seen-fire.com wrote: I never liked this, over and over I point out a fatal issue with a commit sometimes fundamental to the idea itself and impossible to fix, so I -1 it, then when a new patchset comes out, completely ignores the

Re: [Wikitech-l] Larger thumbnails for MediaWiki / Wikimedia wikis?

2014-04-14 Thread C. Scott Ananian
Note that https://www.mediawiki.org/wiki/Requests_for_comment/Square_bounding_boxes may be related, since we're talking about what size default thumbnails appear at. Also https://www.mediawiki.org/wiki/Requests_for_comment/Standardized_thumbnails_sizes has existed for a while, it would be nice

Re: [Wikitech-l] Keeping Code-Review votes across trivial changes of patch sets?

2014-04-14 Thread Bartosz Dziewoński
On Mon, 14 Apr 2014 18:02:43 +0200, C. Scott Ananian canan...@wikimedia.org wrote: I think this is a social issue: we need to stop thinking of -2'ing a patch as a grave statement of disapproval. Nope (or not only), most people don't even have the ability to give out a -2 (it currently comes

Re: [Wikitech-l] Keeping Code-Review votes across trivial changes of patch sets?

2014-04-14 Thread Chad
On Mon, Apr 14, 2014 at 9:07 AM, Bartosz Dziewoński matma@gmail.comwrote: On Mon, 14 Apr 2014 18:02:43 +0200, C. Scott Ananian canan...@wikimedia.org wrote: I think this is a social issue: we need to stop thinking of -2'ing a patch as a grave statement of disapproval. Nope (or not

Re: [Wikitech-l] Abandoning -1 code reviews automatically?

2014-04-14 Thread Ryan Lane
On Sun, Apr 13, 2014 at 1:37 PM, Marcin Cieslak sa...@saper.info wrote: 2) https://gerrit.wikimedia.org/r/#/c/11562/ My favourite -1 here is needs rebase. Well, obviously trivial rebases should be done automatically by the system (which OpenStack's system does), and changes that need a

Re: [Wikitech-l] Proposed body font stack for Latin

2014-04-14 Thread Jon Robson
Erwin, I echo Erik's statement. Thanks for moving this along. In response to your suggestion that we need a font stack specific to the language I have compiled this patch [1] I envision this change should enable various other possibilities in styling our content better for other languages,

[Wikitech-l] Adding fields to Signup form

2014-04-14 Thread Gennaro, Desiree I CTR OSD CAPE (US)
Can anyone assist me in adding a dropdown list to the signup form using UserCreateForm hook and UsercreateTemplate::addInputItem class. I have figured out how to add a text field, but I'm not sure how to accomplish a dropdown menu. UsercreateTemplate::addInputItem ($name, $value, $type, $msg,

Re: [Wikitech-l] Keeping Code-Review votes across trivial changes of patch sets?

2014-04-14 Thread Antoine Musso
Le 11/04/2014 15:57, Christian Aistleitner a écrit : TL;DR: Gerrit would allow to keep Code-Review votes across * rebases and * commit message modifications of patch sets. Thereby dropping need to re-review “trivial” changes on patch sets. Shall we turn that feature on? snip Thank you

[Wikitech-l] MediaWiki Core Team plans for the coming quarter

2014-04-14 Thread Rob Lanphier
Hi everyone, I wanted to give everyone a heads up on our plans for the next quarter. The long version is here: https://www.mediawiki.org/wiki/Wikimedia_MediaWiki_Core_Team/Quarterly_review,_April_2014 The short version: we're planning to primarily focus on: * HHVM deployment. No promises

Re: [Wikitech-l] Keeping Code-Review votes across trivial changes of patch sets?

2014-04-14 Thread James Forrester
On 14 April 2014 12:06, Antoine Musso hashar+...@free.fr wrote: Le 11/04/2014 15:57, Christian Aistleitner a écrit : TL;DR: Gerrit would allow to keep Code-Review votes across * rebases and * commit message modifications of patch sets. Thereby dropping need to re-review “trivial”

Re: [Wikitech-l] REST and SOA within MediaWiki - is my understanding right?

2014-04-14 Thread Gabriel Wicke
On 04/11/2014 12:06 PM, Sumana Harihareswara wrote: So, just to clarify, this is NOT a discussion of overhauling the outward-facing MediaWiki web API -- that's taking place in https://www.mediawiki.org/wiki/Requests_for_comment/API_roadmap . The discussion is not about replacing the existing

[Wikitech-l] Documenting MediaWiki-Vagrant roles

2014-04-14 Thread Steven Walling
Please help fill in https://www.mediawiki.org/wiki/MediaWiki-Vagrant/Roles:) It's hard to know what a role does precisely without more docs than are provided via the 'vagrant list-roles' command. Maybe we could add a description to the list there? First step would be getting content I guess. --

Re: [Wikitech-l] Proposed body font stack for Latin

2014-04-14 Thread Erwin Dokter
On 15-04-2014 00:55, Isarra Yos wrote: Deemed better? Better how? But that's what I'm saying - if the configuration is optimised for dejavu sans, nimbus won't be better at all even if it is a better-engineered font (doubtful, though, it being an arial clone from what I understand). Letters will

[Wikitech-l] RfC on Product Management Tools and Development Toolchain

2014-04-14 Thread Andre Klapper
Hi, as previously announced [1], we've been facilitating a collective review of Wikimedia's current product management tools and development toolchain. The most popular idea at the moment is to consolidate Wikimedia's product management and infrastructure tools (such as Bugzilla, Gerrit, RT,

Re: [Wikitech-l] Documenting MediaWiki-Vagrant roles

2014-04-14 Thread Bryan Davis
On Mon, Apr 14, 2014 at 4:35 PM, Steven Walling swall...@wikimedia.org wrote: Please help fill in https://www.mediawiki.org/wiki/MediaWiki-Vagrant/Roles:) It's hard to know what a role does precisely without more docs than are provided via the 'vagrant list-roles' command. Maybe we could add a

[Wikitech-l] TAssembly -- template intermediate language

2014-04-14 Thread Matthew Walker
tldr; Gabriel Wicke and I completed the first iteration last week of our intermediate templating language. The runtime is available in both JavaScript [1] *and* PHP [2]. We're still working on optimizing the PHP version, but the JS version is already the fastest of anything we've bench marked

Re: [Wikitech-l] Proposed body font stack for Latin

2014-04-14 Thread Isarra Yos
On 14/04/14 23:49, Erwin Dokter wrote: On 15-04-2014 00:55, Isarra Yos wrote: Deemed better? Better how? But that's what I'm saying - if the configuration is optimised for dejavu sans, nimbus won't be better at all even if it is a better-engineered font (doubtful, though, it being an arial

Re: [Wikitech-l] Proposed body font stack for Latin

2014-04-14 Thread Steven Walling
On Mon, Apr 14, 2014 at 3:55 PM, Isarra Yos zhoris...@gmail.com wrote: Deemed better? Better how? But that's what I'm saying - if the configuration is optimised for dejavu sans, nimbus won't be better at all even if it is a better-engineered font (doubtful, though, it being an arial clone

Re: [Wikitech-l] Proposed body font stack for Latin

2014-04-14 Thread Isarra Yos
On 15/04/14 01:54, Steven Walling wrote: On Mon, Apr 14, 2014 at 3:55 PM, Isarra Yos zhoris...@gmail.com wrote: Deemed better? Better how? But that's what I'm saying - if the configuration is optimised for dejavu sans, nimbus won't be better at all even if it is a better-engineered font