[MediaWiki-CodeReview] [MediaWiki r92702]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r92702. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92702#c0 Commit summary: Use $this-getLang() per Nikerabbit on r91648. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r92715]: New comment added

2011-07-21 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r92715. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92715#c19948 Commit summary: Revert non-functional parts of r82343 -- 'select' parameter that's never actually been exported or used, and was always being forced to true before

Re: [Wikitech-l] Experimental Wikia RTE branch for MediaWiki trunk

2011-07-21 Thread Dmitriy Sintsov
* Brion Vibber br...@pobox.com [Fri, 6 May 2011 16:34:20 -0700]: On Fri, May 6, 2011 at 12:11 PM, Brion Vibber br...@pobox.com wrote: I'm having some trouble adapting the RTELinker class, which adds annotation to some link header structures and removes the table of contents; now that

[MediaWiki-CodeReview] [MediaWiki r92731]: New comment added

2011-07-21 Thread MediaWiki Mail
User Matthew.JA posted a comment on MediaWiki.r92731. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92731#c19949 Commit summary: Adding my USERINFO file! :] Comment: x2 on this, thanks ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92742]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r92742. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92742#c0 Commit summary: Whitespace update. ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Extensions needing a maintainer

2011-07-21 Thread Sumana Harihareswara
On 07/21/2011 10:39 AM, Mark A. Hershberger wrote: During my poll of developers about their Bugzilla settings, I was told that the current maintainers of the following two extensions do not have time to take care of them any longer and they need someone to step up and maintain them:

Re: [Wikitech-l] Extensions needing a maintainer

2011-07-21 Thread Chad
On Thu, Jul 21, 2011 at 9:31 AM, Sumana Harihareswara suma...@wikimedia.org wrote: One additional extension that needs someone to update for MW 1.17, put it on mediawiki.org, and do a little maintenance: http://www.epistemographer.com/2005/05/04/page-by-page-authentication-in-mediawiki/

Re: [Wikitech-l] Extensions needing a maintainer

2011-07-21 Thread Brion Vibber
That doesnt look like it would actually work -- anybody could still get at those pages' source through: * edit * special:export * action=raw * api * search result extracts -- brion On Jul 21, 2011 9:32 AM, Sumana Harihareswara suma...@wikimedia.org wrote: On 07/21/2011 10:39 AM, Mark A.

Re: [Wikitech-l] RFC: Should we drop the rendering preferences for math?

2011-07-21 Thread Chad
On Wed, Jul 20, 2011 at 8:13 PM, Michael Hardy drmichaelha...@gmail.com wrote: The two discussions should not be separate.  The issues in this thread have been talked about frequently since February 2003 on that wikiproject talk page.  Various views exist, but there is general agreement about

Re: [Wikitech-l] Extensions needing a maintainer

2011-07-21 Thread Sumana Harihareswara
On 07/21/2011 12:52 PM, Chad wrote: On Thu, Jul 21, 2011 at 9:48 AM, Brion Vibberbr...@wikimedia.org wrote: That doesnt look like it would actually work -- anybody could still get at those pages' source through: * edit * special:export * action=raw * api * search result extracts Right,

Re: [Wikitech-l] RFC: Should we drop the rendering preferences for math?

2011-07-21 Thread Brion Vibber
+1 on that -- using the wiki's the right thing! The list is great for devs but it's a high bar to figure out for feedback. My position for now is to recommend reducing the existing options to just PNG and text, and after that look more solidly at auto-enabling mathjax etc for the next major

[MediaWiki-CodeReview] [MediaWiki r92749]: New comment added

2011-07-21 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r92749. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92749#c19951 Commit summary: fu r92382, don't use Comment: fu: don't use -m :) ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92297]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r92297. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92297#c0 Commit summary: r92288 : Missed second arg to inArray ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r92297]: New comment added

2011-07-21 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r92297. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92297#c19952 Commit summary: r92288 : Missed second arg to inArray Comment: Item argument must be before the array argument (try it in the console), fixed in r92752

[MediaWiki-CodeReview] [MediaWiki r92297]: New comment added

2011-07-21 Thread MediaWiki Mail
User DieBuche posted a comment on MediaWiki.r92297. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92297#c19953 Commit summary: r92288 : Missed second arg to inArray Comment: Did you get my mail? ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92736]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r92736. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92736#c0 Commit summary: * Removed cdbmake-12.sh, not sure what this was for * Added populateWikiVersions.php script to

[MediaWiki-CodeReview] [MediaWiki r92297]: New comment added

2011-07-21 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r92297. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92297#c19954 Commit summary: r92288 : Missed second arg to inArray Comment: Yes ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92738]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r92738. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92738#c0 Commit summary: * Use dirname( __FILE__ ) as needed for require * Allow wrapperless maintenance scripts for now

[MediaWiki-CodeReview] [MediaWiki r86811]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86811. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86811#c0 Commit summary: MathCaptcha requires the texvc functions, which are now in the Math extension.

[MediaWiki-CodeReview] [MediaWiki r92751]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92751. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92751#c0 Commit summary: Merge updates from live version ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92749]: New comment added

2011-07-21 Thread MediaWiki Mail
User Jeroen De Dauw posted a comment on MediaWiki.r92749. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92749#c19955 Commit summary: fu r92382, don't use Comment: I feel ''bashed'' now :) ___

[MediaWiki-CodeReview] [MediaWiki r92750]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r92750. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92750#c0 Commit summary: Added $secure var back ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r92013]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r92013. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92013#c0 Commit summary: Follow-up to r86811: changed MWInit::classExists() to class_exists() - the former is only defined in MW =

[MediaWiki-CodeReview] [MediaWiki r92018]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r92018. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92018#c0 Commit summary: Follow-up to r86811 and r92013 - instead of using class_exists() or MWInit::classExists(), we'll replicate the

[MediaWiki-CodeReview] [MediaWiki r92546]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r92546. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92546#c0 Commit summary: SocialProfile: per Brion's comment on r92461, remove one useless call to User::loadFromId() on

[MediaWiki-CodeReview] [MediaWiki r92755]: New comment added

2011-07-21 Thread MediaWiki Mail
User Yaron Koren posted a comment on MediaWiki.r92755. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92755#c19956 Commit summary: Revert r92013, r92018 per CR Comment: Hi - why did you revert this code? I think it was fine. ___

[MediaWiki-CodeReview] [MediaWiki r92484]: New comment added

2011-07-21 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r92484. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92484#c19957 Commit summary: It seems people don't either pay attention to code comments, or those comments lie r92461 Comment: What about decodeOptions?

[MediaWiki-CodeReview] [MediaWiki r92461]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r92461. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92461#c0 Commit summary: Set explicit public modifier Swap @private to private ___

[MediaWiki-CodeReview] [MediaWiki r86482]: New comment added

2011-07-21 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r86482. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86482#c19958 Commit summary: (bug 13015, bug 18347, bug 18996, bug 20473, bug 23669, bug 28244) separate the password-reset request dialogue from SpecialUserlogin. * Refactor

[MediaWiki-CodeReview] [MediaWiki r86482]: New comment added, and revision status changed

2011-07-21 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86482. Old Status: new New Status: fixme User Aaron Schulz also posted a comment on MediaWiki.r86482. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86482#c19959 Commit summary: (bug 13015, bug 18347, bug 18996, bug 20473, bug

[MediaWiki-CodeReview] [MediaWiki r86482]: New comment added

2011-07-21 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r86482. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86482#c19960 Commit summary: (bug 13015, bug 18347, bug 18996, bug 20473, bug 23669, bug 28244) separate the password-reset request dialogue from SpecialUserlogin. * Refactor

[MediaWiki-CodeReview] [MediaWiki r89371]: New comment added, and revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89371. Old Status: fixme New Status: new User ^demon also posted a comment on MediaWiki.r89371. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89371#c19963 Commit summary: Various OpenID cleanups (did them as I went) * Drop 1.15 and

[MediaWiki-CodeReview] [MediaWiki r92758]: New comment added

2011-07-21 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r92758. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92758#c19964 Commit summary: Followup r92329: Fixes the localize test cases in IE 6 and 7. Looks like we do in fact need to select on 'msg,html\\:msg' in order to find the html:msg

[MediaWiki-CodeReview] [MediaWiki r89377]: New comment added, and revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89377. Old Status: deferred New Status: new User ^demon also posted a comment on MediaWiki.r89377. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89377#c19965 Commit summary: * Rewrite optionToTable to be like a modern maintenance

[MediaWiki-CodeReview] [MediaWiki r92758]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r92758. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92758#c0 Commit summary: Followup r92329: Fixes the localize test cases in IE 6 and 7. Looks like we do in fact need to select on 'msg,html\\:msg'

[MediaWiki-CodeReview] [MediaWiki r89377]: New comment added

2011-07-21 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r89377. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89377#c19966 Commit summary: * Rewrite optionToTable to be like a modern maintenance script ** Since we rely on pref rewrite per r89371, don't check for user_options, just

[MediaWiki-CodeReview] [MediaWiki r92755]: New comment added

2011-07-21 Thread MediaWiki Mail
User Yaron Koren posted a comment on MediaWiki.r92755. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92755#c19967 Commit summary: Revert r92013, r92018 per CR Comment: The reason is for backward compatibility, with versions of MediaWiki before 1.18 - so that, for example,

Re: [Wikitech-l] How Launchpad does it: merge proposals, on-call code review, EC2 automated testing

2011-07-21 Thread Sumana Harihareswara
Tomasz, if people find it valuable, we'll definitely consider it. I'm most interested in investigating other projects who deploy onto high-traffic websites, and have relatively high-speed code review, merge, deploy, and release turnaround. A few places where we could grab ideas: * OpenStack (I

[MediaWiki-CodeReview] [MediaWiki r78824]: New comment added

2011-07-21 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r78824. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/78824#c19968 Commit summary: (bug 14869) Add API module for accessing QueryPage-based special pages. Took 2.5 years and a flight to England to get this

[MediaWiki-CodeReview] [MediaWiki r78824]: New comment added, and revision status changed

2011-07-21 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r78824. Old Status: fixme New Status: new User Catrope also posted a comment on MediaWiki.r78824. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/78824#c19969 Commit summary: (bug 14869) Add API module for

Re: [Wikitech-l] Extensions needing a maintainer

2011-07-21 Thread Casey Brown
On Thu, Jul 21, 2011 at 1:04 PM, Sumana Harihareswara suma...@wikimedia.org wrote: In response to this review, I've suggested to the author of the page-by-page authentication extension update the page on his site to mark it deprecated, or remove it, and warn people not to use it.  Thanks all.

[MediaWiki-CodeReview] [MediaWiki r92722]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Werdna changed the status of MediaWiki.r92722. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92722#c0 Commit summary: MoodBar front-end dev: * ext.moodBar.core: - Implementing the type states (normal, hover, hovered, select, selected) *

Re: [Wikitech-l] Extensions needing a maintainer

2011-07-21 Thread Sumana Harihareswara
On Thu, Jul 21, 2011 at 2:14 PM, Casey Brown li...@caseybrown.org wrote: On Thu, Jul 21, 2011 at 1:04 PM, Sumana Harihareswara suma...@wikimedia.org wrote: In response to this review, I've suggested to the author of the page-by-page authentication extension update the page on his site to

[MediaWiki-CodeReview] [MediaWiki r92459]: New comment added, and revision status changed

2011-07-21 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r92459. Old Status: new New Status: fixme User Catrope also posted a comment on MediaWiki.r92459. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92459#c19970 Commit summary: changed sessionkey to filekey to

Re: [Wikitech-l] Extensions needing a maintainer

2011-07-21 Thread Andrew Garrett
On Thu, Jul 21, 2011 at 11:14 AM, Casey Brown li...@caseybrown.org wrote: Just a note that I think our stance on per-page access restrictions has always been: Do this at your own risk. This is not supported and will probably never be. We suggest you use another piece of software if you really

Re: [Wikitech-l] RFC: Should we drop the rendering preferences for math?

2011-07-21 Thread Brion Vibber
Ok, I've set up an RfC page on MediaWiki.org which'll be easier to comment on for folks not on the lists: http://www.mediawiki.org/wiki/Requests_for_comment/Reduce_math_rendering_preferences and added some links, comments requests for further feedback at:

[MediaWiki-CodeReview] [MediaWiki r92400]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r92400. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92400#c0 Commit summary: Followup r92396 More modules documented, pretty much only action=querylist= to be done (ie links

[MediaWiki-CodeReview] [MediaWiki r92733]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r92733. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92733#c0 Commit summary: getDescription must return a string, fu r92636 ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r92401]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r92401. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92401#c0 Commit summary: * (bug 28817) Add reference help page link to API Modules Last followup of r92396 Should be all

[MediaWiki-CodeReview] [MediaWiki r92430]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r92430. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92430#c0 Commit summary: * (bug 29935) Improve formatting of examples in ApiParamInfo Old example string with newlines

[MediaWiki-CodeReview] [MediaWiki r86697]: New comment added

2011-07-21 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r86697. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86697#c19971 Commit summary: (bug 26603) Followup r82232: fix double-escaping of returnto and returntoquery. Was caused by using two sources ($this-thisurl

Re: [Wikitech-l] Extensions needing a maintainer

2011-07-21 Thread Freako F. Freakolowsky
Well for starters the read rights for addon namespaces would be a nice first step. On 21. 07. 2011 20:35, Andrew Garrett wrote: On Thu, Jul 21, 2011 at 11:14 AM, Casey Brownli...@caseybrown.org wrote: Just a note that I think our stance on per-page access restrictions has always been: Do

[MediaWiki-CodeReview] [MediaWiki r86482]: New comment added

2011-07-21 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r86482. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86482#c19973 Commit summary: (bug 13015, bug 18347, bug 18996, bug 20473, bug 23669, bug 28244) separate the password-reset request dialogue from SpecialUserlogin. * Refactor

[MediaWiki-CodeReview] [MediaWiki r92777]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r92777. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92777#c0 Commit summary: Fix alignment of happy images ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92778]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r92778. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92778#c0 Commit summary: Revert r92777 -- Timo already fixed it ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r92689]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92689. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92689#c0 Commit summary: Create directory for ResourceLoader 2 branch ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r92503]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92503. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92503#c0 Commit summary: Damn you save r95202 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92559]: New comment added

2011-07-21 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r92559. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92559#c19974 Commit summary: Major update of stable features from development code. * For non-existing info pages (Wx/xx[x] pages), add a welcome page (either missing, existing or

[MediaWiki-CodeReview] [MediaWiki r92691]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92691. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92691#c0 Commit summary: RL2: Branch Gadgets extension for RL2 work ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r92729]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92729. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92729#c0 Commit summary: RL2: Add some more rights for the Gadget manager ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r92726]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92726. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92726#c0 Commit summary: RL2: Protect the Gadget namespace with the gadgets-edit right ___

[MediaWiki-CodeReview] [MediaWiki r92538]: New comment added

2011-07-21 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r92538. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92538#c19975 Commit summary: Follow-up r92528: * remove @static * return database result directly (no need for while()) * getAllPrefixesDb() -

[MediaWiki-CodeReview] [MediaWiki r86482]: New comment added

2011-07-21 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r86482. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86482#c19976 Commit summary: (bug 13015, bug 18347, bug 18996, bug 20473, bug 23669, bug 28244) separate the password-reset request dialogue from

[MediaWiki-CodeReview] [MediaWiki r91682]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91682. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91682#c0 Commit summary: Add seemingly missing transaction $db-begin() noticed in r91664 ___

[MediaWiki-CodeReview] [MediaWiki r92287]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92287. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92287#c0 Commit summary: 1.17wmf1 MFT r89003, r89005, r90217 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92704]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92704. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92704#c0 Commit summary: MFT r91107 - r92408 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92310]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92310. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92310#c0 Commit summary: Followup r92294, self::THUMB_PADDING isn't defined in 1.17 ___

[MediaWiki-CodeReview] [MediaWiki r92294]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92294. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92294#c0 Commit summary: 1.17wmf1 MFT r91573 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92314]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92314. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92314#c0 Commit summary: Followup to r92311: fix ProofreadPath to use wgExtensionAssetsPath; removed a stray console debug line

[MediaWiki-CodeReview] [MediaWiki r92104]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92104. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92104#c0 Commit summary: ArticleFeedback: Add disclaimer message per Howie ___ MediaWiki-CodeReview

Re: [Wikitech-l] Experimental Wikia RTE branch for MediaWiki trunk

2011-07-21 Thread Brion Vibber
On Thu, Jul 21, 2011 at 12:48 AM, Dmitriy Sintsov ques...@rambler.ruwrote: I've cloned it from git://gitorious.org/mediawiki-wikia-rte/mediawiki-wikia-rte.git and I am having huge troubles even getting it to run without fatal errors in 1.17. It seems to require Wikia custom classes and

[MediaWiki-CodeReview] [MediaWiki r92561]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92561. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92561#c0 Commit summary: 1.17wmf1: MFT r92104 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92793]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92793. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92793#c0 Commit summary: Got lines working, mostly ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92772]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92772. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92772#c0 Commit summary: Followup r92769: ignore messages for translatewiki.net. Btw: why not using the characters itself?

[MediaWiki-CodeReview] [MediaWiki r92771]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92771. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92771#c0 Commit summary: uppercase Firefox ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92770]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92770. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92770#c0 Commit summary: updated non free format message to include mention of firefogg as a firefox browser extension.

[MediaWiki-CodeReview] [MediaWiki r92791]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92791. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92791#c0 Commit summary: Use proper nosuchuser msg (fix for r86482) ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r92785]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92785. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92785#c0 Commit summary: Fix for r92702: there's no such method in Article class ___

[MediaWiki-CodeReview] [MediaWiki r92782]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92782. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92782#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-07-21 19:11:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r92713]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92713. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92713#c0 Commit summary: RELEASE-NOTES for r79383 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r79383]: New comment added, and revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r79383. Old Status: fixme New Status: new User ^demon also posted a comment on MediaWiki.r79383. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79383#c19977 Commit summary: Merging Vector's navigation_urls and SkinTemplate's

[MediaWiki-CodeReview] [MediaWiki r92794]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r92794. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92794#c0 Commit summary: Restructure dir structure to make checkout and such easier. The live-1.5 MWVersion.php file can

[MediaWiki-CodeReview] [MediaWiki r92648]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r92648. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92648#c0 Commit summary: Remove an index that we probably will not use ___

[MediaWiki-CodeReview] [MediaWiki r92463]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92463. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92463#c0 Commit summary: Documentation updates Add a couple of missing explicit class variables ___

[MediaWiki-CodeReview] [MediaWiki r92063]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92063. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92063#c0 Commit summary: Follow-up r91519: ellipsis was not included in the trimmed commit messages in list view - move mw-codereview-message to

[MediaWiki-CodeReview] [MediaWiki r92741]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92741. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92741#c0 Commit summary: Remove messages that shouldn't be here. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92637]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92637. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92637#c0 Commit summary: Follow up r92635. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92638]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92638. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92638#c0 Commit summary: Fix for r91885. These tests were added in r91885. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r92640]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92640. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92640#c0 Commit summary: Commit a list of unimplemented tests. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92639]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92639. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92639#c0 Commit summary: Follow up r92635 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r92635]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92635. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92635#c0 Commit summary: I like better checking for the actual extension, loading if needed (and able).

[MediaWiki-CodeReview] [MediaWiki r92282]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r92282. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92282#c0 Commit summary: RELEASE-NOTES for r92279 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r88270]: New comment added

2011-07-21 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r88270. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88270#c19978 Commit summary: Initial commit of configuration management backend proposal. Feedback desired before I go much further. * Common use case is Conf::get( 'myVar' ); *

[MediaWiki-CodeReview] [MediaWiki r90483]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r90483. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90483#c0 Commit summary: Mark test incomplete for a legitimate reason like trying to serialize a PDO object--rather than imaginary ones such

[MediaWiki-CodeReview] [MediaWiki r92528]: New comment added

2011-07-21 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r92528. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92528#c19979 Commit summary: (bug 19838) API does not use interwiki cache. Patch by Beau; modified to work with current code. Comment: Done in r92813

[MediaWiki-CodeReview] [MediaWiki r92538]: New comment added

2011-07-21 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r92538. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92538#c19980 Commit summary: Follow-up r92528: * remove @static * return database result directly (no need for while()) * getAllPrefixesDb() - getAllPrefixesDB() Comment: Used

[MediaWiki-CodeReview] [MediaWiki r92459]: New comment added

2011-07-21 Thread MediaWiki Mail
User Raindrift posted a comment on MediaWiki.r92459. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92459#c19981 Commit summary: changed sessionkey to filekey to keep consistent with the rest of UploadStash (while retaining sessionkey for backwards compatibility) Comment: Wow.

[MediaWiki-CodeReview] [MediaWiki r92459]: Revision status changed

2011-07-21 Thread MediaWiki Mail
User Raindrift changed the status of MediaWiki.r92459. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92459#c0 Commit summary: changed sessionkey to filekey to keep consistent with the rest of UploadStash (while retaining sessionkey for

Re: [Wikitech-l] improving bugzilla patch review: Splinter?

2011-07-21 Thread Helder
Hello! From what I saw on http://blog.fishsoup.net/2009/09/23/splinter-patch-review/ it seems very useful for people who are starting to provide patches for MW. Having this kind of feedback seems very good. I don't know if this is of any help but there is a similar tool available for users of

Re: [Wikitech-l] improving bugzilla patch review: Splinter?

2011-07-21 Thread Helder
Hello! From what I saw on http://blog.fishsoup.net/2009/09/23/splinter-patch-review/ it seems very useful for people who are starting to provide patches for MW. Having this kind of feedback seems very good. I don't know if this is of any help but there is a similar tool available for users of

  1   2   >