Re: wined3d: have SetAutoGenFilterType call glHint

2009-08-20 Thread Henri Verbeet
2009/8/20 joerg-cyril.hoe...@t-systems.com: Hi, This fixes bug #11167. It depends on my previous patch. One unclear issue about glHint() is the scope. What textures does it affect? When? An alternative would be, as Stefan Dösinger puts it: just check if the app ever sets two

Re: winemp3.acm: link to system libmpg123.so

2009-08-20 Thread Aric Stewart
I am looking into libmad, their programming APIs are completely undocumented so not sure how it works yet. But really it should be easy to add it to the frameworks as well so that either libmpg123 or libmad would be able to be used. But i see this as an addition onto the libmpg123 work

Re: [2/2] msxml3: Add IDispatchEx support to IXMLDOMElement

2009-08-20 Thread Jacek Caban
Hi Alistair, Alistair Leslie-Hughes wrote: Hi, Changelog: msxml3: Add IDispatchEx support to IXMLDOMElement +else if( IsEqualGUID( riid, IID_IDispatch ) || + IsEqualGUID( riid, IID_IDispatchEx ) ) +{ +xmlnode *node = impl_from_IXMLDOMNode( This-node ); + +

Re: winemp3.acm: link to system libmpg123.so

2009-08-20 Thread Aric Stewart
A quick license check does show that libmad is indeed GPL which means we cannot use it in WINE at all. -aric Aric Stewart wrote: I am looking into libmad, their programming APIs are completely undocumented so not sure how it works yet. But really it should be easy to add it to the

Re: winemp3.acm: link to system libmpg123.so

2009-08-20 Thread Roderick Colenbrander
If you are considering to write an additional backend, I would advise to add a fallback path to directshow. When the gstreamer code enters mp3 can then easily be added. If directshow for gstreamer isn't around, just use libmpg123 or use libmpg123 by default and directshow as a fallback. Roderick

Re: [PATCH 1/3] msxml3: Return xmlnode object from create_basic_node.

2009-08-20 Thread Alexandre Julliard
Jacek Caban ja...@codeweavers.com writes: @@ -84,6 +83,13 @@ static inline xmlnode *impl_from_IXMLDOMNode( IXMLDOMNode *iface ) return (xmlnode *)((char*)iface - FIELD_OFFSET(xmlnode, lpVtbl)); } +static inline IXMLDOMNode *_IXMLDOMNode_(xmlnode *This) +{ +return

Re: winemp3.acm: link to system libmpg123.so

2009-08-20 Thread Henri Verbeet
2009/8/20 Roderick Colenbrander thunderbir...@gmail.com: If you are considering to write an additional backend, I would advise to add a fallback path to directshow. Wouldn't that potentially create a cyclic dependency?

Re: winemp3.acm: link to system libmpg123.so

2009-08-20 Thread Aric Stewart
That is what I am worried about. I am willing to believe that direct show uses the acm drivers to decode the audio. I have not found anything to prove that yet but it is my gut feeling. -aric Henri Verbeet wrote: 2009/8/20 Roderick Colenbrander thunderbir...@gmail.com: If you are

Re: winemp3.acm: link to system libmpg123.so

2009-08-20 Thread Henri Verbeet
2009/8/20 Aric Stewart a...@codeweavers.com: That is what I am worried about. I am willing to believe that direct show uses the acm drivers to decode the audio. I have not found anything to prove that yet but it is my gut feeling. Well, there's dlls/quartz/acmwrapper.c. That won't necessarily

Re: [PATCH 1/3] msxml3: Return xmlnode object from create_basic_node.

2009-08-20 Thread Jacek Caban
Alexandre Julliard wrote: Jacek Caban ja...@codeweavers.com writes: @@ -84,6 +83,13 @@ static inline xmlnode *impl_from_IXMLDOMNode( IXMLDOMNode *iface ) return (xmlnode *)((char*)iface - FIELD_OFFSET(xmlnode, lpVtbl)); } +static inline IXMLDOMNode *_IXMLDOMNode_(xmlnode *This) +{

GSoC - Wine/Gstreamer

2009-08-20 Thread Trevor Davenport
Hi, I wanted to send a mail to the list and basically state what the status of all this is and what my plans are for the future. For those unfamiliar with what i was doing, I was trying to enable using gstreamer elements as directshow filter to expand the quartz functionality available. At the

Re: [PATCH 1/3] msxml3: Return xmlnode object from create_basic_node.

2009-08-20 Thread Alexandre Julliard
Jacek Caban ja...@codeweavers.com writes: I just feel that it's better to have a wrapper to avoid explicit casts in the code and have vtbl logic separated from other code. I usually use macros, but I know you don't like it, so I used an inline function here. For secondary vtbls that's

Re: [PATCH 1/3] msxml3: Return xmlnode object from create_basic_node.

2009-08-20 Thread Jacek Caban
Alexandre Julliard wrote: Jacek Caban ja...@codeweavers.com writes: I just feel that it's better to have a wrapper to avoid explicit casts in the code and have vtbl logic separated from other code. I usually use macros, but I know you don't like it, so I used an inline function here.

Re: [PATCH 02/12] windowscodecs: Add IWICStream_InitializeFromMemory implementation [try 2]

2009-08-20 Thread Alexandre Julliard
Tony Wasserka tony.wasse...@freenet.de writes: + * + * Used by IWICStream_InitializeFromMemory + * This interface is windowscodecs private only which + * is why we don't need to implement QueryInterface and AddRef Don't do that, implement it properly even if that code is not used at this

Re: ws2_32: Only examine lower-order bits in getsockopt/setsockopt

2009-08-20 Thread Alexandre Julliard
Juan Lang juan.l...@gmail.com writes: @@ -1779,6 +1779,8 @@ INT WINAPI WS_getsockopt(SOCKET s, INT level, TRACE(socket: %04lx, level 0x%x, name 0x%x, ptr %p, len %d\n, s, level, optname, optval, *optlen); +/* Some apps sign-extend the level, so mask off the higher-order

Re: ws2_32: Only examine lower-order bits in getsockopt/setsockopt

2009-08-20 Thread Juan Lang
There can be several other ways to handle this, it needs test cases to determine which way Windows is using. Sorry for my lack of imagination: could you suggest at least one other way so I can make sure the tests are representative? Thanks, --Juan

Re: ws2_32: Only examine lower-order bits in getsockopt/setsockopt

2009-08-20 Thread Alexandre Julliard
Juan Lang juan.l...@gmail.com writes: There can be several other ways to handle this, it needs test cases to determine which way Windows is using. Sorry for my lack of imagination: could you suggest at least one other way so I can make sure the tests are representative? It may check for

Re: old patch enabling visible icons in some applications

2009-08-20 Thread Philipp A.
what do you mean with “clean it up”? i don’t see anything not-clean about it. and why is it nonfunctional in your opinion? and for testing: that’s what svn-versions are for, aren’t they? 2009/8/20 James McKenzie jjmckenzi...@earthlink.net Philipp A. wrote: Well bug 8555

Re: old patch enabling visible icons in some applications

2009-08-20 Thread Juan Lang
Well, i think, they don't like working apps. What on earth can i do to make somebody stop by and put the damn patch into the svn? You can keep yelling on this list, and tell us how busy you are. We care. Really and truly we do. --Juan

Re: old patch enabling visible icons in some applications

2009-08-20 Thread Luke Benstead
2009/8/20 Philipp A. trueflyingsh...@googlemail.com: what do you mean with “clean it up”? i don’t see anything not-clean about it. and why is it nonfunctional in your opinion? and for testing: that’s what svn-versions are for, aren’t they? 2009/8/20 James McKenzie jjmckenzi...@earthlink.net

Re: ws2_32: Only examine lower-order bits in getsockopt/setsockopt

2009-08-20 Thread Detlef Riekenberg
On Do, 2009-08-20 at 17:58 +0200, Alexandre Julliard wrote: Juan Lang juan.l...@gmail.com writes: @@ -1779,6 +1779,8 @@ INT WINAPI WS_getsockopt(SOCKET s, INT level, TRACE(socket: %04lx, level 0x%x, name 0x%x, ptr %p, len %d\n, s, level, optname, optval, *optlen); +

Re: ws2_32: Only examine lower-order bits in getsockopt/setsockopt

2009-08-20 Thread Detlef Riekenberg
On Do, 2009-08-20 at 18:22 +0200, Alexandre Julliard wrote: Juan Lang juan.l...@gmail.com writes: There can be several other ways to handle this, it needs test cases to determine which way Windows is using. Sorry for my lack of imagination: could you suggest at least one other way so

Re: ws2_32: Only examine lower-order bits in getsockopt/setsockopt

2009-08-20 Thread Juan Lang
Hi Detlef, When reading the log in the bug, the WSAAsyncGetHostByName16 is the indicator for an 16bit app. Right you are. I ignored that, but clearly I was mistaken. Attached is my diff from last year for that code. The changes you made to getsockopt16 and setsockopt16 look correct. The

Bug for beginners

2009-08-20 Thread Alexandros Dermenakis
Hi all, I studied the wine developer's guide and went a bit through the code. I would like a suggestion, a bug to start understanding better the structure of wine and familiarize myself with it in order to be able to contribute more in the future. thank you

Re: Bug for beginners

2009-08-20 Thread Juan Lang
I studied the wine developer's guide and went a bit through the code. I would like a suggestion, a bug to start understanding better the structure of wine and familiarize myself with it in order to be able to contribute more in the future. Often, picking an application that you yourself run

Re: Bug for beginners

2009-08-20 Thread Andrew Eikum
Alexandros Dermenakis wrote: Hi all, I studied the wine developer's guide and went a bit through the code. I would like a suggestion, a bug to start understanding better the structure of wine and familiarize myself with it in order to be able to contribute more in the future. thank you