Re: [2/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 2)

2013-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2351 Your paranoid

Re: ntdll: Make asynchronous WaitCommEvent report correct number of bytes returned.

2013-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2356 Your paranoid

Re: [PATCH 1/3] riched20: Use codepage in ME_ToUnicode. (try 5)

2013-09-27 Thread Jactry Zeng
Hi all, I see this patch is in 'pending' now, are there anything needs to be improved? Please give me some advice. Thank you. -- Regards, Jactry Zeng

Re: [PATCH 1/2] advapi32: HKCR merge: foundation

2013-09-27 Thread Alexandre Julliard
George Stephanos gaf.stepha...@gmail.com writes: @@ -224,13 +248,138 @@ static NTSTATUS open_key( HKEY *retkey, ACCESS_MASK access, OBJECT_ATTRIBUTES *a } +static LSTATUS create_hkcr_struct( HKEY *hkey, opened_hkcr_t **hkcr ) +{ +UINT_PTR handle = nb_hkcr_handles, i; +

Re: [PATCH 1/5] wined3d: Send present operations through a command stream.

2013-09-27 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-27 00:15, schrieb Henri Verbeet: -swapchain-swapchain_ops-swapchain_present(swapchain, src_rect, dst_rect, dirty_region, flags); + wined3d_cs_emit_present(swapchain-device-cs, swapchain, src_rect, +dst_rect,

Re: [PATCH 1/5] wined3d: Send present operations through a command stream.

2013-09-27 Thread Henri Verbeet
On 27 September 2013 13:05, Stefan Dösinger stefandoesin...@gmail.com wrote: I think we should place comments like This function is called through the command stream for all functions that are called through the CS, similar to what we do for context activation. Perhaps, I'm not sure. For that

Re: [1/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 3)

2013-09-27 Thread Alexandre Julliard
Akihiro Sagawa sagawa@gmail.com writes: Fixes bug 18440, 20847. Try 3: - Rebase to recent source. - Separate ABC metrics change. - Use conditional operator. It breaks the tests: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so dib.c touch

Re: [PATCH 1/5] wined3d: Send present operations through a command stream.

2013-09-27 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-27 14:19, schrieb Henri Verbeet: Perhaps, I'm not sure. For that kind of comment to be useful it should have a clear set of implications, and I'm not sure it has that until we work out the details of the multi-threaded implementation.

Re: [PATCH 1/5] wined3d: Send present operations through a command stream.

2013-09-27 Thread Henri Verbeet
On 27 September 2013 15:23, Stefan Dösinger stefandoesin...@gmail.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-27 14:19, schrieb Henri Verbeet: Perhaps, I'm not sure. For that kind of comment to be useful it should have a clear set of implications, and I'm not sure it

Re: add ualapi directory (try 10)

2013-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2370 Your paranoid

Re: [PATCH 1/2] appwiz.cpl: Use the same dialog template for Mono and Gecko downloader.

2013-09-27 Thread Vincent Povirk
Isn't this going to make the caption Wine Gecko Installer in both cases?

Re: [PATCH 2/2] mshtml: Added IHTMLFormElement::sumit tests.

2013-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2374 Your paranoid

Re: (try 6)[3/5] imm32: use thread data from target HWND

2013-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2375 Your paranoid

Re: (try 6)[4/5] imm32: Restrict crossthread Association and destruction

2013-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2376 Your paranoid

Re: (try 6)[5/5] imm32: limit cross thread access to ImmSet* functions

2013-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2377 Your paranoid

Re: [2/2] ws2_32: Implement WSASendMsg()

2013-09-27 Thread Bruno Jesus
On Sat, Sep 28, 2013 at 1:50 AM, Bruno Jesus 00cp...@gmail.com wrote: Fixes bug 34005. There is a problem with this patch, I'm working on an updated version. Sorry, Bruno

Re: add ualapi directory (try 11)

2013-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2386 Your paranoid