Re: ntdll: remove an unnecessary NULL check : Coverity

2007-01-02 Thread Dmitry Timoshkov
Jeff L [EMAIL PROTECTED] wrote: Looking a bit further it seems that NtCreateMailslotFile is only called from CreateMailslotW. If there is a problem with a NULL then it stems from there. http://source.winehq.org/ident?i=CreateMailslotW NtCreateMailslotFile is a public API, so probably it

Re: ntdll: remove an unnecessary NULL check : Coverity

2007-01-02 Thread Jeff L
Dmitry Timoshkov wrote: NtCreateMailslotFile is a public API, so probably it should handle the case when attr is NULL. I see the same problem at least in NtCreateNamedPipeFile. In general, handling of OBJECT_ATTRIBUTES in ntdll is not consistent, but fixing it properly most likely a test is

Re: dbghelp: Search for .gnu_debuglink file

2007-01-02 Thread Eric Pouech
Frank Richter a écrit : The .gnu_debuglink section contains only a bare filename, however, the debug file can be in a number of locations. These are stated in the GDB manual and are now searched when a .gnu_debuglink is encountered. Frank, a couple of remarks: - there are memory leaks in the

World of Warcraft Progress

2007-01-02 Thread darckness
Ahoy! First off, I'd like to say happy 2007! Hope you all did some good celebrating. I know I did ;) Anyway, I've been doing some testing on World of Warcraft, and I noticed some things of interest (Latest wine version from cvs/git, no patches applied). First off, the D3D (DX9) runs MUCH

Re: wininet: ensure null check before dereference

2007-01-02 Thread James Hawkins
On 1/1/07, Jeff Latimer [EMAIL PROTECTED] wrote: Coverity cid: 367 Do the null check before the dereference. Given that this is an simple internal function, do we need to check for null pointers? Generally we don't check for NULL params in internal functions. -- James Hawkins

Re: [9/16] WineD3D: Move decoding the vertex declaration to the device

2007-01-02 Thread Stefan Dösinger
Am 02.01.2007 um 05:38 schrieb Ivan Gyurdiev: +if (stateblock-wineD3DDevice-vs_selected_mode != SHADER_NONE stateblock-vertexShader + ((IWineD3DVertexShaderImpl *) stateblock-vertexShader)-baseShader.function != NULL) +memcpy(stateblock-wineD3DDevice-strided_streams,

Re: World of Warcraft Progress

2007-01-02 Thread Stefan Dösinger
Am 02.01.2007 um 09:51 schrieb darckness: First off, the D3D (DX9) runs MUCH better (faster and more smoothly) than the OGL mode. Big kudos to you guys; last time I played, the D3D mode was completely unusable because there was no D3D support in wine. Very impressive. Nice :-) The OGL

Re: dlls/opengl32/wgl.c: minor dealloc fix

2007-01-02 Thread Kai Blin
On Tuesday 02 January 2007 02:40, Nick Burns wrote: However, this seems dangerous if you wanted to take any of that code and run it under windows (but im guessing xp and 2k work this way -- and few people use 95/98/me anymore) There are win98 tests run on test.winehq.org. You can check there

Re: systray [2]: transparent icons: let systray window responsible for background

2007-01-02 Thread Alexandre Julliard
Kirill K. Smirnov [EMAIL PROTECTED] writes: @@ -366,6 +366,7 @@ static void systray_dock_window( Display wine_tsx11_lock(); XSendEvent( display, systray_window, False, NoEventMask, ev ); +XSetWindowBackgroundPixmap(display, data-whole_window,

Re: Resend: d3d9: fix failing tests on windows, when no 3d hardware acceleration is available

2007-01-02 Thread Alexandre Julliard
Louis. Lenders [EMAIL PROTECTED] writes: Hi, is there anything wrong with this patch? If so, could you please tell me what. Thx I fixed it up, but next time please try to respect the indentation style of the existing file. We don't have any place that uses a strange style like this: +

Re: Resend: d3d9: fix failing tests on windows, when no 3d hardware acceleration is available

2007-01-02 Thread Ivan Gyurdiev
Louis. Lenders wrote: Hi, is there anything wrong with this patch? If so, could you please tell me what. Thx */Louis. Lenders [EMAIL PROTECTED]/* wrote: Hi, this patch should fix failing tests in d3d9, like you see for example here: http://test.winehq.org/data/200612231000/

Re: Resend: d3d9: fix failing tests on windows, when no 3d hardware acceleration is available

2007-01-02 Thread Stefan Dösinger
Am 02.01.2007 um 13:45 schrieb Ivan Gyurdiev: So why not fallback to REF or NULLREF type of device everywhere else if HAL is unavailable? Do those tests need HAL support in the first place? There are some differences between HAL and REF which are important to some games. Refcount tests

Re: World of Warcraft Progress

2007-01-02 Thread Tomas Carnecky
darckness wrote: First off, the D3D (DX9) runs MUCH better (faster and more smoothly) than the OGL mode. Big kudos to you guys; last time I played, the D3D mode was completely unusable because there was no D3D support in wine. Very impressive. The GLX_ARB_vertex_buffer_object is described

Re: systray [2]: transparent icons: let systray window responsible for background

2007-01-02 Thread Kirill K. Smirnov
Kirill K. Smirnov [EMAIL PROTECTED] writes: @@ -366,6 +366,7 @@ static void systray_dock_window( Display wine_tsx11_lock(); XSendEvent( display, systray_window, False, NoEventMask, ev ); +XSetWindowBackgroundPixmap(display, data-whole_window,

Re: systray [2]: transparent icons: let systray window responsible for background

2007-01-02 Thread Alexandre Julliard
Kirill K. Smirnov [EMAIL PROTECTED] writes: 2) If I set window shape to 'AND' bitmap of icon (do I correctly understand you?) then what to do with full transparent icons? E.g. some applications (qip) flashes the icons by changing the icon with full transparent icon and back. a) Will

Re: quartz: add implementations for AmpFactorToDB and DBToAmpFactor

2007-01-02 Thread Roderick Colenbrander
Hi, Why are you using a lookup table and not just a log10(x) and 10^(x) for the gain - dB conversions? That's how it should be done I think like 10x corresponding to 20dB (assuming signal gain). In your tests it is just: 2000*log10(gain) - 9630 for going to that dB-like scale. Regards,

Re: [SPAM] Re: Looking for sound testers

2007-01-02 Thread Alex Villací­s Lasso
Neil Skrypuch escribió: On Thursday, December 28, 2006 10:04, Maarten Lankhorst wrote: Hi all, I've forward ported the old patches of Davin McCall (dsound.patch). With them I have no more sound underruns etc, I'm therefore looking for other people to test them as well. I'm welcoming

Re: atl: Declare some items static

2007-01-02 Thread Robert Shearman
Andrew Talbot wrote: -HRESULT WINAPI AtlModuleLoadTypeLib(_ATL_MODULEW *pM, LPCOLESTR lpszIndex, -BSTR *pbstrPath, ITypeLib **ppTypeLib) +static HRESULT WINAPI AtlModuleLoadTypeLib(_ATL_MODULEW *pM, LPCOLESTR lpszIndex, +

Re: rpc issues

2007-01-02 Thread Damjan Jovanovic
On 1/1/07, Matthew Edlefsen [EMAIL PROTECTED] wrote: Hi, I've been trying to get a program that uses rpc to work on wine and I've been having some problems (my understanding is that isn't surprising). The goal is to be able to run a rpc server that sits and waits for connections over tcp/ip

Re: [SPAM] Re: Looking for sound testers

2007-01-02 Thread SorinN
Hi all I dont know what you do there guys but ..BEFORE last ALSA related upgrade ( ubuntu feisty ) foobar2000 under wine cannot play mp3 files - AFTER the upgrade ( 2 files I think ) foobar2000 play my files and work EXACT like foobar2000 under XP. I use right now wine 0.9.27 Good job. Sorin

Re: [PATCH 1/3] [Msvcrt]: reset a signal to DFL after it's been used

2007-01-02 Thread Alexandre Julliard
Eric Pouech [EMAIL PROTECTED] writes: @@ -455,13 +456,13 @@ static LONG WINAPI msvcrt_exception_filt case EXCEPTION_FLT_OVERFLOW: case EXCEPTION_FLT_STACK_CHECK: case EXCEPTION_FLT_UNDERFLOW: -if (sighandlers[MSVCRT_SIGFPE]) +if ((handler =3D

Re: [PATCH] [DbgHelp]: implemented 64 bit versions of EnumerateLoadedModules

2007-01-02 Thread Alexandre Julliard
Eric Pouech [EMAIL PROTECTED] writes: +BOOL WINAPI EnumerateLoadedModulesW64(HANDLE hProcess, + PENUMLOADED_MODULES_CALLBACKW64 E= numLoadedModulesCallback, + PVOID UserContext) +{ +struct enum_load_mod64_W64

Re: [PATCH] [ImageHlp]: MapAndLoad

2007-01-02 Thread Alexandre Julliard
Eric Pouech [EMAIL PROTECTED] writes: @@ -199,7 +204,10 @@ BOOL WINAPI MapAndLoad(LPSTR pszImageNam ((LPBYTE) pNtHeader-OptionalHeader + pNtHeader-FileHeader.SizeOfOptionalHeader); pLoadedImage-NumberOfSections =3D pNtHeader-FileHeader.NumberOfSec= tions; -

Re: [SPAM] Re: Looking for sound testers

2007-01-02 Thread * *
On 1/2/07, SorinN [EMAIL PROTECTED] wrote: Hi all I dont know what you do there guys but ..BEFORE last ALSA related upgrade ( ubuntu feisty ) foobar2000 under wine cannot play mp3 files - AFTER the upgrade ( 2 files I think ) foobar2000 play my files and work EXACT like foobar2000 under XP. I

help with dll

2007-01-02 Thread xie jason
Hi there, My name is Jason. I am trying to compile my windows application under linux. I found that the dll file i use to build mu application links to some other dlls. i was just wondering that when i compile it under linux, do i need to compile with those dlls. if yes, it will be very

Re: quartz: add implementations for AmpFactorToDB and DBToAmpFactor

2007-01-02 Thread Robert Reif
Roderick Colenbrander wrote: Hi, Why are you using a lookup table and not just a log10(x) and 10^(x) for the gain - dB conversions? That's how it should be done I think like 10x corresponding to 20dB (assuming signal gain). In your tests it is just: 2000*log10(gain) - 9630 for going to that

Re: Uniscribe improvements

2007-01-02 Thread Marcus Meissner
On Tue, Jan 02, 2007 at 12:42:25PM -0600, * * wrote: Please use your real name. To avoid problems with ligitation later on we need it for tracking. Ciao, Marcus

Re: Uniscribe improvements

2007-01-02 Thread Hans Leidekker
On Tuesday 02 January 2007 19:42, * * wrote: StringAnalysis should have a cache object, not save the HDC directly. I agree, although you shouldn't free the cache in ScriptStringFree, the caller is responsible for that. One of the important things about the cache, which wine currently doesn't

Re: Uniscribe improvements

2007-01-02 Thread * *
On 1/2/07, Hans Leidekker [EMAIL PROTECTED] wrote: On Tuesday 02 January 2007 19:42, * * wrote: StringAnalysis should have a cache object, not save the HDC directly. I agree, although you shouldn't free the cache in ScriptStringFree, the caller is responsible for that. One of the important

Re: systray icon questions

2007-01-02 Thread James Liggett
On Fri, 2006-12-29 at 11:33 +0300, Kirill K. Smirnov wrote I've tried kde, fluxbox and xfce4 (and fvwm, but it lacks systray). Now I can see that xfce4 suffers from it. I did not noticed that before. So, I suppose a new patch (attached). Does it work correct with GNOME? In xfce is OK.

Re: atl: Declare some items static

2007-01-02 Thread Andrew Talbot
Robert Shearman wrote: Did you try compiling linking this? WINAPI is usually only applied to exported functions. Hi Rob, My patch was totally wrong: I think I must have compiled and linked the before version. I infer that an exported function (in the DLL sense) must have external linkage

RE: RFC: Patch better support for DevMode

2007-01-02 Thread Nick Burns
Anyone have comments in this space? I am sure that the behavior difference of EnumDisplaySettings{A,W} before and after window creation is a bug. I think I will submit this patch (barring any complaints) and try to fix the behavior difference later. This is still a solid fix afaict. Any

Re: What to do about apps that require 256-color mode?

2007-01-02 Thread L. Rahyen
On Tuesday January 2 2007 00:43, Dan Kegel wrote: So what's Wine to do? Can we somehow tell Wine to emulate 256 color mode for particular apps? You can try to launch game like this: wine explorer /desktop=Game,800x600 game.exe At least for me this simple trick helps

Re: Uniscribe improvements

2007-01-02 Thread Jeff L
* * wrote: According to MSDN, the pending error is to give the calling app a chance to select the matching font back into the DC if the information wasn't cached. I think that the get_script_cache function is broken, in that it should return the pending error if the HDC isn't provided, since

Re: ppviewer.exe MSI failure (PowerPoint 2k3): HowTo assemble a lynch mob?

2007-01-02 Thread Ben Hodgetts (Enverex)
James Hawkins wrote: On 1/1/07, Andreas Mohr [EMAIL PROTECTED] wrote: Hi all, http://www.microsoft.com/downloads/details.aspx?familyid=428D5727-43AB-4F24-90B7-A94784AF71A4displaylang=en failed to install with some nice MSI failures when I tried it last week on a current Wine version

Re: wined3d: state_pointsprite should apply to all texture units

2007-01-02 Thread Tomas Carnecky
Chris Robinson wrote: +for (i = 0; i GL_LIMITS(texture_stages); i++) { +/* Note the WINED3DRS value applies to all textures, but GL has one + * per texture, so apply it now ready to be used! + */ +if (GL_SUPPORT(ARB_MULTITEXTURE)) { +

Re: Uniscribe improvements

2007-01-02 Thread * *
On 1/2/07, Jeff L [EMAIL PROTECTED] wrote: * * wrote: According to MSDN, the pending error is to give the calling app a chance to select the matching font back into the DC if the information wasn't cached. I think that the get_script_cache function is broken, in that it should return the

Re: appdb rating inflation

2007-01-02 Thread Dan Kegel
As Chris Morgan pointed out, http://appdb.winehq.org/help/?sTopic=maintainer_ratings might need clarification. It now says -- snip -- Platinum An application can be rated as Platinum if it installs and runs out of the box No changes required to winecfg. Gold Application works flawlessly with

Re: appdb rating inflation

2007-01-02 Thread * *
On 1/2/07, Dan Kegel [EMAIL PROTECTED] wrote: As Chris Morgan pointed out, http://appdb.winehq.org/help/?sTopic=maintainer_ratings might need clarification. It now says -- snip -- Platinum An application can be rated as Platinum if it installs and runs out of the box No changes required to

Re: appdb rating inflation

2007-01-02 Thread Frank Richter
On 03.01.2007 04:00, Dan Kegel wrote: No manual editing of files, no winecfg settings, no native DLLs, no third-party install scripts, and no cracks are allowed for a Platinum rating. Giving a set of points may lead to some people think hey to run MyApplication I just have to some obscure

Re: What to do about apps that require 256-color mode?

2007-01-02 Thread Dan Kegel
On 1/2/07, L. Rahyen [EMAIL PROTECTED] wrote: So what's Wine to do? Can we somehow tell Wine to emulate 256 color mode for particular apps? You can try to launch game like this: wine explorer /desktop=Game,800x600 game.exe At least for me this simple trick helps sometimes.

Re: What to do about apps that require 256-color mode?

2007-01-02 Thread L. Rahyen
On Wednesday January 3 2007 06:22, Dan Kegel wrote: On 1/2/07, L. Rahyen [EMAIL PROTECTED] wrote: So what's Wine to do? Can we somehow tell Wine to emulate 256 color mode for particular apps? You can try to launch game like this: wine explorer /desktop=Game,800x600 game.exe

Re: Uniscribe improvements

2007-01-02 Thread Jeff L
* * wrote: If the device context is passed as NULL and Uniscribe needs to access it for any reason, Uniscribe returns the error code E_PENDING. This code is returned quickly, allowing the application to avoid time-consuming SelectObject calls. Whereas the current implementation will silently