Re: USB?

2004-08-10 Thread Aric Stewart
Hi, Sorry for not getting back to you all faster, i was at linux world and such. Yup i am looking hard at the setupapi device calls and cfgmgr to try to get some usb support targeted toward the iPod. I have made some progress and am beginning to have an understand of how usb is handled in

Re: USB?

2004-08-11 Thread Aric Stewart
key that would show that transition. -aric Rolf Kalbermatter wrote: Aric Stewart wrote: I do have some difficulty figuring out how win2k is translating vender and product ids into class and interface guids. The documentation reports that they look them up in inf files, however i am finding

Re: IShellLink and non-existant exe files

2004-08-23 Thread Aric Stewart
empty. Shouldn't we set exePath to the same value as This-sPath ? Christian Aric Stewart wrote: It is possible under windows to create a .Lnk file to an exe file before it exists. Office 2000 does this, Scientific Word does this as do other apps as well. So a quick fix so that in IPersistFile_Save

Re: InternetGetConnectedStateExA

2004-11-03 Thread Aric Stewart
ah, thanks for catching that i will redo my patch. -aric Alexandre Julliard wrote: Aric Stewart [EMAIL PROTECTED] writes: +BOOL WINAPI InternetGetConnectedStateExA(LPDWORD lpdwStatus, +LPSTR lpszConnectionName, DWORD dwNameLen, DWORD dwReserved) +{ +INT len; +LPWSTR

State of the Msi

2004-12-15 Thread Aric Stewart
Hi all, Long time no post :) I just wanted to give an update that Mike M. and I have done alot of msi work over the first few weeks of December which caused a few significant changes to particularly action.c where we eliminated many of the static buffers for file paths and replaced them with

Re: msctf: add internal function for handling TfClientIds

2009-02-23 Thread Aric Stewart
Yup, reworked and resent. -aric James Mckenzie wrote: Alexandre Julliard julli...@winehq.org wrote on Feb 23: Aric Stewart a...@codeweavers.com writes: +/* If i understand this correctly at most a process should generate + * only a handful of these... But in case I am wrong

Re: [1/12] dinput: begin joystick separation into a generic module

2009-03-07 Thread Aric Stewart
Vitaliy Margolen wrote: Aric Stewart wrote: --- Patch set looks good with exception of - few more things can be moved out of joystick_linuxinput.c. But that can be separate patch(es). Vitaliy

Re: (try 2)advapi32: base implementation of LsaLookupNames2

2009-03-19 Thread Aric Stewart
! -aric Paul Vriens wrote: Aric Stewart wrote: fix tests for win95 --- dlls/advapi32/lsa.c | 51 +++- dlls/advapi32/tests/lsa.c | 82 - 2 files changed, 131 insertions(+), 2 deletions

Re: [1/3]msctf: ThreadMgr sink framework

2009-03-24 Thread Aric Stewart
Thanks, resent. -aric Alexandre Julliard wrote: Aric Stewart a...@codeweavers.com writes: typedef struct tagACLMulti { const ITfThreadMgrVtbl *ThreadMgrVtbl; const ITfSourceVtbl *SourceVtbl; LONG refCount; ITfDocumentMgr *focus; + +/* kept as separate lists

Re: advapi32: stub TreeResetNamedSecurityInfo for the IE8 installer

2009-03-25 Thread Aric Stewart
I will admit I do not have access to the latest headers but my impression from MSDN and a web search is that FN_PROGRESS is not defined in a header. I will keep looking but that is why i did it that way. -aric Alexandre Julliard wrote: Aric Stewart a...@codeweavers.com writes: diff --git

Re: msi: avoid negative index in TABLE_insert_row

2009-03-25 Thread Aric Stewart
-row_count which is generating an idx of less than 0; It looks like a wine bug. I can look into writing a test. -aric James Hawkins wrote: On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart a...@codeweavers.com wrote: fixes bug Bug 17600 --- dlls/msi/table.c |3 ++- 1 files changed, 2 insertions

Re: X11DRV_AlphaBlend: FIXME not a DIB section

2009-03-27 Thread Aric Stewart
Hi there, As the author of one of the patches that was not approved, Alexandre told me that he felt that the whole X11DRV_AlphaBlend needed to be rewritten, maybe not even found in that module. If i recall correctly there was worries about how it was starting to duplicate code from the

Re: gdi32/enhmfdrv: Actaully save the state in SaveDC and RestoreDCin the metafile

2009-04-04 Thread Aric Stewart
Hi Dmitry, Yeah, Alexandre did not like any of my patches and feels that duplicating the GDI code would be incorrect (it would result in too many SelectObject records and such) so he had me write up patch with a bunch of tests as wine_todos that demonstrate the problem so he could think

Re: [2/2] wine.inf: Add HKCU\Keyboard Layout\Preload key.

2009-04-10 Thread Aric Stewart
I had a patch that did this, it never got through. Let me see if i can polish it off and make it acceptable. -aric Alexandre Julliard wrote: Hans Leidekker h...@codeweavers.com writes: @@ -546,6 +546,7 @@ HKLM,System\CurrentControlSet\Control\Session Manager,,,

Re: ole32: CoGetTreatAsClass should return S_FALSE if it cannot even find the key for the requested CLSID

2009-04-23 Thread Aric Stewart
Good point, actually it should not be leaving the clsid alone it should be duplicating the requested GUID into it. (wine already does this part) I will update the test to properly show that. -aric Paul Vriens wrote: Aric Stewart wrote: Fixes issues with IE7 involving constant prompting

Re: Mac OS X Joystick problem

2009-05-21 Thread Aric Stewart
Well the Mac OS X Joystick code will only work on Leopard. So you will have to build and run it on Leopard box using xcode3. If you are good there then try building the winetests for dinput and run them with your joystick plugged in. You should get some status traces about your joystick

Re: Mac OS X Joystick problem

2009-05-26 Thread Aric Stewart
of these games so I can take a look? -aric Nathan Gray wrote: On Thu, May 21, 2009 at 10:45 AM, Aric Stewart a...@codeweavers.com wrote: If you are good there then try building the winetests for dinput and run them with your joystick plugged in. You should get some status traces about your joystick

Re: shlwapi: add test for CombineUrl

2009-06-02 Thread Aric Stewart
Humm, how odd, it was working here on my mac. i will test further. -aric Alexandre Julliard wrote: Aric Stewart a...@codeweavers.com writes: Associated with bug 18063 which is fixed. Apparently not: ../../../tools/runtest -q -P wine -M shlwapi.dll -T ../../.. -p shlwapi_test.exe.so

Re: ActiveX support in IE7

2009-06-25 Thread Aric Stewart
Hello, I have been working in this area for the last several days. It is actually greatly improving. I think the bulk of the remaining work is in the wintrust area to correctly validate the downloaded cabinet files. Then the prompting of the user to install these files. With some of my

transl question

2009-07-14 Thread Aric Stewart
I am looking at the Japanese report from transl and i see something odd. looking at DIALOG MSGBOX for user32... http://source.winehq.org/transl/resource.php?lang=011%3A00resfile=dlls%2Fuser32type=5id=MSGBOXcompare= the STYLE is reported as different, but when I look at the source they appear

Re: gdi32: ensure that the last_resort family at least has FS_LATIN1characters.

2009-07-15 Thread Aric Stewart
but that seemed too hackish. -aric Dmitry Timoshkov wrote: Aric Stewart a...@codeweavers.com wrote: Corrects a large number of font issues with east asian programs. -if(csi.fs.fsCsb[0] (face-fs.fsCsb[0] | face-fs_links.fsCsb[0])) { +if((csi.fs.fsCsb[0] (face-fs.fsCsb[0

Re: gdi32: ensure that the last_resort family at least has FS_LATIN1characters.

2009-07-15 Thread Aric Stewart
of fonts. It would be nice to have a more general fix. -aric Dmitry Timoshkov wrote: Aric Stewart a...@codeweavers.com wrote: Ok maybe you could help me brainstorm a better fix. The issue I am seeing is that this application is a chinese application and it is asking for Tahoma for GB2312_CHARSET

Re: Question about the gphoto2.ds resources

2009-07-30 Thread Aric Stewart
Humm, You know I have no idea. I know I used a freeware program called resource builder to make that dialog and then i think i just pretty much wholesale used that programs output. It very well may be something that resource builder put in that I did not catch. I am sure it can be

Re: gdi32: Ensure child fonts have names

2009-07-31 Thread Aric Stewart
Timoshkov wrote: Aric Stewart a...@codeweavers.com wrote: @@ -5792,6 +5792,9 @@ static BOOL load_child_font(GdiFont *font, CHILD_FONT *child) child-font-scale_y = font-scale_y; hfontlist = HeapAlloc(GetProcessHeap(), 0, sizeof(*hfontlist)); hfontlist-hfont = CreateFontIndirectW(font

Re: gdi32: Ensure child fonts have names

2009-07-31 Thread Aric Stewart
Thanks, resent. -aric Dmitry Timoshkov wrote: Aric Stewart a...@codeweavers.com wrote: load_child_font calls neither WineEngCreateFontInstance nor GetEnumStructs. It allocates the the child font structure above in the function sets the few fields it thinks it needs and then goes on. I see

Re: winemp3: a fix for security alert CVE-2006-1655

2009-08-07 Thread Aric Stewart
It means similar fix... however that wording appears in the original patch to libmpg123 that corrects this problem and so in the layer3.c implementation in modern libmpg123 So i debated changing the wording or keeping the original wording and decided to keep it the same as layer3.c in

Re: Review: winex11.drv: Add workaround for 'phantom key' presence in X

2009-08-12 Thread Aric Stewart
It seems to be 'OK' for X11 to return that because everyone in the X11 universe seems to just accept that as how X works. Not fixing it wine would mean require all wine users to use something like xmodmap to modify their own xservers to get the correct behavior. That doesn't seem like an

mp3 update

2009-08-12 Thread Aric Stewart
Hello all, I am working on updating our winemp3.acm implementation to a modern libmpg123. We where at about 0.59r and I have 1.8.1 working very well. I have a few questions. Right now I have the smallest subset of files from libmpg123 that are needed to compile and work in the wine

Re: mp3 update

2009-08-12 Thread Aric Stewart
Well the main advantage I can see is that we are able to have mp3 support without adding a new library dependency. This will be especially useful for platforms other than Linux where libmpg123 is not present. Such as the Mac. There is no technical or licensing reason we would have to link to

Re: mp3 update

2009-08-18 Thread Aric Stewart
Sorry, I was out Friday and Monday so I am just getting back here. Am i reading that the general opinion is that I should rework winemp3.acm to load the external libmpg123 and just abandon the builtin mp3 support? Or was there still something else of issue with my work? thanks, -aric

Re: winemp3.acm: link to system libmpg123.so

2009-08-20 Thread Aric Stewart
I am looking into libmad, their programming APIs are completely undocumented so not sure how it works yet. But really it should be easy to add it to the frameworks as well so that either libmpg123 or libmad would be able to be used. But i see this as an addition onto the libmpg123 work

Re: winemp3.acm: link to system libmpg123.so

2009-08-20 Thread Aric Stewart
A quick license check does show that libmad is indeed GPL which means we cannot use it in WINE at all. -aric Aric Stewart wrote: I am looking into libmad, their programming APIs are completely undocumented so not sure how it works yet. But really it should be easy to add

Re: winemp3.acm: link to system libmpg123.so

2009-08-20 Thread Aric Stewart
That is what I am worried about. I am willing to believe that direct show uses the acm drivers to decode the audio. I have not found anything to prove that yet but it is my gut feeling. -aric Henri Verbeet wrote: 2009/8/20 Roderick Colenbrander thunderbir...@gmail.com: If you are

Re: [3/3]msctf/tests: test ITfThreadMgr::AssociateFocus

2009-09-08 Thread Aric Stewart
Thanks. I will take a look. -aric Paul Vriens wrote: On 09/01/2009 02:08 PM, Aric Stewart wrote: --- dlls/msctf/tests/inputprocessor.c | 141 - 1 files changed, 139 insertions(+), 2 deletions

Re: msctf/tests: handle an occassional unexpected SetFocus from wine

2009-11-07 Thread Aric Stewart
Please disregard this. I was testing the wrong version on my winvista machine and this causes a failure. revised version coming. -aric Aric Stewart wrote: --- dlls/msctf/tests/inputprocessor.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-)

Re: Anti aliased fonts in wine - minimum font size

2009-12-03 Thread Aric Stewart
Avery Pennarun wrote: On Thu, Dec 3, 2009 at 5:37 PM, Austin English austinengl...@gmail.com wrote: On Thu, Dec 3, 2009 at 4:02 PM, Avery Pennarun apenw...@gmail.com wrote: I'm using Microsoft Office 2002 under wine. According to the instructions here:

Re: Anti aliased fonts in wine - minimum font size

2009-12-04 Thread Aric Stewart
Avery Pennarun wrote: On Thu, Dec 3, 2009 at 10:31 PM, Mike Kaplinskiy mike.kaplins...@gmail.com wrote: I think some time ago this was explained as a NOTABUG in freetype, which actually obeys the font's preferences and if the font supplies special images for smaller font sizes, it uses them

Re: dinput: the DIK_ keycode is not the same as the scancode.

2008-07-22 Thread Aric Stewart
the hook but i dont remember why i decided not to do that, but i am very sleepy right now, if that is better, and probably this should be extended to include VK codes for non ascii characters in case they do not line up either. But it was a first pass. Vitaliy Margolen wrote: Aric Stewart wrote

DSurface optimization, comments requested

2008-07-25 Thread Aric Stewart
Hi there, I was playing with a older Japanese side scrolling shooter benchmark and was getting 4.3 frames per second. Some digging revealed that the game made extensive use of Blt on gdi surfaces and it looks like the current implementation of Blt actually locks the entire destination surface

Re: wined3d: in surface Blt when source and destination are not the same only lock the part of the destination surface that is requested to copy to.

2008-07-28 Thread Aric Stewart
: 2008/7/28 Aric Stewart [EMAIL PROTECTED]: +if (Src != This) +{ +xdst.top = 0; +xdst.bottom = DestRect-bottom - DestRect-top; +xdst.left = 0; +xdst.right = DestRect-right - DestRect-left; +} This will still break

Re: dinput: the DIK_ keycode is not the same as the scancode.

2008-07-30 Thread Aric Stewart
of a better way to try to solve this problem without having a bunch of special case situations which struck me as bad. -aric Vitaliy Margolen wrote: Aric Stewart wrote: It is mapped with the keyboard mapping to the resulting character. so the key 'A' is DIK_A nomatter what its scancode or vkey would

Re: dinput: the DIK_ keycode is not the same as the scancode.

2008-07-30 Thread Aric Stewart
Doing tests with shift show that the presence of the shift key does not affect MapVirtualKey so SHIFT+2 still returns '2' since it is scancode based i doubt that numlock would either. So I do not think we need to worry about that. -aric Vitaliy Margolen wrote: Aric Stewart wrote

Re: [2]wined3d: rework surface Blt a bit to only lock the part of the destination surface being drawn to

2008-07-30 Thread Aric Stewart
Had Stefan look over it before I submitted it this time. thanks! -aric H. Verbeet wrote: 2008/7/30 Aric Stewart [EMAIL PROTECTED]: --- dlls/wined3d/surface_base.c | 122 +++ 1 files changed, 65 insertions(+), 57 deletions(-) Looks reasonable to me

Re: dinput: the DIK_ keycode is not the same as the scancode.

2008-07-31 Thread Aric Stewart
Yes this is a specific problem I am seeing. In a Japanese online Mahjong game, there appears to be no way to remap the keys and the game is using the top 2 rows of the keyboard to control the movement of the tiles in the game. the top row scan codes for a japanese keyboard are: 123

Re: dinput: the DIK_ keycode is not the same as the scancode.

2008-07-31 Thread Aric Stewart
Yes, I have verified those vkeys in windows. the VK_OEM_* keys are specificaly VK codes that vary from keyboard to keyboard. VK_OEM_3 is just one example. -aric Vitaliy Margolen wrote: Aric Stewart wrote: vkey codes similarly do not produce a clean 1 to 1 correspondance. the '@' key (0x1a

Re: dinput: the DIK_ keycode is not the same as the scancode.

2008-07-31 Thread Aric Stewart
Here is a revised patch which builds the scancode-DIK table on initialization making no xserver round trips required on lookup. How does this look? -aric Aric Stewart wrote: Yes, I have verified those vkeys in windows. the VK_OEM_* keys are specificaly VK codes that vary from keyboard

Re: dinput: the DIK_ keycode is not the same as the scancode.

2008-08-04 Thread Aric Stewart
Thanks for the feedback. Resubmitted. -aric Vitaliy Margolen wrote: Please bottom post on this ML. Aric Stewart wrote: Here is a revised patch which builds the scancode-DIK table on initialization making no xserver round trips required on lookup. How does this look? -aric

Re: mlang: Remove a test that fails on all systems

2008-09-02 Thread Aric Stewart
That is interesting... I am pretty confident that test passed when I was testing it on Japanese windows XP. I will try it again to be sure. -aric Paul Vriens wrote: Hi, (Grabbed this mail from http://www.winehq.org/pipermail/wine-patches) This test however fails on Windows and succeeds

Re: mlang: Remove a test that fails on all systems

2008-09-02 Thread Aric Stewart
Paul Vriens wrote: Aric Stewart wrote: That is interesting... I am pretty confident that test passed when I was testing it on Japanese windows XP. I will try it again to be sure. I guess it should pass on all Windows and Wine boxes unless it has to be skipped.

Re: imm32: Improve ImmGetCompositionString.

2008-09-08 Thread Aric Stewart
locales as it should. -aric Paul Vriens wrote: Aric Stewart wrote: It should return number of copied bytes. But it always returns required buffer size to receive all information. (originally by Kusanagi Kouichi ([EMAIL PROTECTED]) ) --- dlls/imm32/imm.c | 207

Re: imm: Don't crash in ImmConfigureIME when dwMode is IME_CONFIG_REGISTERWORD and lpData is NULL (resend)

2008-09-18 Thread Aric Stewart
Humm, according to MSDN: If dwMode is set to IME_CONFIG_REGISTERWORD, this parameter must indicate a REGISTERWORD structure. If windows does not crash in this case, then maybe it would involve checking for the non-presence of the parameter and returning the correct error. So it looks like

Re: mlang: test, make sure UNICODE-1252 is convertable before failing when we cannot convert. (this fixes the tests on japanese windows installs)

2008-09-27 Thread Aric Stewart
Sorry all, this patch is clearly incorrect. I am continuing to try to find out why these test fail on my windows 2000 japanese vm. -aric Aric Stewart wrote: --- dlls/mlang/tests/mlang.c | 100 +- 1 files changed, 63 insertions(+), 37 deletions(-)

Re: (try 2)version: check for out of memory when VerInstallFileA/W converstion. (response to coverity 635)

2008-10-02 Thread Aric Stewart
Whoops on the whitespace. The paths are irrelevent. They are intentionally pointing at a file and location that is not existing. Should I change the paths to express that more explicitly; something like: D:\\oes\\not\\exist ? -aric Rob Shearman wrote: 2008/10/2 Aric Stewart [EMAIL

Re: New Coverity run Oct 1st. 58 fixed, 41 new warnings in cabinet, jscript, mshtml, wined3d, and code generated by widl

2008-10-07 Thread Aric Stewart
Do you have coverity access? if so we can make all these ignore. If not then tell me and I will go in and mark them ignore. -aric Rob Shearman wrote: 2008/10/6 Dan Kegel [EMAIL PROTECTED]: Thanks to the half-dozen Wine developers attacking the Coverity warnings, we are slowly making

Re: user: edit.c make sure our vlc (vertical line count) is at least 1 even if there is an oversized font in the edit control

2008-10-14 Thread Aric Stewart
Great idea, patch resubmitted. -aric Juan Lang wrote: Hi Aric, Just a suggestion: @@ -1818,6 +1818,7 @@ static void EDIT_ML_InvalidateText(EDITSTATE *es, INT start, INT end) RECT rcUpdate; INT l; + if (vlc == 0) vlc = 1; if ((el es-y_offset) || (sl

Re: comdlg32/tests: Windows XP cannot do a CreateViewWindow2 twice in rapid seccesion. handle this error.

2008-10-17 Thread Aric Stewart
Not sure. I tried all sorts of changes to get the second test to succeed. It is not the test itself. If i comment out the first set it works fine. If i reverse the order the new second one fails. and the error code is totally unhelpful. -aric Henri Verbeet wrote: Any idea why it can't do

Re: wldap32/tests: modify test that was failing on every windows system

2008-10-21 Thread Aric Stewart
yup, i saw that when i updated this morning. Sorry. ignore my patch. -aric Hans Leidekker wrote: On Tuesday 21 October 2008 14:29:45 Aric Stewart wrote: -ok( !ret, ldap_search_ext_sA failed 0x%x\n, ret ); +ok( ret==0x55 || ret == 0x51, ldap_search_ext_sA unexpected return 0x%x\n

Re: (try 4) comdlg32/tests: Windows XP+ cannot do a CreateViewWindow2twice in rapid seccesion. handle this error.

2008-10-23 Thread Aric Stewart
Thanks for all the help and feedback. resubmitted. -aric Paul Vriens wrote: Paul Vriens wrote: Dmitry Timoshkov wrote: Aric Stewart [EMAIL PROTECTED] wrote: +/* + * Windows XP is unable to recreate the ViewWindow2 returning + * A Catastrophic failure

Re: ws2_32: set correct error if lpOverlapped has an event of NULL and lpCompletionRoutine is also NULL

2008-10-27 Thread Aric Stewart
Ignore this please. -aric Aric Stewart wrote: --- dlls/ws2_32/socket.c |2 ++ dlls/ws2_32/tests/sock.c | 32 2 files changed, 34 insertions(+), 0 deletions(-)

Re: defwnd: implement handling of WM_INPUTLANGCHANGE

2008-12-09 Thread Aric Stewart
doh! good catch! thanks, i will correct that and resend. -aric Paul Chitescu wrote: On Tuesday 09 December 2008 21:17:32 Aric Stewart wrote: [...] +while (win_array[count]) +SendMessageA( win_array[count], WM_INPUTLANGCHANGE, wParam, lParam); Missing

Re: MSI: fix some NULL checking in MSI_RecordGetStringA

2008-12-16 Thread Aric Stewart
Ok, Though it mirrors what is happening over in MSI_RecordGetStringW so i assumed it was just a few check that had been accidentally forgotten. -aric James Hawkins wrote: On Tue, Dec 16, 2008 at 9:11 AM, Aric Stewart a...@codeweavers.com wrote: --- dlls/msi/record.c |7 --- 1

Re: [1/2] imm32: Fix the ImmIsUIMessageA/W.

2008-12-17 Thread Aric Stewart
Since I value your input in imm32 and i do a lot of work there. If you would like to send me that high level overview then I can see if it works into wine. That way you can continue to contribute and we do not compromise the source code. I have not looked at these patches yet so just send me

Re: [1/2] imm32: Fix the ImmIsUIMessageA/W.

2008-12-18 Thread Aric Stewart
Ahh ok, thanks. Will do. -aric Alexandre Julliard wrote: Aric Stewart a...@codeweavers.com writes: Since I value your input in imm32 and i do a lot of work there. If you would like to send me that high level overview then I can see if it works into wine. That way you can continue

Re: shell32: initial stub for SHGetImageList

2009-01-20 Thread Aric Stewart
While early versions of shell32 in XP this is true, in later versions of XP's shell32 and in Vista this api is accessible by name. How should we do that then? -aric Nikolay Sivov wrote: Aric Stewart wrote: --- dlls/shell32/shell32.spec |1 + dlls/shell32/shellord.c |6 ++ 2

Re: Worldbench?

2009-01-28 Thread Aric Stewart
Very interesting. Here at CodeWeavers we have been very interested in benchmarking test and had very little luck finding ones that ran. We have a very very old one called officebench (which is no longer even avalable) that does VB scripting of office which was the only one we could get

Re: [2/13]msctf: implement SetFocus and GetFocus

2009-01-30 Thread Aric Stewart
. There is also a note in msdn about AssociateFocus which states that it does not increment the lock possibly in contrast to SetFocus. The documentation on these interfaces is very very sparse. -aric Jacek Caban wrote: Hi Aric, Aric Stewart wrote: --- dlls/msctf/threadmgr.c | 28

Re: advapi32: add Security Label sids used by IE7

2009-02-03 Thread Aric Stewart
yes as far as i can tell there was not an Untrusted label that is defined like the others. I included it in winnt.h for completeness. -aric Paul Vriens wrote: Aric Stewart wrote: --- dlls/advapi32/security.c |4 include/winnt.h | 16 +++- 2 files changed

Re: imm32: Make space for a 64bit pointer in the IMM window.

2009-02-11 Thread Aric Stewart
I am not a 64 bit expert but i do not think this is going to work. ddk/imm.h is a Microsoft header so IMEs and programs compiled with the original header will not have the expanded space. To fix this properly (I assume you are trying to support 64 bit) is that we will probibly have to store a

Re: imm32: Make space for a 64bit pointer in the IMM window.

2009-02-11 Thread Aric Stewart
is not valid. -aric Michael Stefaniuc wrote: Aric Stewart wrote: I am not a 64 bit expert but i do not think this is going to work. ddk/imm.h is a Microsoft header so IMEs and programs compiled with the original header will not have the expanded space. They will as the Microsoft header has

Re: gdiplus: in GdipDrawString only NULL terminate if we have room in the buffer.

2009-02-12 Thread Aric Stewart
the stringdup[j] = 0 we are writing one WCHAR off the end of the buffer. -aric Nikolay Sivov wrote: Aric Stewart wrote: --- dlls/gdiplus/graphics.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c index 2673042

Re: wininet: parse cookie information from cookie value

2009-02-16 Thread Aric Stewart
Thanks for the tip. Resent. -aric Rob Shearman wrote: 2009/2/13 Aric Stewart a...@codeweavers.com: +if (CompareStringW(GetThreadLocale(), NORM_IGNORECASE, ptr, 6, + szDomain, 6) == 2) LOCALE_INVARIANT should be used when comparing with a constant string

Re: [5/6]wininet: handle cookie expiration

2009-02-18 Thread Aric Stewart
Wonderful, I was looking for a function JUST like that. Reworked patch coming up shortly. -aric Hans Leidekker wrote: +LPCWSTR ptr,ptr2; +SYSTEMTIME tm; +int i; + +memset(tm,0,sizeof(tm)); + +ptr = expiry; +for (i = 0; i 7; i++) +{ +if

Re: msctf crosstest build failed

2009-02-18 Thread Aric Stewart
could you check to see if uuid is being build properly? -aric Nikolay Sivov wrote: Building today crosstests I've got: i586-mingw32msvc-gcc -c -I. -I. -I../../../include -I../../../include -g -O2 -o inputprocessor.cross.o inputprocessor.c i586-mingw32msvc-gcc -c -I. -I.

Re: msctf crosstest build failed

2009-02-18 Thread Aric Stewart
Not sure. I can crossbuild it here on my mac with mingw without any issue. I will admit my knowledge of why is pretty limited. -aric Nikolay Sivov wrote: Aric Stewart wrote: could you check to see if uuid is being build properly? -aric Aric, is there any reason that we don't usually link

Re: msi: begin support for finding network last sources in find_published_source

2009-02-20 Thread Aric Stewart
wrote: On Thu, Feb 19, 2009 at 12:28 PM, Aric Stewart a...@codeweavers.com wrote: Fix for office 2007 sp 1 install. --- dlls/msi/media.c | 33 + 1 files changed, 33 insertions(+), 0 deletions(-) I believe you're going down the wrong road with respect

Re: msi: begin support for finding network last sources in find_published_source

2009-02-20 Thread Aric Stewart
Ok i am following you but. James Hawkins wrote: On Fri, Feb 20, 2009 at 4:45 AM, Aric Stewart a...@codeweavers.com wrote: Hello, . . . No, I think the patch is wrong in that if you remove the original media and the stored cabs, the install will fail. By that thinking then the whole function

Input Focus problems with IE

2003-12-16 Thread Aric Stewart
Hello, I am working on a problem with IE where if you start the application in full screen mode: (start IE, change to full screen using view-full screen, shutdown IE, restart IE) the keyboard focus never gets given to the application so you cannot enter any information into forms.

Re: no keyboard events in ddraw application.

2004-01-06 Thread Aric Stewart
I believe this is the same issue i am seeing with IE started in full screen mode. It appears that those windows are being created in unmanaged mode and thus never generate any of the focus events that wine uses to try to track input focus. if you place them into a desktop then it works fine. I

Re: imm work

2004-01-07 Thread Aric Stewart
If you could point out what you would need me to modify to make it work better i could see what i could do. -aric Steven Edwards wrote: Hiya Aric, --- Aric Stewart [EMAIL PROTECTED] wrote: Notes: I fear this may violate dll separation between Imm32 and X11drv. I have a very long and bad

Re: wine/dlls x11drv/x11drv_main.c x11drv/x11drv.s ...

2004-01-25 Thread Aric Stewart
Doh! and i thought i had cleaned up all my shotgun attempts to get Japanese office 2000 working again. Yes. this needs to be fixed. I will make the patch to return this to normal and submit it asap. -aric Dmitry Timoshkov wrote: Alexandre Julliard [EMAIL PROTECTED] wrote: Log message: Aric

Re: wine/dlls x11drv/x11drv_main.c x11drv/x11drv.s ...

2004-01-25 Thread Aric Stewart
before making that change. Once that is made then we can probably remove this chunk of code. Which would be nice. -aric Dmitry Timoshkov wrote: Alexandre Julliard [EMAIL PROTECTED] wrote: Log message: Aric Stewart [EMAIL PROTECTED] Use X11 XIM callbacks to enable full IME support. Correct some

Re: SelectionMark

2004-02-12 Thread Aric Stewart
to my patch. -aric Dimitrie O. Paun wrote: On February 11, 2004 02:07 pm, Aric Stewart wrote: +if (bResult lvItem.stateMask LVIS_SELECTED +lvItem.stateLVIS_SELECTED ((infoPtr-nSelectionMark + == -1) || (lvItem.iItem = infoPtr-nSelectionMark))) That's some funky

Re: scroll window fix

2007-01-26 Thread Aric Stewart
Whoop, my bad. I almost always miss that on my first pass. I will correct that and resent. Thanks for pointing it out. -aric Peter Oberndorfer wrote: On Thursday 25 January 2007 18:56, Aric Stewart wrote: finds the case where the scrolling amount exceeds the window but still falls within

Re: Make sure keyboard state is up to date before processing GetAsyncKeyState.

2007-02-27 Thread Aric Stewart
That could be true. Since it was only used in this one place I was not sure the protocol for adding it to the header file or just as a prototype in this file. I will resubmit the patch -aric Detlef Riekenberg wrote: On Di, 2007-02-27 at 20:28 +0900, Aric Stewart wrote: --- a/dlls/winex11

Re: (resend) Scroll window fix

2007-03-03 Thread Aric Stewart
likely I did something incorrect in the test. -aric Dmitry Timoshkov wrote: Aric Stewart [EMAIL PROTECTED] wrote: +SetRect( rc, 0,40, 100,60); +SetRect( cliprc, 0,0, 100,100); +ScrollWindowEx( hwnd1, 0, -25, rc, cliprc, hrgn, rcu, SW_INVALIDATE); +SetRectRgn( tmprgn

Re: (resend) Scroll window fix

2007-03-03 Thread Aric Stewart
if they would be helpful. -aric Dmitry Timoshkov wrote: Aric Stewart [EMAIL PROTECTED] wrote: I did my work comparing to windows 2000. I could not get the test to run at all on my windows box so i had to try to fiddle with the test to get it to work. What exactly was the problem? I spent a lot

Re: imm32: Use the PostMessageW for WM_IME_NOTIFY message.

2007-03-12 Thread Aric Stewart
I am pretty sure that these are done via SendMessage when I checked with Spy++. Additional a number of the applications I am working with hang when the WM_IME_NOTIFY is sent out of order. -aric Byeong-Sik Jeon wrote: We have to call PostMessage to send WM_IME_NOTIFY message. To send

Re: imm32: Use the PostMessageW for WM_IME_NOTIFY message.

2007-03-12 Thread Aric Stewart
string with scim( my xim program ). Aric Stewart wrote: I am pretty sure that these are done via SendMessage when I checked with Spy++. Additional a number of the applications I am working with hang when the WM_IME_NOTIFY is sent out of order. -aric Byeong-Sik Jeon wrote: We have to call

Re: respect unicode _ILCreateFromFindData

2007-04-10 Thread Aric Stewart
Thanks for the comments. I have corrected most and will resubmit. Dmitry Timoshkov wrote: + +type = (wfd-dwFileAttributes FILE_ATTRIBUTE_DIRECTORY) ? PT_FOLDER : PT_VALUE; + +/* + * FileStruct already has one byte for the first name, so use len - 1 in + * size calculation +

Re: Extensive ScrollDC investigation

2007-04-29 Thread Aric Stewart
wrote: Aric Stewart [EMAIL PROTECTED] wrote: Reworking some parts of ScrollDC to properly mask and scroll the right areas of the DC as well as generate the correct update regions. Extensive testing used to verify the behavior. This test hangs forever for me under XP displaying a listbox

Re: Extensive ScrollDC investigation

2007-04-30 Thread Aric Stewart
they will not be triggered allowing the test to run without supervision. -aric Kuba Ober wrote: On Monday 30 April 2007, Aric Stewart wrote: I do a scanf() inside of DRAW_CHECK so that you can look at the scroll results and hit enter in the console to go on. If that is not good I can change or even

Re: buffer check in comdlg

2006-04-07 Thread Aric Stewart
Drat bitten by formatting again. And i thought i checked but i realized i checked and then reedited the file and my setting returned to default. Should i redo the formatting and resubmit? -aric Robert Shearman wrote: Aric Stewart wrote: if(fodInfos-unicode) { LPOPENFILENAMEW ofn

Re: RFC/PATCH: Twain + Gphoto

2006-04-17 Thread Aric Stewart
This is really cool! I have poked a bit at it to see and like how it is going so far. It does not appear to actually get any photos from the cameras yet or am i missing that code. The ImageInfoGet and ImageMemXferGet are sort of the heart of that. At least for the program I am working on

Re: msi: appsearch

2006-07-05 Thread Aric Stewart
Maybe, i am unclear about how a fake dll in wine.inf would work. the problem is that previously we where doing a FindFile on the given directory and of course there is no file there so the process stopped. -aric Juan Lang wrote: if trying to find a DLL that is located in the system

Re: comcat work

2006-07-14 Thread Aric Stewart
Timoshkov wrote: Aric Stewart [EMAIL PROTECTED] wrote: Here are 2 patches, the first is resending my handing of -1 in EnumClassesOfCategories, the second patch is a test case for the first patch. It would be interesting to see how other negative values are supposed to be handled, and if it's

Re: MSI: partially implement of AppSearch action

2005-02-01 Thread Aric Stewart
Hi Juan, YAY! someone else doing action work.. However there are a few problems i want to point out so you can review your code and check. I have attached a patch i quickly made to avoid some problems i was having. But what you will want to look over and figure out is a) if the action returns

Re: msi: detect registry keypaths

2005-02-22 Thread Aric Stewart
Ahh you are correct, That is unnecessary. I can rework it or you can remove that test. Thanks for pointing it out. -aric Alexandre Julliard wrote: Aric Stewart [EMAIL PROTECTED] writes: -FIXME(Only working for installed files, not registry keys\n); -if ( GetFileAttributesW(path

Re: msi: PublishComponents and MsiGetQualifiedComponentExW

2005-04-19 Thread Aric Stewart
Thanks for the pointers, I have resubmitted the patch taking these into account. Index: dlls/msi/msipriv.h === RCS file: /home/wine/wine/dlls/msi/msipriv.h,v retrieving revision 1.52 diff -u -r1.52 msipriv.h --- dlls/msi/msipriv.h

msi dialogs, events and office 2003

2005-05-26 Thread Aric Stewart
; typedef struct tagMSIPREVIEW --- /dev/null 2005-03-17 08:20:53.0 -0600 +++ dlls/msi/events.c 2005-05-26 10:31:14.0 -0500 @@ -0,0 +1,506 @@ +/* + * Implementation of the Microsoft Installer (msi.dll) + * + * Copyright 2005 Aric Stewart for CodeWeavers + * + * This library is free

Re: msi: source one off error correction

2005-07-11 Thread Aric Stewart
True, there shouldn't be because that string is of format char;int;path but i will work out some better error checking to handle garbage strings more gracefully. -aric Mike McCormack wrote: Aric Stewart wrote: rc = RegQueryValueExW(sourcekey

  1   2   3   >