Re: [Wireshark-dev] RRC filters

2012-09-27 Thread Pascal Quantin
2012/9/26 Anders Broman a.bro...@bredband.net Pascal Quantin skrev 2012-09-26 19:41: 2012/9/25 Lucio Di Giovannantonio lucio.digiovannanto...@gmail.com Hi pascal, thank you for your resply, maybe container could be better? Regards Lucio Hi Lucio, thanks for your suggestion, I

[Wireshark-dev] Building for Windows without zlib?

2012-09-27 Thread Martin Mathieson
Hi, At one stage, building without zlib support meant that opening/reading files was much faster than with. On this machine, the performance under Windows is much worse than under linux, so I wanted to try doing a windows build in this way. There are 2 places in config.nmake that let you

Re: [Wireshark-dev] [Wireshark-commits] rev 45116: /trunk/ /trunk/: Makefile.nmake config.nmake

2012-09-27 Thread Maynard, Chris
Ah yes, I guess we download the user-guide.zip as part of the setup because we don't currently require developers to have all the tools to build the documentation themselves. - Chris Ref: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2160 -Original Message- From:

Re: [Wireshark-dev] Building for Windows without zlib?

2012-09-27 Thread Jakub Zawadzki
Hi, On Thu, Sep 27, 2012 at 03:53:29PM +0100, Martin Mathieson wrote: At one stage, building without zlib support meant that opening/reading files was much faster than with. Old wiretap when you disable zlib was using fread() to read data. Right now we have our own I/O routines [copied from

Re: [Wireshark-dev] [Wireshark-commits] rev 45175: /trunk/epan/ /trunk/epan/: prefs.c

2012-09-27 Thread Guy Harris
On Sep 27, 2012, at 9:23 AM, ger...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=45175 User: gerald Date: 2012/09/27 09:23 AM Log: Don't pass a null pointer to strcmp. Is it ever possible that *pref-varp.string is null but value is non-null? If

Re: [Wireshark-dev] [Wireshark-commits] rev 45175: /trunk/epan/ /trunk/epan/: prefs.c

2012-09-27 Thread Jakub Zawadzki
On Thu, Sep 27, 2012 at 11:38:22AM -0700, Guy Harris wrote: On Sep 27, 2012, at 9:23 AM, ger...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=45175 User: gerald Date: 2012/09/27 09:23 AM Log: Don't pass a null pointer to strcmp. Is it

Re: [Wireshark-dev] [Wireshark-commits] rev 45175: /trunk/epan/ /trunk/epan/: prefs.c

2012-09-27 Thread Guy Harris
On Sep 27, 2012, at 12:11 PM, Jakub Zawadzki darkjames...@darkjames.pl wrote: To do it, we can use g_strcmp0: http://developer.gnome.org/glib/2.28/glib-String-Utility-Functions.html#g-strcmp0 Since 2.16, so we should then change the configure script to check for GLib 2.16 or later.

Re: [Wireshark-dev] Building for Windows without zlib?

2012-09-27 Thread Guy Harris
On Sep 27, 2012, at 7:53 AM, Martin Mathieson martin.r.mathie...@googlemail.com wrote: At one stage, building without zlib support meant that opening/reading files was much faster than with. As Jakub indicated, we used to use zlib's I/O routines to read capture files, meaning that both

Re: [Wireshark-dev] [Wireshark-commits] rev 45175: /trunk/epan/ /trunk/epan/: prefs.c

2012-09-27 Thread Jakub Zawadzki
On Thu, Sep 27, 2012 at 12:24:09PM -0700, Guy Harris wrote: On Sep 27, 2012, at 12:11 PM, Jakub Zawadzki darkjames...@darkjames.pl wrote: To do it, we can use g_strcmp0: http://developer.gnome.org/glib/2.28/glib-String-Utility-Functions.html#g-strcmp0 Since 2.16, so we should

Re: [Wireshark-dev] [Wireshark-commits] rev 45175: /trunk/epan/ /trunk/epan/: prefs.c

2012-09-27 Thread Guy Harris
On Sep 27, 2012, at 1:47 PM, Gerald Combs ger...@wireshark.org wrote: We're using it in trunk-1.8 too, even though we shouldn't (the minimum version of GLib there is 2.14). I switched to strcmp in r45180. ...and, in all of the cases in 1.8 (the ones in main_menubar.c), either tok has already