Re: [Wireshark-dev] Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c

2012-08-22 Thread Sylvain Munaut
Hi, From Pascal: GMR-1 dissectors, like GSM-A dissectors, can be seen either as separate protocols belonging to the same family, or as a single protocol with sub dissectors:it depends a bit on your point of view :) Personnally I see them as a single one (like Sylvain) and was rather happy

Re: [Wireshark-dev] Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c

2012-08-21 Thread Pascal Quantin
2012/8/20 mman...@netscape.net Sylvain, The checkdisplayfilter.pl script reflects my interpretation of the desired display filter format, and since there hasn't been that much feedback on the outputted results (with Pascal's comments on the GSM dissectors being the exception), I

Re: [Wireshark-dev] Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c

2012-08-21 Thread mmann78
Quantin pascal.quan...@gmail.com To: Developer support list for Wireshark wireshark-dev@wireshark.org Sent: Tue, Aug 21, 2012 5:21 pm Subject: Re: [Wireshark-dev] Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet

Re: [Wireshark-dev] Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c

2012-08-19 Thread Sylvain Munaut
Hi, I've just seen those changes (filter names) now and I'm really not happy with them ... 1) I explicitely asked this list for objections against the gmr1.xx vs gmr1_xx name and I was told that using gmr1.xx made sense given it's always the same protocol. And nobody expressed any view against

Re: [Wireshark-dev] Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c

2012-08-19 Thread Pascal Quantin
Le 19 août 2012 à 12:40, Sylvain Munaut 246...@gmail.com a écrit : Hi, I've just seen those changes (filter names) now and I'm really not happy with them ... 1) I explicitely asked this list for objections against the gmr1.xx vs gmr1_xx name and I was told that using gmr1.xx made sense

Re: [Wireshark-dev] Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c

2012-08-19 Thread Sylvain Munaut
Hi Pascal, If you check the mailing list archive you will see that I also raised this issue regarding filter names for protocols split across several files. See http://www.wireshark.org/lists/wireshark-dev/201207/msg00258.html for the mail exchange. Yes, I've seen this (I replied in the same

Re: [Wireshark-dev] Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c

2012-08-19 Thread mmann78
: Sun, Aug 19, 2012 3:17 pm Subject: Re: [Wireshark-dev] Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c I don't know all the protocols where this happens but to me having gmr1_rr.xxx

[Wireshark-dev] Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c

2012-07-31 Thread Pascal Quantin
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=44161 User: mmann Date: 2012/07/31 10:19 AM Log: update GMR-1 protocols display filers Directory: /trunk/epan/dissectors/ ChangesPathAction +67 -67packet-gmr1_bcch.c Modified +14 -14

Re: [Wireshark-dev] Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c

2012-07-31 Thread mmann78
for Wireshark wireshark-dev@wireshark.org Sent: Tue, Jul 31, 2012 3:07 pm Subject: [Wireshark-dev] Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c http://anonsvn.wireshark.org/viewvc/viewvc.cgi

Re: [Wireshark-dev] Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c

2012-07-31 Thread Pascal Quantin
2012/7/31 mman...@netscape.net I guess where I (and the .pl script) got tripped up was the fact that there were separate protocols registered and they gave the impression they were unique and not just one big protocol broken up over several files. The script just generates the questionable