Re: tarball types (was: [ANNOUNCE] xf86-input-libinput 1.2.1)

On Mon, Jan 24, 2022 at 03:53:23PM -0800, Alan Coopersmith wrote: > On 1/23/22 21:18, Peter Hutterer wrote: > > xf86-input-libinput 1.2.1 is now available. Primarily a few typos and misc > > minor fixes, the most visible change to distributions is that we now ship an > > xz tarball instead of bz2.

Re: Maintainer / Owner privileges at xf86-video-vmware

On Fri, Feb 22, 2019 at 13:28:34 +, Daniel Stone wrote: > Hi Thomas, > > On Fri, 22 Feb 2019 at 13:18, Thomas Hellstrom wrote: > > I was trying to add Deepak Rawat as a member on the xf86-video-vmware > > project on fdo gitlab. Turns out I have only developer privileges > > there. Could

Re: [PATCH xorgproto] Add DPMSInfoNotify event

On 10/02/2018 03:10 PM, Alexander Volkov wrote: > From: Alexander Volkov > > This allows applications to respond to changes of power level > of a monitor, e.g. an application may stop rendering and related > calculations when the monitor is off. > > Bump DPMS version to 1.2. > > Signed-off-by:

Re: [PATCH xcb] don't flag extra reply in xcb_take_socket

+xcb@ On 08/09/2018 12:20 AM, Erik Kurzinger wrote: > If any flags are specified in a call to xcb_take_socket, > they should only be applied to replies for requests sent > after that function returns (and until the socket is > re-acquired by XCB). > > Previously, they would also be incorrectly

Re: [PATCH app/xdm] Add missing brackets to multi-statement if in SaveServerAuthorizations

On Sat, May 5, 2018 at 12:33:12 -0700, Alan Coopersmith wrote: > Introduced by commit 5222d28e8d8e5b4cc > > Reported by gcc 7.3: > > auth.c: In function ‘SaveServerAuthorizations’: > auth.c:447:6: warning: this ‘if’ clause does not guard... > [-Wmisleading-indentation] > if

[PATCH xorgproto] Fix MAN_SUBSTS libdir replacement

__libdir__ doesn't seem to actually be used anywhere in the man page, but... Signed-off-by: Julien Cristau <jcris...@debian.org> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 8c1faf8..a58faca 100644 --- a/Makefile.am

Re: [PATCH xserver] present: cap the version returned to the client

On Mon, Mar 19, 2018 at 16:04:43 +, Emil Velikov wrote: > From: Emil Velikov > > As per the protocol, the server should not return version greater than > the one supported by the client. > > Add a spec quote and tweak the numbers accordingly. > > Fixes:

Re: [PATCH xcb/proto] screensaver: Use CARD32 encoding for ScreenSaverSuspend 'suspend'

I think this belongs on xcb@. Cheers, Julien On Mon, Mar 12, 2018 at 12:03:19 -0700, Keith Packard wrote: > This was set to BOOL, but the protocol headers used Bool, presumably a > 32-bit type. We're switching everything to CARD32 as the best option > for compatibility. > > Signed-off-by:

Re: [PATCH xserver 1/2] dix: Don't vary the ClientRec ABI at build time

On Tue, Oct 24, 2017 at 14:38:12 -0400, Adam Jackson wrote: > Just no. > > Signed-off-by: Adam Jackson <a...@redhat.com> > --- > include/dixstruct.h | 2 -- > 1 file changed, 2 deletions(-) > for the series: Reviewed-by: Julien Cristau <jcris.

Re: [PATCH app/bdftopcf] Import libXfont's BDF-to-PCF code

y: Adam Jackson <a...@redhat.com> Yes please. Acked-by: Julien Cristau <jcris...@debian.org> Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH libXrender 1/2] Avoid OOB write in XRenderQueryFilters

Anyone? This still looks wrong to me. Cheers, Julien On Sat, Jan 7, 2017 at 18:46:57 +0100, Julien Cristau wrote: > On Sun, Sep 25, 2016 at 22:50:45 +0200, Matthieu Herrb wrote: > > > From: Tobias Stoeckmann <tob...@stoeckmann.org> > > > > The memory for filter

Re: [PATCH xserver 1/2] shm, xwayland: prefer atomic close-on-exec without O_TMPFILE

On Fri, Jul 7, 2017 at 22:41:06 +0200, Jan Beich wrote: > Julien Cristau <jcris...@debian.org> writes: > > > On Fri, Jul 7, 2017 at 16:31:48 +0200, Jan Beich wrote: > >> - flags = fcntl(fd, F_GETFD); > >> +#ifndef HAVE_MKOSTEMP > >> + int flags =

Re: [PATCH xserver 1/2] shm, xwayland: prefer atomic close-on-exec without O_TMPFILE

On Fri, Jul 7, 2017 at 16:31:48 +0200, Jan Beich wrote: > > Signed-off-by: Jan Beich > --- > Xext/shm.c | 9 +++-- > configure.ac| 2 +- > include/dix-config.h.in | 3 +++ > 3 files changed, 11 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH libxshmfence] futex: unbreak build on FreeBSD 11.0+

On Fri, Jul 7, 2017 at 16:31:07 +0200, Jan Beich wrote: > From: Jung-uk Kim > Date: Tue, 15 Apr 2014 17:08:46 + > > In file included from src/xshmfence_alloc.c:27: > In file included from src/xshmfenceint.h:32: > src/xshmfence_futex.h:40:39: error: use of undeclared

Re: [PATCH xserver 2/2] meson: Fix CLOCK_MONOTONIC test

_data.set('_DIX_CONFIG_H_', '1') > >   > > + > > + > >  conf_data.set('MONOTONIC_CLOCK', cc.compiles(''' > > +#define _POSIX_C_SOURCE 200112L > >  #include > >  #include > >  #ifndef CLOCK_MONOTONIC > > Forgive the excess spaces.

[PATCH xserver 2/2] Replace all checks for 'linux' macro with '__linux__'

gcc -std=c99 does not define the former, and it's a horrible namespace confusion anyway. Signed-off-by: Julien Cristau <jcris...@debian.org> --- hw/xfree86/common/compiler.h | 14 +++--- hw/xfree86/common/xf86Config.c | 2 +- hw/xfree86/common/xf86Configure.c

[PATCH xserver 1/2] Drop workaround for pre-glibc linux

It seems unlikely anyone still needs to build against libc4/libc5. Signed-off-by: Julien Cristau <jcris...@debian.org> --- Xext/xf86bigfont.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/Xext/xf86bigfont.c b/Xext/xf86bigfont.c index 72bb774011..529595bb75 100644 ---

Re: [PATCH xserver 5/7] meson: Make XV optional

On Mon, May 8, 2017 at 10:13:52 -0700, Eric Anholt wrote: > Optional XV seems a bit silly to me. Could we just do something > like: > > build_xv = build_xorg || build_dmx || build_ephyr? FWIW the Xorg build we're shipping in debian installer images (which run a single specific gtk2 client)

Re: [PATCH app/xdpyinfo] Use XRANDR 1.2 extension for reporting dimensions and resolution per output

On Fri, May 5, 2017 at 10:08:14 +0200, Pali Rohár wrote: > PING. > > I would like to know if there is some problem with this and something > needs to be reworked or if it can be accepted. > > Currently xdpyinfo report bogus dimensions and resolution values and lot > of people complain about

Re: [PATCH xserver] vfb: Bump default depth to 24

On Mon, Feb 20, 2017 at 10:24:14 -0500, Adam Jackson wrote: > Signed-off-by: Adam Jackson <a...@redhat.com> > --- > hw/vfb/InitOutput.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Julien Cristau <jcris...@deb

Re: Xorg 1.19.1 SIGPIPE on application close

On 02/06/2017 03:32 PM, Antoine Martin wrote: > Hi, > > I can reproduce this Xorg server crash fairly reliably using xpra and > glxspheres simply by closing the application window: > > Thread 1 "Xorg" received signal SIGPIPE, Broken pipe. > 0x757ca83d in writev () at

Re: [PATCH libX11] _XDefaultError: set XlibDisplayIOError flag before calling exit

On Wed, Feb 1, 2017 at 15:02:41 +0100, arthur.huil...@free.fr wrote: > It is legal for an application to make Xlib calls during _fini, and that is > useful for an OpenGL driver to avoid resource leaks on the X server side, for > example in the dlopen/dlclose case. However, the driver can not

Re: [PATCH libXrandr] Avoid out of boundary accesses on illegal responses

On Sat, Jan 7, 2017 at 19:15:42 +0100, Tobias Stoeckmann wrote: > Hi Julien, > > On Sat, Jan 07, 2017 at 07:03:17PM +0100, Julien Cristau wrote: > > It looks like we're leaking 'attr' on these error paths? > > confirmed. That is what I get for copying the error handling

[ANNOUNCE] presentproto 1.1

and Pixmap to be CARD32 on the wire Alan Coopersmith (1): configure: Drop AM_MAINTAINER_MODE Emil Velikov (1): autogen.sh: use quoted string variables Gaetan Nadon (2): Add the required README file. config: replace deprecated use of AC_OUTPUT with AC_CONFIG_FILES Julien Cristau

[ANNOUNCE] presentproto 1.1

and Pixmap to be CARD32 on the wire Alan Coopersmith (1): configure: Drop AM_MAINTAINER_MODE Emil Velikov (1): autogen.sh: use quoted string variables Gaetan Nadon (2): Add the required README file. config: replace deprecated use of AC_OUTPUT with AC_CONFIG_FILES Julien Cristau

Re: libx11: Issues with Data32/_XData32

On Tue, Jan 24, 2017 at 01:12:23 +, James Clarke wrote: > Hi, > I've been debugging an issue in gtk2-perl causing it to SIGBUS on > sparc64, and traced it back to what seems to be dodgy code inside > libx11. One of the tests calls gdk_window_set_opacity, which calls > XChangeProperty with a

Re: [PATCH xserver 00/19] Module loader cleanup

es: Reviewed-by: Julien Cristau <jcris...@debian.org> Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 19/19] loader: Fix an obviously backwards comparison

On Mon, Jan 23, 2017 at 14:32:33 -0500, Adam Jackson wrote: > Hmm, this code looks wrong to me. I know! Instead of fix it, I'll put a > comment here that nobody will look at for decades on end. > > Yaaay xfree86. > > Signed-off-by: Adam Jackson > --- >

Re: [PATCH xserver 06/19] loader: Remove *GetOS

On Mon, Jan 23, 2017 at 14:32:20 -0500, Adam Jackson wrote: > This API is dumb. uname(3) exists, feel free to use it, but ideally > write to the interface not to the OS. There are a couple of drivers > using this API, they could all reasonably just not. > It's uname(2) AFAICT :) Cheers,

Re: [PATCH xserver 04/19] xfree86: flatten pathlist management in the loader

On Mon, Jan 23, 2017 at 14:32:18 -0500, Adam Jackson wrote: > From: Emil Velikov > > Now that used can set the path only via LoaderSetPath(), we can simplify > things. > used -> users, maybe? Cheers, Julien ___

Re: [PATCH xserver 01/19] xfree86: remove references from LoadSubModule's path from the doc

On Mon, Jan 23, 2017 at 14:32:15 -0500, Adam Jackson wrote: > From: Emil Velikov > > Afaics the argument hasn't been part of the API since the documentation > has been converted to xml with commit fc6ebe1e1d3 "Convert LinuxDoc > documents to DocBook/XML" > The commit

Re: [PATCH:xdm] Install xdm man pages under admin section (8), not user programs (1)

On Mon, Jan 16, 2017 at 16:26:08 -0800, Alan Coopersmith wrote: > As best I can tell, it was historically under section 1 mainly because > the old X Consortium Imake configs only supporting installing program > man pages there, and didn't have an option for using other sections. > >

Re: [PATCH libXrandr] Avoid out of boundary accesses on illegal responses

[resending with xorg-devel cc added which I forgot the first time around] On Sun, Sep 25, 2016 at 22:50:44 +0200, Matthieu Herrb wrote: > diff --git a/src/XrrCrtc.c b/src/XrrCrtc.c > index 5ae35c5..6665092 100644 > --- a/src/XrrCrtc.c > +++ b/src/XrrCrtc.c [...] > @@ -357,7 +378,7 @@

Re: [PATCH libXrender 1/2] Avoid OOB write in XRenderQueryFilters

On Sun, Sep 25, 2016 at 22:50:45 +0200, Matthieu Herrb wrote: > From: Tobias Stoeckmann > > The memory for filter names is reserved right after receiving the reply. > After that, filters are iterated and each individual filter name is > stored in that reserved memory. >

[PATCH libX11] Fix wrong Xfree in XListFonts failure path

'ch' gets moved inside the allocated buffer as we're looping through fonts, so keep a reference to the start of the buffer so we can pass that to Xfree in the failure case. Fixes: commit 20a3f99eba5001925b8b313da3accb7900eb1927 "Plug a memory leak" Signed-off-by: Julien Cris

Re: [PATCH libxi] Fix possible free of uninitialized pointer

gned-off-by: Emilio Pozuelo Monfort <po...@debian.org> > Reviewed-by: Julien Cristau <jcris...@debian.org> > Tested-by: Thomas Walker <thwalk...@gmail.com> > --- > src/XIQueryDevice.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > remote: Updating pat

[ANNOUNCE] xf86-video-dummy 0.3.8

): Honor DacSpeed setting in xorg.conf remove dead code in dummy driver Julien Cristau (2): configure: require xorg-server 1.4.99.901 xf86-video-dummy 0.3.8 Peter Hutterer (1): Switch to using dixChangeWindowProperty git tag: xf86-video-dummy-0.3.8 https

[ANNOUNCE] xf86-video-dummy 0.3.8

): Honor DacSpeed setting in xorg.conf remove dead code in dummy driver Julien Cristau (2): configure: require xorg-server 1.4.99.901 xf86-video-dummy 0.3.8 Peter Hutterer (1): Switch to using dixChangeWindowProperty git tag: xf86-video-dummy-0.3.8 https

Re: [PATCH xserver] ephyr: Leave window unmapped for -glamor-skip-present

On Wed, Oct 5, 2016 at 09:42:19 -0700, Keith Packard wrote: > If we're never painting anything in the window, we probably don't need > to map it. > > Signed-off-by: Keith Packard > --- > hw/kdrive/ephyr/hostx.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) >

Re: [PATCH libXi] Properly validate server responses.

On Sun, Sep 25, 2016 at 22:50:43 +0200, Matthieu Herrb wrote: > From: Tobias Stoeckmann > > By validating length fields from server responses, out of boundary > accesses and endless loops can be mitigated. > > Signed-off-by: Tobias Stoeckmann >

Re: [PATCH libX11 1/2] The validation of server responses avoids out of boundary accesses.

Hi all, Sorry I didn't get a chance to look at these before they went public... On Sun, Sep 25, 2016 at 22:50:40 +0200, Matthieu Herrb wrote: > From: Tobias Stoeckmann > > v2: FontNames.c return a NULL list whenever a single > length field from the server is incohent.

Re: [PATCH xserver 05/10 v2] test: Add a little xinit-like program for starting servers for testing.

On Fri, Sep 23, 2016 at 10:58:54 +0300, Eric Anholt wrote: > The normal xinit is racy because it doesn't use -displayfd. This > implements the bare minimum for testing purposes, using -displayfd to > sequence starting the client, and avoids adding yet another dependency > to the server. > > v2:

Re: [PATCH xbitmaps] Install pkgconfig file into arch-dependent location

On Thu, Sep 22, 2016 at 19:12:13 +0200, Heiko Becker wrote: > Signed-off-by: Heiko Becker > --- > Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile.am b/Makefile.am > index 060112d..9a89bbe 100644 > --- a/Makefile.am > +++

Re: [PATCH xserver 06/10] test: Make the piglit-running script callable with an arbitrary server.

On Thu, Sep 22, 2016 at 11:45:07 +0300, Eric Anholt wrote: > diff --git a/test/scripts/xvfb-piglit.sh b/test/scripts/run-piglit.sh > similarity index 90% > copy from test/scripts/xvfb-piglit.sh > copy to test/scripts/run-piglit.sh > index b775239e34f5..ab37ee3b92ad 100755 > ---

Re: [PATCH xserver 05/10] test: Add a little xinit-like program for starting servers for testing.

On Thu, Sep 22, 2016 at 11:45:06 +0300, Eric Anholt wrote: > +asprintf(_string, "%d", displayfd); > +if (!displayfd_string) > +exit(1); I think you need to check the return value from asprintf, not displayfd_string: When successful, these functions return the number of

Re: [PATCH util-modular 00/10] release.sh cleanups, mesa support and more

On Tue, Sep 20, 2016 at 01:03:33 +0100, Emil Velikov wrote: > On 15 September 2016 at 15:12, Julien Cristau <jcris...@debian.org> wrote: [...] > > For 1, 3, 4, 5, 7 (assuming 10 goes in in some way): > > Reviewed-by: Julien Cristau <jcris...@debian.org> > >

Re: [PATCH util-modular 00/10] release.sh cleanups, mesa support and more

opic to be an expert. > > As always, any and all comments, suggestions are appreciated. > For 1, 3, 4, 5, 7 (assuming 10 goes in in some way): Reviewed-by: Julien Cristau <jcris...@debian.org> Not a fan of 2 and 6. I don't have enough context to understand what 8 changes. 9 seems t

[PATCH util/modular 2/2] release.sh: use https for URLs in announcement

{xorg,dri,wayland,www}.freedesktop.org are all https now. Signed-off-by: Julien Cristau <jcris...@debian.org> --- release.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/release.sh b/release.sh index bb3f17a..6d5ac80 100755 --- a/release.sh +++ b/release.sh @@ -

[PATCH util/modular 1/2] release.sh: use canonical address for xorg mailing lists

Signed-off-by: Julien Cristau <jcris...@debian.org> --- release.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/release.sh b/release.sh index ef384de..bb3f17a 100755 --- a/release.sh +++ b/release.sh @@ -504,10 +504,10 @@ process_module() { host_w

Re: [PATCH xserver] config/dbus: Initialize dbus fd to -1 so teardown doesn't use fd 0

; > Signed-off-by: Keith Packard <kei...@keithp.com> > --- > config/dbus-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Julien Cristau <jcris...@debian.org> Cheers, Julien > diff --git a/config/dbus-core.c b/config/dbus-core.c > i

Re: [PATCH 2/3] Xext/shm: Better support cases where O_CLOEXEC is not defined

On Mon, Sep 12, 2016 at 10:53:39 -0700, Jeremy Huddleston Sequoia wrote: > > > On Sep 12, 2016, at 04:33, Julien Cristau <jcris...@debian.org> wrote: > > > > On Sun, Sep 11, 2016 at 20:01:50 -0700, Jeremy Huddleston Sequoia wrote: > > > >> Signe

Re: [PATCH 3/3] os/inputthread: Fix setting of cloexec on file descriptors

m> > --- > os/inputthread.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > A possible further improvement would be to use pipe2(2) where available to set O_CLOEXEC immediately, rather than as a separate step. Anyway, this gets my Reviewed-by: Julien Cristau <

Re: [PATCH 2/3] Xext/shm: Better support cases where O_CLOEXEC is not defined

On Sun, Sep 11, 2016 at 20:01:50 -0700, Jeremy Huddleston Sequoia wrote: > Signed-off-by: Jeremy Huddleston Sequoia > --- > Xext/shm.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > Does anything have O_TMPFILE but not O_CLOEXEC? Cheers, Julien > diff

Re: [PATCH 1/3] Xext/shm: Fix usage of F_GETFD to match standard

Jeremy Huddleston Sequoia <jerem...@apple.com> > --- > Xext/shm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Julien Cristau <jcris...@debian.org> Cheers, Julien > diff --git a/Xext/shm.c b/Xext/shm.c > index 0557538..125000f 100644 > --- a

Re: [PATCH xserver] test: Remember to swap the window argument to XIQueryPointer

l-xiquerypointer.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Julien Cristau <jcris...@debian.org> Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH util-modular] release.sh: add --gpgkey option

On Tue, Jul 19, 2016 at 15:27:02 +0100, Emil Velikov wrote: > From: Emil Velikov > > To allow users with multiple keys to select the appropriate one. > > Signed-off-by: Emil Velikov > --- > All the "if x$GPGKEY = x" checking looks iffy

Re: [PATCH xserver] linux: Do not try to open /dev/vc/0, fix error msg when /dev/tty0 open fails

gt; display the actual error, rather then the -ENOENT from also trying > /dev/vc/0. > > BugLink: https://patchwork.freedesktop.org/patch/8768/ > Reported-by: Chad Versace <chad.vers...@linux.intel.com> > Suggested-by: Julien Cristau <jcris...@debian.org> > Signed-off

Re: [PATCH xserver] xkb: add a cause to the xkb indicator update after a keymap change

who-t.net> > --- > xkb/xkb.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Going to the pub seems like a great plan. Reviewed-by: Julien Cristau <jcris...@debian.org> Cheers, Julien ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH xf86-input-libinput] Switch to xf86AddEnabledDevice if we have the input thread

On Mon, May 30, 2016 at 18:12:36 +1000, Peter Hutterer wrote: > Pre input-thread xf86AddEnabledDevice was hooked up to the signal handler. > libinput never was capable of running inside a signal handler, so we had to > use AddEnabledDevice() instead which merely hooks to the server's select loop.

Re: [PATCH xserver 17/23] os: Add ospoll interface

On Sun, May 29, 2016 at 11:35:16 -0700, Keith Packard wrote: > Emil Velikov writes: > > > There's two things which I should have mentioned: > > - How does one have poll.h when poll() is missing - Cygwin may have > > the header, although I'm not sure about other

[ANNOUNCE] xproto 7.0.29

Alan Coopersmith (1): Incorrect guard block in HPkeysym.h James Clarke (1): Don't let XFD_SETSIZE exceed FD_SETSIZE Julien Cristau (1): xproto 7.0.29 Olivier Fourdan (1): Raise the number of FD on WIN32 as well git tag: xproto-7.0.29 http://xorg.freedesktop.org/archive

[ANNOUNCE] xproto 7.0.29

Alan Coopersmith (1): Incorrect guard block in HPkeysym.h James Clarke (1): Don't let XFD_SETSIZE exceed FD_SETSIZE Julien Cristau (1): xproto 7.0.29 Olivier Fourdan (1): Raise the number of FD on WIN32 as well git tag: xproto-7.0.29 http://xorg.freedesktop.org/archive

Re: [PATCH libICE] Bump the major version

On Thu, May 12, 2016 at 14:27:48 +0100, Emil Velikov wrote: > With previous commits we've hidden a selection of internal symbols from > the DSO. Neither of them has been part of the API, although let's do the > sane thing and bump the major, as we might have changed things in a > backward

Re: [PATCH xserver] Xmir DDX

On Fri, Apr 29, 2016 at 15:25:40 +, Robert Ancell wrote: > On Fri, Apr 29, 2016 at 4:47 PM Adam Jackson wrote: > > > On Fri, 2016-04-29 at 11:11 +0200, Robert Ancell wrote: > > > This is currently used in Ubuntu to allow X applications and sessions to > > run in > > > newer

Re: [PATCH xserver 2/2] kdrive: Nuke a bunch of dead code

On Fri, Apr 29, 2016 at 11:16:08 -0400, Adam Jackson wrote: > On Fri, 2016-04-29 at 17:01 +0200, Julien Cristau wrote: > > On Fri, Apr 29, 2016 at 10:53:22 -0400, Adam Jackson wrote: > > > > > gcc6 says: > > > > > > keyboard.c:46:21: warning: ‘linux_to

Re: [PATCH xserver 2/2] kdrive: Nuke a bunch of dead code

t; > --- > hw/kdrive/linux/keyboard.c | 441 > - > 1 file changed, 441 deletions(-) > Reviewed-by: Julien Cristau <jcris...@debian.org> Cheers, Julien ___ xorg-devel@lists.x.org: X.Org develo

Re: [PATCH xserver] prime: clean up slave bo properly. (v2)

On Fri, Apr 29, 2016 at 15:54:28 +1000, Dave Airlie wrote: > This is an ABI break, in that we now pass NULL to a function > that hasn't accepted it before. > > Alex Goins had a different patch for this but it wasn't symmetrical, > it freed something in a very different place than it allocated

Re: [PATCH xserver] XDMCP: For IPv6 add IPv6 link local addresses to the end of the list

On Thu, Apr 28, 2016 at 15:21:15 +0200, Stefan Dirsch wrote: > From: Reinhard Max > > For IPv6 add a link local addresses to the end of the list passed to > the XDMCP servers. > Reason: for link local addresses the XDMCP server would need to either > know the interface thru a

Re: [PATCH xserver] ad hoc fix for mmap's truncated offset parameter on 32bit

On Thu, Apr 28, 2016 at 16:10:01 +0200, Mark Kettenis wrote: > > From: Stefan Dirsch > > Date: Thu, 28 Apr 2016 14:35:00 +0200 > > > > Builtin modesetting driver didn't work on 32bit on cirrus KMS. See > > https://bugzilla.suse.com/show_bug.cgi?id=917385 for more details. > >

Bug#822868: System with AMD A6-7400K Radeon R5 with display errors (Pepper Flash, VLC Video)

On Thu, Apr 28, 2016 at 16:56:07 +0200, Patrick Frank wrote: > Package: xserver-xorg-video-radeon > Version: 1:7.5.0-1 > Severity: normal > You're not actually using that driver... > DRM Information from dmesg: > --- > [0.00] AGP: No AGP bridge found > [

Re: [PATCH] uxa: fix missing includes for fstat

On Thu, Apr 28, 2016 at 11:06:38 +0200, Stefan Dirsch wrote: > On Wed, Apr 27, 2016 at 11:23:10PM +0100, Emil Velikov wrote: > > P.S. For xorg-devel patches please set the correct prefix $ git config > > --local format.subjectPrefix "PATCH foo". With foo being the > > respective project. > > Ok.

Bug#822225: xserver-xorg-video-radeon: White glow and flicker on edges of LVDS display on boot

Control: reassign -1 src:linux 4.4.6-1~bpo8+1 On Thu, Apr 28, 2016 at 12:26:04 +0900, Michel Dänzer wrote: > On 22.04.2016 17:17, thomas wrote: > > Package: xserver-xorg-video-radeon > > Version: 1:7.7.0-1 > > Severity: normal > > > > Dear Maintainer, > > > >* What led up to the situation?

Re: [PATCH cirrus 1/2] Remove (almost) no-op setup functions

bmodule load. > > Signed-off-by: Adam Jackson <a...@redhat.com> > --- > src/alp_driver.c | 14 +- > src/lg_driver.c | 15 +-- > 2 files changed, 2 insertions(+), 27 deletions(-) > Reviewed-by: Julien Cristau <jcris...@d

Re: [PATCH] Avoid 10x7 heuristic, handled by server

On Tue, Apr 26, 2016 at 14:09:24 +0200, Stefan Dirsch wrote: > On Tue, Apr 26, 2016 at 12:58:55PM +0200, Julien Cristau wrote: > > On Tue, Apr 26, 2016 at 11:45:15 +0200, Stefan Dirsch wrote: > > > > > From: Frederic Crozat <fcro...@suse.com> > > >

Re: [PATCH] Avoid 10x7 heuristic, handled by server

On Tue, Apr 26, 2016 at 11:45:15 +0200, Stefan Dirsch wrote: > From: Frederic Crozat > > Remove the 10x7 heuristic, since the server has equivalent code now. > Instead, disable "acceleration" under qemu, since taking the hypercall > trap is really quite expensive and you're

Re: [PATCH xproto v2] Don't let XFD_SETSIZE exceed FD_SETSIZE

mes Clarke <jrt...@jrtc27.com> > --- > Changes since v1: > * Added Signed-off-by > * Added xproto component to subject prefix > > Xpoll.h.in | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > Reviewed-by: Julien

Re: [PATCH] libpciaccess/vgaarb: add function to get default vga device and it's decodes.

On Thu, Apr 21, 2016 at 15:22:36 +0200, Stefan Dirsch wrote: > From: Egbert Eich > > Reenable default device when shutting down VGA arbitration. > https://bugzilla.opensuse.org/show_bug.cgi?id=714677 > --- > src/common_vgaarb.c | 9 + > 1 file changed, 9

Re: [PATCH xserver] Search for DRI drivers at LIBGL_DRIVERS_PATH environment variable.

On Tue, Apr 12, 2016 at 19:59:14 +0200, Carlos Alberto Lopez Perez wrote: > * The Mesa driver uses this environment variable to override the > default compiled search path for DRI drivers. > > * This is useful for testing purposes when the user needs to > override the system default

Re: [PATCH xserver 1/4] glx: Macroize building the attribute list in DoGetDrawableAttributes

On Thu, Mar 10, 2016 at 13:25:03 -0500, Adam Jackson wrote: > No functional change, just a little easier to read and harder to get > wrong. > > Signed-off-by: Adam Jackson > --- > glx/glxcmds.c | 38 +++--- > 1 file changed, 15 insertions(+), 23

Re: [PATCH xserver] xwayland: Correctly detect whether posix_fallocate exists

onas Ådahl <jad...@gmail.com> > --- > configure.ac | 3 ++- > hw/xwayland/xwayland-shm.c | 4 > include/dix-config.h.in| 3 +++ > 3 files changed, 9 insertions(+), 1 deletion(-) > Reviewed-by: Julien Cristau <jcris...@debian.org> Cheers, Julien ___

Re: [PATCH xserver 2/2] xwayland: Correctly detect whether posix_fallocate exists

On Tue, Mar 8, 2016 at 18:32:27 +0800, Jonas Ådahl wrote: > On Tue, Feb 23, 2016 at 08:54:47AM +0800, Jonas Ådahl wrote: > > On Fri, Feb 19, 2016 at 11:53:46AM +0100, Julien Cristau wrote: > > > On Fri, Feb 19, 2016 at 15:08:13 +0800, Jonas Ådahl wrote: > > > > >

Re: [PATCH xserver 1/9] xvmc: Fix unchecked AddResource

On Tue, Mar 8, 2016 at 09:12:34 +0100, walter harms wrote: > > > Am 07.03.2016 23:20, schrieb Julien Cristau: > > Signed-off-by: Julien Cristau <jcris...@debian.org> > > --- > > Xext/xvmc.c | 17 ++--- > > 1 file changed, 14 insertions(+), 3

[PATCH xserver 3/9] glx: don't call pGlxDraw->destroy() if AddResource fails

AddResource will have called DrawableGone, which takes care of the destruction. Signed-off-by: Julien Cristau <jcris...@debian.org> --- glx/glxcmds.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/glx/glxcmds.c b/glx/glxcmds.c index 0416dac..6eb3541 100644 ---

[PATCH xserver 0/9] double frees in AddResource failure paths

unchecked AddResource calls in xvmc and dri3. Cheers, Julien Julien Cristau (9): xvmc: Fix unchecked AddResource dri3: return an error if AddResource fails glx: don't call pGlxDraw->destroy() if AddResource fails dmx/glxProxy: don't free the glx pixmap twice if AddResource fa

[PATCH xserver 6/9] xwin: no need to free auth data if AddResource fails

This is taken care of by SecurityDeleteAuthorization Signed-off-by: Julien Cristau <jcris...@debian.org> --- hw/xwin/winauth.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/hw/xwin/winauth.c b/hw/xwin/winauth.c index 7efa1c0..7be7dca 100644 --- a/h

[PATCH xserver 4/9] dmx/glxProxy: don't free the glx pixmap twice if AddResource fails

Signed-off-by: Julien Cristau <jcris...@debian.org> --- hw/dmx/glxProxy/glxcmds.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/dmx/glxProxy/glxcmds.c b/hw/dmx/glxProxy/glxcmds.c index ddcb981..a77d556 100644 --- a/hw/dmx/glxProxy/glxcmds.c +++ b/hw/dmx/gl

[PATCH xserver 2/9] dri3: return an error if AddResource fails

Signed-off-by: Julien Cristau <jcris...@debian.org> --- dri3/dri3_request.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri3/dri3_request.c b/dri3/dri3_request.c index 2b36221..35548b6 100644 --- a/dri3/dri3_request.c +++ b/dri3/dri3_request.c @@ -178,8

[PATCH xserver 7/9] record: don't call RecordDeleteContext when AddResource fails

Signed-off-by: Julien Cristau <jcris...@debian.org> --- record/record.c | 1 - 1 file changed, 1 deletion(-) diff --git a/record/record.c b/record/record.c index 1caf3f1..82bb060 100644 --- a/record/record.c +++ b/record/record.c @@ -1878,7 +1878,6 @@ ProcRecordCreateContext(ClientPtr

[PATCH xserver 8/9] render: free already allocated formats in PictureInit failure case

Probably pointless, if this fails you're not likely to get far... Signed-off-by: Julien Cristau <jcris...@debian.org> --- render/picture.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/render/picture.c b/render/picture.c index 6d9c9df..9e4036e 100644 --- a/render/picture.c +++ b/

[PATCH xserver 9/9] xfixes: avoid double free if AddResource fails

pChc is already freed through CursorFreeHideCount → deleteCursorHideCount. Signed-off-by: Julien Cristau <jcris...@debian.org> --- xfixes/cursor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/xfixes/cursor.c b/xfixes/cursor.c index 5619aad..10f9b23 100644 --- a/

[PATCH xserver 1/9] xvmc: Fix unchecked AddResource

Signed-off-by: Julien Cristau <jcris...@debian.org> --- Xext/xvmc.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/Xext/xvmc.c b/Xext/xvmc.c index 64eda92..7565c17 100644 --- a/Xext/xvmc.c +++ b/Xext/xvmc.c @@ -253,6 +253,10 @@ ProcXvMCCreateC

[PATCH xserver 5/9] modesetting: avoid double free if AddResource fails

ms_dri2_frame_event_client_gone or ms_dri2_frame_event_drawable_gone already free the resource. Signed-off-by: Julien Cristau <jcris...@debian.org> --- hw/xfree86/drivers/modesetting/dri2.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/xfree86/drivers/modesettin

[PATCH] xv: fix double free in AddResource failure case

XvdiDestroyVideoNotifyList already frees the list if AddResource fails, so don't do it twice. And set tpn->client to NULL explicitly to avoid confusing uninitialized memory with a valid value. Signed-off-by: Julien Cristau <jcris...@debian.org> --- Xext/xvmain.c | 5 ++--- 1 file c

Re: [PATCH xserver 2/5] dri1: Fix unchecked AddResource

dAlloc, but meh, dri1. for the series (1/5 and 2/5): Reviewed-by: Julien Cristau <jcris...@debian.org> Cheers, Julien > diff --git a/hw/xfree86/dri/dri.c b/hw/xfree86/dri/dri.c > index 875c9cc..0046e52 100644 > --- a/hw/xfree86/dri/dri.c > +++ b/hw/xfree86/dri/dri.c > @@ -1032,7 +10

Re: [PATCH xserver 2/2] xwayland: Correctly detect whether posix_fallocate exists

On Fri, Feb 19, 2016 at 15:08:13 +0800, Jonas Ådahl wrote: > We had HAVE_POSIX_FALLOCATE checks, but no such macros were ever > defined anywhere. This commit makes it so that this macro is defined if > the posix_fallocate is detected during configure. > > Signed-off-by: Jonas Ådahl

Re: [PATCH kdrive/ephyr v7 5/9] kdrive: add options to set default XKB properties

On Tue, Feb 9, 2016 at 14:23:59 +1000, Peter Hutterer wrote: > On Mon, Feb 08, 2016 at 10:00:21PM -0200, Laércio de Sousa wrote: > > Em 8 de fev de 2016 17:54, "Adam Jackson" escreveu: > > > How are you in a scenario where you can pass these values to Xephyr on > > > the command

Re: [PATCH macros v2] Fix XORG_WITH_XMLTO to work with xmlto >= 0.0.27

On Wed, Jan 13, 2016 at 19:51:55 -0500, Gaetan Nadon wrote: > On 16-01-12 07:59 AM, Andreas Boll wrote: > > Starting with xmlto version 0.0.27 the return code of > > xmlto --skip-validation txt conftest.xml > > is non-zero if conftest.xml is an empty file. > > [...] > > > > xorg-macros.m4.in |

Re: [PATCH libX11-xcb] add XCBGetXDisplay

On Fri, Jan 1, 2016 at 11:39:32 -0800, Alan Coopersmith wrote: > Did we ever reach a conclusion on this patch? I was thinking of doing a > libX11 release sometime early this year, and if this is ready to include, > would pull it in. > > (Is http://patchwork.freedesktop.org/patch/50613/ the

Re: [PATCH xserver 4/8] Create a threaded mechanism for input [v3]

On Thu, Dec 10, 2015 at 11:42:36 -0800, Keith Packard wrote: > Mark Kettenis writes: > > > Ugh. Exporting global variables as part of the ABI is generally not > > such a good idea. Perhaps it is better to use functions to acquire > > and release the input mutex

Re: [PATCH v2] xwayland: Do set root clip with rootless

On Sat, Nov 21, 2015 at 14:43:47 +0100, Olivier Fourdan wrote: > diff --git a/hw/xwayland/xwayland-glamor.c b/hw/xwayland/xwayland-glamor.c > index ebaf05a..16d1ab9 100644 > --- a/hw/xwayland/xwayland-glamor.c > +++ b/hw/xwayland/xwayland-glamor.c > @@ -233,9 +233,11 @@

  1   2   3   4   5   6   7   8   9   10   >