Jeremy,
Please help to review the following patch which is to address the spacing
problem in
Latest glamor code. Thanks.
Signed-off-by: Zhigang Gong zhigang.g...@linux.intel.com
---
hw/xfree86/dixmods/Makefile.am |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git
EvdevBitIsSet(array, KEY_A):array[0] (1 30)
BitIsOn(ptr, KEY_A):((BYTE*)ptr)[3] (1 6)
That is true on little-endian. Big-endian machines have that byte in position
0, so that one would need to be ((BYTE*)ptr)[0] (1 6).
Another simpler example:
long a = 0x04030201;
So the tdfx driver has this hunk of code in it currently does the following:
#if USE_PCIVGAIO
hwp-PIOOffset = pTDFX-PIOBase[0] - 0x300;
#endif
Can someone please explain to me why it's doing that?
___
xorg-devel@lists.x.org: X.Org development
This partially reverts b3d56d06ef840bbbe16ec3c37e170078b7f98b04 to allow
driver developers time to adjust.
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
The commit that deprecated the PCITAG type had these leftovers that I didn't
mean to get rid of just yet.
-Original Message-
From: xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org
[mailto:xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org] On
Behalf Of Jeremy Huddleston
Sent: Wednesday, October 19, 2011 12:09 AM
To: Zhigang Gong
Cc: xorg-devel@lists.x.org
Subject:
Hello,
On Wed, 19 Oct 2011 00:53:55 -0700
Jeremy Huddleston jerem...@apple.com wrote:
So the tdfx driver has this hunk of code in it currently does the following:
#if USE_PCIVGAIO
hwp-PIOOffset = pTDFX-PIOBase[0] - 0x300;
#endif
Can someone please explain to me why it's doing that?
Hi Michael,
Debian just switched to a version containing this patch in sid.
This prevents autoloading vboxmouse driver as the corresponding device
is in
subsystem misc. Adding matches for misc enables autoloading again.
As of VirtualBox 4.1.4 the Guest Additions use a kernel input driver for
The first patch is a rewrite of ajax's original patch taking Jamey's
comments into a/c. I'd appreciate a logic review to make sure its doing
the what I think it is.
The following four patches are just some of the fixes from an internal coverity
run done by Red Hat.
Dave.
From: Adam Jackson a...@redhat.com
So on RHEL5 anaconda sets an xorg.conf with a fixed 800x600 mode in it,
we run radeonfb and fbdev since ati won't work in userspace due to domain
issues in the older codebase.
On certain pseries blades the built-in KVM can't accept an 800x600-43 mode,
it
From: Dave Airlie airl...@redhat.com
Initialise the pAttr-values to NULL so if the values allocation
fails it just ends up as free(NULL).
Pointed out by coverity.
Signed-off-by: Dave Airlie airl...@redhat.com
---
Xext/saver.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff
From: Dave Airlie airl...@redhat.com
This code had an off-by-one and would allow writing one past the end of
the callbacks array.
Pointed out by coverity.
Signed-off-by: Dave Airlie airl...@redhat.com
---
Xi/extinit.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git
From: Dave Airlie airl...@redhat.com
this code wasn't allocating enough space and was assigning the NULL
one past the end.
Pointed out by coverity.
Signed-off-by: Dave Airlie airl...@redhat.com
---
hw/kdrive/src/kinput.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
From: Dave Airlie airl...@redhat.com
If the pGCPriv-flags == 2, then we try to assign the freed pGCPriv-XAAOps
avoid this by clearing the flags in to be destroyed pGCPriv.
Reported by coverity.
Signed-off-by: Dave Airlie airl...@redhat.com
---
hw/xfree86/xaa/xaaGC.c |1 +
1 files changed,
Reviewed-by: Jamey Sharp ja...@minilop.net
I haven't tested it, nor do I have mind-reading powers, but I think
this logic means what you think it means. Thanks for the revisions.
Jamey
On 10/19/11, Dave Airlie airl...@gmail.com wrote:
From: Adam Jackson a...@redhat.com
So on RHEL5 anaconda
On 10/19/11 09:01, Dave Airlie wrote:
From: Dave Airlieairl...@redhat.com
Initialise the pAttr-values to NULL so if the values allocation
fails it just ends up as free(NULL).
Pointed out by coverity.
Signed-off-by: Dave Airlieairl...@redhat.com
---
Xext/saver.c |1 +
1 files changed, 1
Reviewed-by: Jeremy Huddleston jerem...@apple.com
Looks good, but style-wise, I liked the mode = pScrn-monitor-Modes where it
was before ... meh
On Oct 19, 2011, at 9:01 AM, Dave Airlie wrote:
From: Adam Jackson a...@redhat.com
So on RHEL5 anaconda sets an xorg.conf with a fixed 800x600
I actually prefer Alan's suggestion, so with his version:
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 19, 2011, at 9:51 AM, Alan Coopersmith wrote:
On 10/19/11 09:01, Dave Airlie wrote:
From: Dave Airlieairl...@redhat.com
Initialise the pAttr-values to NULL so if the values
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 19, 2011, at 9:01 AM, Dave Airlie wrote:
From: Dave Airlie airl...@redhat.com
This code had an off-by-one and would allow writing one past the end of
the callbacks array.
Pointed out by coverity.
Signed-off-by: Dave Airlie
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 19, 2011, at 9:01 AM, Dave Airlie wrote:
From: Dave Airlie airl...@redhat.com
this code wasn't allocating enough space and was assigning the NULL
one past the end.
Pointed out by coverity.
Signed-off-by: Dave Airlie
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Oct 19, 2011, at 9:01 AM, Dave Airlie wrote:
From: Dave Airlie airl...@redhat.com
If the pGCPriv-flags == 2, then we try to assign the freed pGCPriv-XAAOps
avoid this by clearing the flags in to be destroyed pGCPriv.
Reported by
Actually, I retract this. I didn't intend to do it originally, but now that
it's done, meh.
I think we coddled the drivers enough with the current set of
just-deprecations. This is too trivial. I'll just go through and make sure
nobody is actually using it because drivers still build
On Oct 18, 2011, at 10:03 PM, Peter Hutterer wrote:
On Mon, Oct 17, 2011 at 11:59:38PM -0700, Jeremy Huddleston wrote:
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
The comments only really make sense wrt the mieq changes that I have
pending, but the test should work
On Oct 19, 2011, at 1:02 AM, Zhigang Gong wrote:
For
the client
side application, cairo is a good 2D libraries to utilize GPU hardware
acceleration.
I'm not familiar with spice. Just googled it, and it seems that it's a
protocol to offload
some CPU/GPU intensive tasks to remote client. I
The following changes since commit c8413362049cee8c30e0a9d67f78f9ebefe8e71f:
Merge remote-tracking branch 'herrb/master' (2011-10-18 07:45:24 -0700)
are available in the git repository at:
git://gitorious.org/vsyrjala/xserver.git composite_borderclip
Ville Syrjala (1):
composite:
On 10/19/11 09:01, Dave Airlie wrote:
From: Dave Airlieairl...@redhat.com
this code wasn't allocating enough space and was assigning the NULL
one past the end.
Pointed out by coverity.
Signed-off-by: Dave Airlieairl...@redhat.com
---
hw/kdrive/src/kinput.c |2 +-
1 files changed, 1
tam_key = (strchr(string, '=') - string);
-newopt-key = (char *)malloc(tam_key);
+newopt-key = (char *)malloc(tam_key + 1);
strncpy(newopt-key, string, tam_key);
newopt-key[tam_key] = '\0';
newopt-value = strdup(strchr(string, '=') + 1);
On Sun, 09 Oct 2011 03:06:41 -0700, Jeremy Huddleston jerem...@apple.com
wrote:
Adam Jackson (15):
xfree86: Move xf86GetClocks to vgahw
int10: Port to pciaccess' legacy IO API
vgahw: Remove IO domain setup
vgahw: Don't default to standard (port space) access routines
On Mon, 17 Oct 2011 15:08:14 -0400, Gaetan Nadon mems...@videotron.ca wrote:
Spaces or tabs do not affect the text output layout.
This, and the previous patch are merged.
c841336..e4787ec master - master
--
keith.pack...@intel.com
pgpBngpX0UBEe.pgp
Description: PGP signature
On Sun, 9 Oct 2011 01:11:04 +0300, Ville Syrjala syrj...@sci.fi wrote:
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=22566
Merged.
e4787ec..a5266dc master - master
--
keith.pack...@intel.com
pgpByPylmj2wk.pgp
Description: PGP signature
On Tue, 18 Oct 2011 16:25:01 +1000, Peter Hutterer peter.hutte...@who-t.net
wrote:
Peter Hutterer (2):
dix: add valuator_mask_fetch_double()
dix: mark motion events as emulated if we're scrolling from button press
Tomáš Trnka (1):
Fix drain_console unregistration
ptrveloc.c: In function 'QueryTrackers':
ptrveloc.c:598:34: warning: variable 'used_offset' set but not used
[-Wunused-but-set-variable]
used_offset is used, but only in the debugging code. Move the #if statement
to ignore that warning.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Only use one init path for input devices - through NIDR.
This requires that inp_driver and inp_identifier from the
XF86ConfInputRec are copied over into the options for NIDR to see them.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
hw/xfree86/common/xf86Config.c |8
On 10/19/11 20:05, Peter Hutterer wrote:
The former strdups for us. If the strdup fails we miss out on the
CorePointer option (default on anyway) and we're likely to fall over soon
anyway, so let's pretend this is the same behaviour.
Signed-off-by: Peter Huttererpeter.hutte...@who-t.net
---
On 10/19/11 20:05, Peter Hutterer wrote:
Signed-off-by: Peter Huttererpeter.hutte...@who-t.net
---
hw/xfree86/common/xf86Option.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/xfree86/common/xf86Option.c b/hw/xfree86/common/xf86Option.c
index 1a1f42a..9c52878
On 10/19/11 20:05, Peter Hutterer wrote:
ptrveloc.c: In function 'QueryTrackers':
ptrveloc.c:598:34: warning: variable 'used_offset' set but not used
[-Wunused-but-set-variable]
used_offset is used, but only in the debugging code. Move the #if statement
to ignore that warning.
Signed-off-by:
On Oct 19, 2011, at 17:19, Keith Packard wrote:
Note that the intel driver does not build with this change; the ancient
i810/i815 bits rely on the old IOADDRESS apis.
Yeah, you can probably do changes similar to the ones I made in other drivers
to just restrict support to one PCI domain for
36 matches
Mail list logo
