Re: [PATCH xorg-server] Fix xf86EdidModes.c: array subscript is above array bounds

2012-07-06 Thread Torsten Kaiser
On Fri, Jul 6, 2012 at 2:45 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Jul 05, 2012 at 04:37:39PM -0700, Keith Packard wrote: Torsten Kaiser just.for.l...@googlemail.com writes: With this optimization level gcc notices, that the loop in function DDCModesFromEstIII() would go

Re: [PATCH xorg-server] Fix xf86EdidModes.c: array subscript is above array bounds

2012-07-06 Thread Keith Packard
Torsten Kaiser just.for.l...@googlemail.com writes: My guess would be, that these bits where reserved in the spec and should never been set. These bits come from external sources, and often buggy ones at that. We should probably just compute the index and skip it if it's out of range. Sending

pull req one

2012-07-06 Thread Dave Airlie
Hi Keith, This bunch of patches has all r-bs in place so I may as well get rid of it!! This adds the udev probing and all the gpu screen bits up to before the randr protocol. I'll probably send another pull-req for stage 2, up to the output slave stuff, then stage 3 up to the offload slave

pull request: output slave

2012-07-06 Thread Dave Airlie
This depends on the previous pull req and contains all the patches in it. The pull below is from the top of that tree. This is all the randr changes + output slave additions. The following changes since commit 74b786f7cee5723468bba251a2155a65770b2ad4: xfree86: add autoAddGPU option (v2)

pull request : offload slave

2012-07-06 Thread Dave Airlie
This builds on the two previous pull requests. Not fully reviewed, but its had a few users, and ickle has looked over it a couple of times and bitched at me ;-) This relies on an unpushed dri2proto change, since krh is no longer in X land, and jbarnes is playing video games, I'm going to push it

[PATCH] dri2proto: add prime protocol support.

2012-07-06 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com So we reserve bits 16-24 for offload device ids, this means we can have 7 offload devices, which is plenty for now, and we can bump this further later without fear. (original commit message has wrong numbers, thanks to MrCooper). Signed-off-by: Dave Airlie

[PATCH] dri2proto: add prime protocol support. (v2)

2012-07-06 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com So we reserve bits 16-19 for offload device ids, this means we can have 6 offload devices, which is plenty for now, and we can bump this further later without fear. v2: I suck at maths, that is all. Fixed up the maths to match reality. Signed-off-by: Dave

[PATCH] dri2proto: add prime protocol support. (v2.1)

2012-07-06 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com So we reserve bits 16-19 for offload device ids, this means we can have 6 offload devices, which is plenty for now, and we can bump this further later without fear. v2: I suck at maths, that is all. Fixed up the maths to match reality. v2.1: fix typo

Re: [PATCH] dri2proto: add prime protocol support. (v2.1)

2012-07-06 Thread Michel Dänzer
On Fre, 2012-07-06 at 11:27 +0100, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com So we reserve bits 16-19 for offload device ids, this means we can have 6 offload devices, which is plenty for now, and we can bump this further later without fear. v2: I suck at maths, that is

Re: [PATCH] Add EXA support

2012-07-06 Thread Michel Dänzer
On Don, 2012-07-05 at 17:51 -0700, Connor Behan wrote: For real this time. This allows the r128 driver to continue having 2D That this patch is for the r128 driver should be mentioned on the subject line (even if it was submitted to the xorg-driver-ati list :), e.g. as '[PATCH xf86-video-r128]

Re: [PATCH] dri2proto: add prime protocol support. (v2.1)

2012-07-06 Thread Kristian Høgsberg
On Fri, Jul 6, 2012 at 6:27 AM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com So we reserve bits 16-19 for offload device ids, this means we can have 6 offload devices, which is plenty for now, and we can bump this further later without fear. v2: I suck at maths,

Re: [PATCH] dri2proto: add prime protocol support. (v2.1)

2012-07-06 Thread Dave Airlie
On Fri, Jul 6, 2012 at 2:32 PM, Kristian Høgsberg k...@bitplanet.net wrote: On Fri, Jul 6, 2012 at 6:27 AM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com So we reserve bits 16-19 for offload device ids, this means we can have 6 offload devices, which is plenty for

Re: [PATCH] glx: Pass GLX drawable ID to DRI2CreateDrawable().

2012-07-06 Thread Kristian Høgsberg
On Wed, Jul 4, 2012 at 5:03 AM, Michel Dänzer mic...@daenzer.net wrote: On Fre, 2012-06-29 at 19:09 +0200, Michel Dänzer wrote: On Fre, 2012-06-29 at 12:58 -0400, Kristian Høgsberg wrote: On Fri, Jun 29, 2012 at 12:30 PM, Michel Dänzer mic...@daenzer.net wrote: On Fre, 2012-06-29 at 12:20

Re: [PATCH] dri2proto: add prime protocol support. (v2.1)

2012-07-06 Thread Kristian Høgsberg
On Fri, Jul 6, 2012 at 9:41 AM, Dave Airlie airl...@gmail.com wrote: On Fri, Jul 6, 2012 at 2:32 PM, Kristian Høgsberg k...@bitplanet.net wrote: On Fri, Jul 6, 2012 at 6:27 AM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com So we reserve bits 16-19 for offload

Re: [PATCH] dri2proto: add prime protocol support. (v2.1)

2012-07-06 Thread Dave Airlie
On Fri, Jul 6, 2012 at 4:02 PM, Kristian Høgsberg k...@bitplanet.net wrote: On Fri, Jul 6, 2012 at 9:41 AM, Dave Airlie airl...@gmail.com wrote: On Fri, Jul 6, 2012 at 2:32 PM, Kristian Høgsberg k...@bitplanet.net wrote: On Fri, Jul 6, 2012 at 6:27 AM, Dave Airlie airl...@gmail.com wrote:

Re: [PATCH xorg-server] Fix xf86EdidModes.c: array subscript is above array bounds

2012-07-06 Thread Adam Jackson
On 7/5/12 7:37 PM, Keith Packard wrote: Torsten Kaiserjust.for.l...@googlemail.com writes: With this optimization level gcc notices, that the loop in function DDCModesFromEstIII() would go until i=5 and j=1 which would result in m = (5 * 8) + (7 - 1) = 46, but the array EstIIIModes[] only

Re: [PATCH] glx: Fix checking GL version

2012-07-06 Thread Ian Romanick
On 07/05/2012 05:52 PM, Bartosz Brachaczek wrote: Signed-off-by: Bartosz Brachaczekb.brachac...@gmail.com Which is weird because the piglit test for this case passed. Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- Hi, I looked at Ian's patch out of curiosity and spotted this typo.

Re: [PATCH xorg-gtest 06/16] xserver: move Terminate and Kill handling here

2012-07-06 Thread Chase Douglas
On 07/05/2012 05:50 PM, Peter Hutterer wrote: On Thu, Jul 05, 2012 at 02:09:13PM -0700, Chase Douglas wrote: On 07/03/2012 10:42 PM, Peter Hutterer wrote: On Tue, Jul 03, 2012 at 10:33:50AM -0700, Chase Douglas wrote: On 07/02/2012 11:44 PM, Peter Hutterer wrote: Signed-off-by: Peter

Re: [PATCH xorg-gtest 16/16] Add Device::GetDeviceNode() to return device node path from an evemu device

2012-07-06 Thread Chase Douglas
On 07/05/2012 04:41 PM, Peter Hutterer wrote: On Thu, Jul 05, 2012 at 02:19:33PM -0700, Chase Douglas wrote: On 07/03/2012 11:03 PM, Peter Hutterer wrote: On Tue, Jul 03, 2012 at 11:40:25AM -0700, Chase Douglas wrote: On 07/02/2012 11:44 PM, Peter Hutterer wrote: evemu doesn't export this

Re: [PATCH xorg-server] Fix xf86EdidModes.c: array subscript is above array bounds

2012-07-06 Thread Keith Packard
Adam Jackson a...@redhat.com writes: I've added my r-b to the patches on https://bugs.freedesktop.org/45623 Merged. 9e4b8b7..7c9d8cb master - master (for future reference, applying patches from bugzilla is a huge pain. Please use git send-email to send patches to the list if at all

Re: [PATCH] glx: Fix checking GL version

2012-07-06 Thread Ian Romanick
On 07/06/2012 09:01 AM, Ian Romanick wrote: On 07/05/2012 05:52 PM, Bartosz Brachaczek wrote: Signed-off-by: Bartosz Brachaczekb.brachac...@gmail.com Which is weird because the piglit test for this case passed. The test failed to catch this error because it creates a context with the

Re: pull req one

2012-07-06 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: Dave Airlie (9): xf86: cursor code got mangled by indenting xfree86: use udev to provide device enumeration for kms devices (v10) screen: split out screen init code. (v2) dix: introduce gpu screens. (v5) xf86: cleanup

Re: pull request: output slave

2012-07-06 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: I'm just going to do review here, reading from the git tree diffs. randr: add provider object and provider property support (v6) Given that the _rrProvider structs are per-screen, any devPrivate stuff could live in the screen private instead;

Re: pull request : offload slave

2012-07-06 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: dix/xf86: initial offload slave tracking (v1.1) randr: add hooks for offload sink provider protocol So familiar by now. Reviewed-by: Keith Packard kei...@keithp.com xf86: store scanout pixmap in the xf86 struct as well. xf86:

Re: pull request: output slave

2012-07-06 Thread Adam Jackson
On 7/6/12 6:11 AM, Dave Airlie wrote: This depends on the previous pull req and contains all the patches in it. The pull below is from the top of that tree. This is all the randr changes + output slave additions. Looks good. For the series: Reviewed-by: Adam Jackson a...@redhat.com - ajax

Re: pull request: output slave

2012-07-06 Thread Dave Airlie
some comments inline, I've removed anything I agree with and have fixed up patches (Hrm, would also be nice if this patch created provider objects for the screens so that we could test the protocol support here) the ddx has to create them at CreateScreenResources time, just like crtc/outputs,

Re: pull request : offload slave

2012-07-06 Thread Dave Airlie
On Fri, Jul 6, 2012 at 9:21 PM, Keith Packard kei...@keithp.com wrote: Dave Airlie airl...@gmail.com writes: dix/xf86: initial offload slave tracking (v1.1) randr: add hooks for offload sink provider protocol So familiar by now. Reviewed-by: Keith Packard kei...@keithp.com

pull request v2: output slaves

2012-07-06 Thread Dave Airlie
Okay with lots of r-b's and lots of fixes for comments, Dave. The following changes since commit 4d24192bd24fb20d16d0054d77bffda883faeb79: Merge remote-tracking branch 'airlied/for-keithp-stage1' (2012-07-06 12:17:17 -0700) are available in the git repository at:

pull request v2: offload slaves

2012-07-06 Thread Dave Airlie
based on the v2 output slaves, I may have smashed an ajax r-b on one patch a bit early, but he might have r-b more of them, I've explained hopefully the patches you haven't r-b so feel free to smash it on, as I'm going to bed now. Dave. The following changes since commit

Re: pull request : offload slave

2012-07-06 Thread Adam Jackson
On 7/6/12 6:16 AM, Dave Airlie wrote: This builds on the two previous pull requests. Not fully reviewed, but its had a few users, and ickle has looked over it a couple of times and bitched at me ;-) This relies on an unpushed dri2proto change, since krh is no longer in X land, and jbarnes is

Re: [PATCH] Don't include touch state for emulated button press events

2012-07-06 Thread Chase Douglas
On 07/03/2012 05:30 PM, Chase Douglas wrote: When a touch begin is pointer emulated, do not include touch state when calculating the button state for the initial motion and button press events. This ensures the logical state of the buttons prior to the events is set properly. This doesn't

Re: pull request : offload slave

2012-07-06 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: On Fri, Jul 6, 2012 at 9:21 PM, Keith Packard kei...@keithp.com wrote: Really if next server I'd really like to shove the scanout pixmap into the crtc set calls and break the ABI properly, for per-crtc pixmaps it would make life a bit easier I expect.

Re: pull request: output slave

2012-07-06 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: the ddx has to create them at CreateScreenResources time, just like crtc/outputs, the startup ordering demands it :) oh, so you'd have to wrap CreateScreenResources... Yeah, not worth the pain for an intermediate state like this. PixmapSyncDirtyHelper

Re: pull request v2: offload slaves

2012-07-06 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: dix/randr: add a hook into screen to replace scanout pixmap Yeah, this looks fine if a bit kludgy. Reviewed-by: Keith Packard kei...@keithp.com dri2: add initial prime support. (v1.2) Still not happy with the 'prime_id' generation. Allocate

Re: pull request : offload slave

2012-07-06 Thread Dave Airlie
On Sat, Jul 7, 2012 at 3:46 AM, Keith Packard kei...@keithp.com wrote: Dave Airlie airl...@gmail.com writes: On Fri, Jul 6, 2012 at 9:21 PM, Keith Packard kei...@keithp.com wrote: Really if next server I'd really like to shove the scanout pixmap into the crtc set calls and break the ABI