Re: [PATCH hyperpen] Fixed indentation, dropped trailing whitespaces

2010-11-19 Thread Manuel Reimer
Peter Hutterer wrote: the best way to go about these drivers is to get them handled properly by the kernel and then hook the evdev or wacom driver onto them from userspace. (I acknowledge the Linux bias here) trying to port features over will just result in code duplication and a lot of

Re: [PULL hyperpen] cleanups for ABI 12

2010-11-18 Thread Manuel Reimer
Peter Hutterer wrote: I had a go at the hyperpen driver, making it build against ABI 12. Given that this driver doesn't really see any updates, Manuel has a segfault fix but doesn't really plan on future patches either, I removed support for pre-ABI 12 to reduce maintainance time. So you need

Re: [PATCH hyperpen] Fixed indentation, dropped trailing whitespaces

2010-11-11 Thread Manuel Reimer
Peter Hutterer wrote: You know that working on hyperpen automatically makes you the maintainer of the driver? Now's the time to run away screaming :) So far, I'm not sure, if I will have the time to do bigger changes. I think what would have to be done is: - Separate source code into a .c and

Re: [PATCH hyperpen] Fixed indentation, dropped trailing whitespaces

2010-11-11 Thread Manuel Reimer
Argh... Missed attachment in last mail... :-( Yours Manuel From 6d882d977d40cc525016e9f2a4e5c0ccb7de8997 Mon Sep 17 00:00:00 2001 From: Manuel Reimer manuel.rei...@gmx.de Date: Mon, 8 Nov 2010 20:17:16 +0100 Subject: [PATCH] Fixed indentation, dropped trailing whitespaces Signed-off

Re: [PATCH hyperpen] Fixed indentation, dropped trailing whitespaces

2010-11-10 Thread Manuel Reimer
Hi, can I continue my work and post a second patch, based on this one, or should I wait for this to be reviewed? Yours Manuel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

Re: [PATCH] Fix for bug Bug 13040 'Make the cursor option in xorg.conf useful'

2010-11-08 Thread Manuel Reimer
Hello, at first: Forget the last patch ;-) I completely disassembled the pen for this tablet, assembled it again (I placed the small magnet in the pen in in reverse direction, but I'm unsure if this is the reason why it works) and now pen and puck are working again, the way they should...

[PATCH hyperpen] Fixed indentation, dropped trailing whitespaces

2010-11-08 Thread Manuel Reimer
This patch shouldn't change the way the hyperpen driver works. Anything, it does, is to fix the indentation and it drops some useless trailing whitespaces. Without this, the code is nearly unreadable. I used this as reference: http://www.x.org/wiki/CodingStyle Signed-off-by: Manuel Reimer

Re: [PATCH] Fix for bug Bug 13040 'Make the cursor option in xorg.conf useful'

2010-11-07 Thread Manuel Reimer
Simon Thum wrote: In case you're set out to DTRT, may may consider making it two X devices for stylus or puck. IFAIK the wacom driver does that. Maybe, but I'm no X.org driver expert. I'm happy that I managed to get this driver to work again without crashing all the time ;-) For me, it

Re: [PATCH] Fix for bug Bug 13040 'Make the cursor option in xorg.conf useful'

2010-11-06 Thread Manuel Reimer
Jesse Adkins wrote: Updating the ChangeLog isn't necessary, since the driver shouldn't have one. It's no big deal, since a future patch can remove the ChangeLog. OK. So I think I'll just add my name to the AUTHORS file as soon as I'm finished with cleaning up this driver. Wouldn't

[PATCH] Fix for bug Bug 13040 'Make the cursor option in xorg.conf useful'

2010-11-05 Thread Manuel Reimer
another problem. --- ChangeLog |6 ++ src/xf86HyperPen.c | 20 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/ChangeLog b/ChangeLog index 2b5bb16..b40ef44 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2010-11-05 Manuel Reimer