Re: [ZODB-Dev] fixing far-future timestamps (patch)

2009-06-11 Thread Jim Fulton
On Jun 10, 2009, at 6:52 PM, Ross J. Reedstrom wrote: On Tue, Jun 09, 2009 at 06:29:38PM -0400, Jim Fulton wrote: On Jun 9, 2009, at 4:19 PM, Ross J. Reedstrom wrote: Hmm, I seem to not be receiving email from this list, even though I signed up. Anyway, saw this via the archives. Would a

Re: [ZODB-Dev] fixing far-future timestamps (patch)

2009-06-10 Thread Ross J. Reedstrom
On Tue, Jun 09, 2009 at 06:29:38PM -0400, Jim Fulton wrote: On Jun 9, 2009, at 4:19 PM, Ross J. Reedstrom wrote: Hmm, I seem to not be receiving email from this list, even though I signed up. Anyway, saw this via the archives. Would a doctest in FileStorage be o.k.? Yup. The

Re: [ZODB-Dev] fixing far-future timestamps (patch)

2009-06-10 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ross J. Reedstrom wrote: On Tue, Jun 09, 2009 at 06:29:38PM -0400, Jim Fulton wrote: On Jun 9, 2009, at 4:19 PM, Ross J. Reedstrom wrote: And what's the preferred patch-submission format? *I* prefer svn branches. :) Are you a contributor?

Re: [ZODB-Dev] fixing far-future timestamps (patch)

2009-06-09 Thread Ross J. Reedstrom
Hmm, I seem to not be receiving email from this list, even though I signed up. Anyway, saw this via the archives. Would a doctest in FileStorage be o.k.? The change is in BaseStorage, but the only case I've experienced uses FileStorage (and I can leverage the tests in there for out-of-order tids

Re: [ZODB-Dev] fixing far-future timestamps (patch)

2009-06-09 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ross J. Reedstrom wrote: ... And what's the preferred patch-submission format? Upload it as an attachment to a new issue in launchpad: https://bugs.launchpad.net/zodb using the format:: $ svn diff -u Tres. - --

Re: [ZODB-Dev] fixing far-future timestamps (patch)

2009-06-09 Thread Jim Fulton
On Jun 9, 2009, at 4:19 PM, Ross J. Reedstrom wrote: Hmm, I seem to not be receiving email from this list, even though I signed up. Anyway, saw this via the archives. Would a doctest in FileStorage be o.k.? Yup. The change is in BaseStorage, but the only case I've experienced uses

[ZODB-Dev] fixing far-future timestamps (patch)

2009-06-04 Thread Ross J. Reedstrom
Hi all - I'm one of the unfortunates who managed to break a Data.fs when migrating a ZEO backend to new hardware. Unfortunately, I missed the 'CRITICAL' error logged by ZOE (aside: is there a fail_on_critical option somewhere?) and ended up with transaction ids that parse as timestamps in the year

Re: [ZODB-Dev] fixing far-future timestamps (patch)

2009-06-04 Thread Jim Fulton
On Jun 4, 2009, at 12:04 PM, Ross J. Reedstrom wrote: Hi all - I'm one of the unfortunates who managed to break a Data.fs when migrating a ZEO backend to new hardware. Unfortunately, I missed the 'CRITICAL' error logged by ZOE (aside: is there a fail_on_critical option somewhere?) and ended