On Wed, 31 Jan 2024 14:22:44 GMT, Kevin Walls <kev...@openjdk.org> wrote:

> Introduce the jcmd "VM.debug" to implement access to a useful set of the 
> established debug.cpp utilities, with "jcmd PID VM.debug subcommand ...".
> 
> Not recommended for live production use.  Calling these "debug" utilities, 
> and not including them in the jcmd help output, is to remind us they are not 
> general customer-facing tools.

test/hotspot/jtreg/serviceability/dcmd/vm/VMDebugTest.java line 178:

> 176:                 String p = m.group(regexGroup);
> 177:                 ptr = new BigInteger(p, 16);
> 178:                 System.out.println("Found '" + pattern +"', using 
> pointer: 0x" + ptr.toString(16));

Would it be more logical to say this?
  "Found pointer: 0x" + ptr.toString(16)'" + " for pattern " +pattern

test/hotspot/jtreg/serviceability/dcmd/vm/VMDebugTest.java line 201:

> 199:         run(new JMXExecutor());
> 200:     }
> 201:    */

comment to remove

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17655#discussion_r1474686608
PR Review Comment: https://git.openjdk.org/jdk/pull/17655#discussion_r1474688481

Reply via email to