Davide,

This patch does not seem to have been checked in CVS main line. I would
really appreciate if you could check this in for 2.1.

Regards,
Ritu


-----Original Message-----
From: Ritu Kedia [mailto:[EMAIL PROTECTED]
Sent: Friday, July 30, 2004 6:04 PM
To: 'Slide Developers Mailing List'
Subject: RE: Patch for Bug# 30317


Thanks Davide for this patch. It worked.

Would you be applying this patch to 2.1? Also a similar fix would be
required for other RDBMS stores and File store. It would be great if the
RDBMS store fix would be available in 2.1.

Thanks again,
Regards,
Ritu 


-----Original Message-----
From: Davide Savazzi [mailto:[EMAIL PROTECTED]
Sent: Thursday, July 29, 2004 5:29 AM
To: Slide Developers Mailing List
Subject: Re: Patch for Bug# 30317


On Wednesday 28 July 2004 14:57, Ritu Kedia wrote:

> I did try the solution proposed by you i.e. count the bytes copied to
> Oracle Blob, but that did not return the correct length. I basically
> executed the select stmt of the storeContent method of the
> OracleRDBMSStore, after the copy method and then retrieved the blob and
> queried for blob.length(). 

No I mean count the bytes as they are written to Oracle in the copy(...) 
method in CommonRDBMSAdapter, so you don't have to write a tmp file.

I think there's a problem in your patch when you use compression and 
contentLength is -1.
ziputil.getContentLength() returns the _compressed_ file size, that is good 
for:
statement.setBinaryStream(1, is, (int) contentLength);
but bad for:
revisionDescriptor.setContentLength(contentLength);

I've attached patches for Oracle adapter and StoreContentZip, tell me if
they 
works to you...

Cheers,
-- 
Davide Savazzi


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to