Hi, If you need another type of patch, please let me know (e.g. a patch without looking at whitespaces). As for the enum vs template implementation, some info on this.
1) I started off with the enum approach but stopped that after finding out that there's no other way to extract timestamps than via the OCITimestamp ... methods. However those require additional handler and handler allocation/deallocation. This was breaking the enum approach because e.g. DATE/std::tm and other simple types do without allocation/deallocation of handlers. 3) I must have left the enums in but the actual working part is the templetized part. Kindly asks Thomas -----Original Message----- From: Maciej Sobczak [mailto:[email protected]] Sent: 31 March 2011 15:26 To: General-purpose list for SOCI users. Subject: Re: [SOCI-users] FW: Re: Using oracle timestamps, with fractiosn of a second On 31/03/2011 14:48, Maciej Sobczak wrote: > I will certainly have a look at it, as now there is a time for closing > the release. OK. The majority of this patch contains whitespace and formatting modifications, which made it more difficult to figure out its essential parts - but here is what I understand: - you have unconditionally assumed that Boost is available for compilation; this is not necessarily the case and one of the important design assumptions in SOCI is that Boost is optional, not required - you have introduced the binding type parameterization in terms of templated backend type implementations - this is technically valid, but inconsistent with the existing code and now there are two partially decoupled parameterization approaches: one based on enums and switch statements and one based on templates; I would rather incorporate the new type uniformly with the existing code, which will make it easier to maintain the whole in long term Again - thank you for this patch, but I will not include it in the coming release in its current form. I will try to extract the essential parts (the timestamp-specific OCI binding routines) and incorporate them with the rest of the codebase for one of the future releases instead, with the hope that the result will be more rigid and maintainable. Best regards, -- Maciej Sobczak * www.msobczak.com * www.inspirel.com ------------------------------------------------------------------------------ Create and publish websites with WebMatrix Use the most popular FREE web apps or write code yourself; WebMatrix provides all the features you need to develop and publish your website. http://p.sf.net/sfu/ms-webmatrix-sf _______________________________________________ Soci-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/soci-users ------------------------------------------------------------------------------ Create and publish websites with WebMatrix Use the most popular FREE web apps or write code yourself; WebMatrix provides all the features you need to develop and publish your website. http://p.sf.net/sfu/ms-webmatrix-sf _______________________________________________ Soci-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/soci-users
