On Fri, Sep 28, 2012 at 1:37 PM, Sergei Nikulov <[email protected]>wrote:
> Mateusz, Aleksander,
>
> I've just closed https://github.com/SOCI/soci/pull/7
>
> In fact, I've slitted it into 2 different requests:
>
>
> 1. Changes for cmake goes to https://github.com/SOCI/soci/pull/8(Mateusz,
> FYI)
> 2. Changes for mysql tests https://github.com/SOCI/soci/pull/9(Aleksander,
> FYI)
>
> I took a quick look and it seems you just dropped the "type InnoDB" part
from the request in table_creator_one? Won't that break the transactions
test?
What I think we need to do is this: 1. Determine the server version at the
beginning, e.g., in test_context's constructor, save the information and
pass it as a parameter to table_creator_one's constructor. 2. In
table_creator_one's constructor, use one or the other syntax depending on
the server version.
Also, it would be probably better to avoid comparing the version strings
lexicographically, you don't want 10.0 to be earlier than 5.5.
I'll be away from email until Wednesday. If you prefer, you can drop this
change and I'll make the change when I'm back.
Thanks,
Aleksander
>
>
> Could you please review?
> Thank you.
>
>
> --
> Best Regards,
> Sergey Nikulov
>
>
> ------------------------------------------------------------------------------
> Got visibility?
> Most devs has no idea what their production app looks like.
> Find out how fast your code is with AppDynamics Lite.
> http://ad.doubleclick.net/clk;262219671;13503038;y?
> http://info.appdynamics.com/FreeJavaPerformanceDownload.html
> _______________________________________________
> Soci-users mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/soci-users
>
>
------------------------------------------------------------------------------
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
Soci-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/soci-users
