[
https://issues.apache.org/jira/browse/SOLR-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622406#action_12622406
]
Yonik Seeley commented on SOLR-374:
-----------------------------------
It would not have been easy in the past, but with all of the recent changes, it
should be simple.
This patch has couple off issues though:
- a race condition: the reader could be closed between the time you get it and
the time you try to call reopen().
- descriptor leak: you pass closeReader=false, but no one else will close this
reader.
- the last reader to be opened is the one that should be re-opened, not
necessarily the currently registered one
See the getNewestSearcher() method I recently added to fix both #1 and #3
Also, I think that any test that expects the reader to be different should be
changed.
> use IndexReader.reopen
> ----------------------
>
> Key: SOLR-374
> URL: https://issues.apache.org/jira/browse/SOLR-374
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Attachments: SOLR-374.patch
>
>
> Take advantage of IndexReader.reopen(): LUCENE-743
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
