[
https://issues.apache.org/jira/browse/SOLR-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622420#action_12622420
]
Mark Miller commented on SOLR-374:
----------------------------------
* a race condition: the reader could be closed between the time you get it
and the time you try to call reopen().
Ah, because of no incref...
* descriptor leak: you pass closeReader=false, but no one else will close
this reader.
Dumb mistake here - made a private method public just so I could pass true
and then still passed false...
>>Also, I think that any test that expects the reader to be different should
be changed.
Alright, easy enough, just two I think: elevation and function tests, using
the reader as a key in a map or something.
If thats all for the reopen, I've got that looking good I think, just have
to take care of the tests.
> use IndexReader.reopen
> ----------------------
>
> Key: SOLR-374
> URL: https://issues.apache.org/jira/browse/SOLR-374
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Attachments: SOLR-374.patch
>
>
> Take advantage of IndexReader.reopen(): LUCENE-743
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
