|
John Smith wrote:
The 'addr:postcode' key is in the presets because it's the recommended way of entering a postcode (should you want to) when applying street numbering along a way. It doesn't really apply when providing a postcode for a suburb or group of suburbs as is the case with the ABS bulk import. I suspect that the key 'postal_code' which does appear in the Map Features page, but as somewhat deprecated, was selected to use in the bulk import because it's a key name that seems appropriate for this particular role. None of the keys developed for the ABS bulk import (or other special projects in Australia) need to be included in the presets menu within JOSM. This menu is a feature for the convenience of JOSM editors when entering commonly used keys/key combinations. Most of these special use keys show as a warnings in the plugin because they aren't in the presets, however they don't belong in the presets. This is where the flaw in the current plugin programming is revealed. The preset menu is trying to be used for more than it was originally designed. The people managing this plugin may tell you that you'll always get errors, because not all keys that are validly used are also in the presets. What they don't realise is that once you start ignoring error warnings, it can quickly become a one way street and the value of the plugin can be diminished to the point where you may as well not run it at all... I mean why would you, if you ignore everything? I think the validator plugin has great value, as it will regularly show genuine errors (sometimes many) that need correcting that I would otherwise not notice. Currently, you just have to be prepared to wade through all the false-positives to get to the real errors, and that is what I was looking to address by mentioning the ABS data import related errors in the first place. John Smith wrote: Being able to have arbitary keys and key pairs ignored that aren't in the preset list is a good idea, I've taken this a step further and given the plugin the ability to download a list of keys and keypairs to ignore or exempt from warnings. This is a great way to address the issue! Just as external files are used by the validator plugin for: spelling - http://svn.openstreetmap.org/applications/utils/planet.osm/java/speller/words.cfg and tagging - http://svn.openstreetmap.org/applications/editors/josm/plugins/validator/tagchecker.cfg so too should there be an external file listing keys that are validly used either internationally, or in specific areas such as the ABS keys used here in Australia. This could be structured in two ways: 1. A list that includes all of the commonly used keys and any special purpose keys, thus returning the preset menu to its original role 2. A list appending only specially used keys to be used in conjunction with the existing presets method. I'm totally behind this initiative to improve the usability and reduction in false positives in validator plugin. Cheers Rick :) |
_______________________________________________ Talk-au mailing list Talk-au@openstreetmap.org http://lists.openstreetmap.org/listinfo/talk-au
