On Wed, Mar 03, 2010 at 04:46:18PM -0800, J.C. Roberts wrote:
> Boolean variables should be set to Yes instead of simply being
> defined, for uniformity and future compatibility.
This takes time to finish changing.
> 1.) The majority of the scripts in ports/infrastructure do not
> bother to check /etc/mk.conf at all, so saying "or" and "also" seems
> unwise without context. The best answer seems to be to preface the
> statement with, "When running make ..."
This ought to change. It's just a bit more expensive to do it in scripts,
as it requires running make.
mk.conf is *NOT* a config file, it is a piece of Makefile !
> 5.) Considering the precedence set by other /etc/*.conf files like
> rc.conf, using all caps of "YES" or "NO" for true/false would be more
> consistent. --Since Marc is the main chef of the ports system, this
> should probably be his call. Chefs' choice and all that.
No, I hate YES. I explicitly changed it because I hate it.
You can use YES if you want for your own stuff, but make has
${V:L} explicitly to allow for any kindofase.
> 6.) Though it mentions the private "_*" variables, it does not list
> them, so this results in basically outlawing all variables which start
> with and underscore. --thoughts?
Duh, this is the idea, yes.
You'll notice that the libc documentation does not list the variables
starting with __, and that the C standard only say that those are off-limits.
> -----------------------------------------------------------------------
> Index: ports.7
> ===================================================================
> RCS file: /cvs/src/share/man/man7/ports.7,v
> retrieving revision 1.79
> diff -u ports.7
> --- ports.7 11 Oct 2009 21:07:06 -0000 1.79
> +++ ports.7 4 Mar 2010 00:27:56 -0000
> @@ -242,7 +242,7 @@
> Defining
> .Ev NO_CHECKSUM
> to
> -.Dv Yes
> +.Qq YES
No, diff is definitely not okay.
