On Tue, Jun 21, 2016 at 10:37:45AM +0200, Henning Brauer wrote: > * Sebastian Benoit <be...@openbsd.org> [2016-06-21 10:15]: > > same thing without a stupid helper function, pointed out by henning. > > I'm actually not quite sure we need or want this. From my PoV, making > the tools too much of a nanny is against unix spirit. Macros with > spaces don't actually cause harm, they just don't work. Not too > unexpected apparently given that, afair at least, nobody spoke up on it > in more than a decade. > > So, do we really want this extra check? I'm unsure. > If not, short mention in the manpage or just leave things as they are?
Generally, I would appreciate more detailed error messages from the pf.conf parser. I recall several occasions where pfctl threw "syntax error" and more specific error reporting would have saved me some time with finding the silly mistake I made. And in this case the ruleset loads successfully even though, while parsing, we already know it's not going to work as intended... Only as long as it doesn't make the parser code overly complex, of course. But currently the balance is tilted too much towards terse error messages for my taste. So I liked benno's first diff.
