On Wed, Jul 31, 2013 at 08:20:30AM +0200, Heiko Schocher wrote:
> Hello Mugunthan,
>
> Am 30.07.2013 10:40, schrieb Mugunthan V N:
> >On 7/30/2013 1:23 PM, Heiko Schocher wrote:
> >>Signed-off-by: Heiko Schocher<h...@denx.de>
> >>
> >>---
> >>- changes for v2:
> >> defined all bits used in the gmii_sel register as
> >> Tom Rini suggested
> >>- changes for v3:
> >> rebased against u-boot-ti commit bb2a5d8f87fffb4fadfb205837decbd1b3e75f88
> >>---
> >> arch/arm/include/asm/arch-am33xx/cpu.h | 21 +++++++++++++++++++++
> >> board/isee/igep0033/board.c | 6 ++----
> >> board/phytec/pcm051/board.c | 2 --
> >> board/ti/am335x/board.c | 6 +-----
> >> 4 Dateien ge??ndert, 24 Zeilen hinzugef??gt(+), 11 Zeilen entfernt(-)
> >>
> >>diff --git a/arch/arm/include/asm/arch-am33xx/cpu.h
> >>b/arch/arm/include/asm/arch-am33xx/cpu.h
> >>index bcb4c50..945a09b 100644
> >>--- a/arch/arm/include/asm/arch-am33xx/cpu.h
> >>+++ b/arch/arm/include/asm/arch-am33xx/cpu.h
> >>@@ -336,6 +336,27 @@ struct ctrl_dev {
> >> unsigned int resv4[4];
> >> unsigned int miisel; /* offset 0x50 */
> >> };
> >>+
> >>+/* gmii_sel register defines */
> >>+#define GMII1_SEL_MII 0x0
> >>+#define GMII1_SEL_RMII 0x1
> >>+#define GMII1_SEL_RGMII 0x2
> >>+#define GMII1_SEL_NOTUSED 0x3
> >NOTUSED not needed as it is not supposed to be used.
>
> Maybe it is used to check, that is it not set?
> But I can remove it ...
>
> >>+#define GMII2_SEL_MII 0x0
> >>+#define GMII2_SEL_RMII 0x4
> >>+#define GMII2_SEL_RGMII 0x8
> >>+#define GMII2_SEL_NOTUSED 0xc
> >NOTUSED not needed as it is not supposed to be used.
>
> same here ...I think "Not Used" in the TRM here means "this port is not used" rather than "this combination of bits is not to be used", so the changes are correct. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
