On Monday 12 August 2013 11:06 PM, Mugunthan V N wrote: > On Monday 12 August 2013 07:52 PM, Tom Rini wrote: >>>>> +#define GMII2_SEL_MII 0x0 >>>>>>>> +#define GMII2_SEL_RMII 0x4 >>>>>>>> +#define GMII2_SEL_RGMII 0x8 >>>>>>>> +#define GMII2_SEL_NOTUSED 0xc >>>>>> NOTUSED not needed as it is not supposed to be used. >>>> same here ... >> I think "Not Used" in the TRM here means "this port is not used" rather >> than "this combination of bits is not to be used", so the changes are >> correct. > But having this define is not useful as far as I can think of as there > is not abstraction API for this to check what user is passing. But I > leave it to Tom's decision to have this change or not. > > Other than this the patch looks good to me. > Acked-by: Mugunthan V N <mugunthan...@ti.com> > > I had a discussion with the hardware team internally and the comment is *When these bits are set to 11b the RGMII is selected with internal delay mode which was not timing closed. Therefore this register setting is not supported so it should not be used. The respective pin multiplexing should be used to deselect any unused CPGMAC pins.*c The same will be updated in the TRM soon. So can you remove NOTUSED define and resubmit the patch again and can include my Acked-by in your next version patch.
Regards Mugunthan V N
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
