On May 7, 2009, at 8:49 PM, Jeremy Orlow wrote:

One more question: are there any use cases where setGroupName could occur after window.localStorage() had been called?

I don’t know. I don’t think it’s something we can support. It’s possible we can change setGroupName to have no effect once a WebView has been “used” without breaking Mac OS X applications.

If so, this seems like it could be a problem since a Storage object is only created on the first call to DOMWindow::localStorage() and then it's cached as a member variable in DOMWindow. This would mean that any page that calls window.localStorage() before setGroupName is called would not be using the same localStorageArea as a page that calls setGroupName first.

Yes, that could be a bug. Probably no real world cases of it.

Also, is there any significance to setGroupName being reset to nothing during Page's destructor?

I think it’s a way to share cleanup code.

    -- Darin

_______________________________________________
webkit-dev mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Reply via email to