On Mon, January 25, 2010 10:42:56 AM, Alex Milowski wrote: > On Mon, Jan 25, 2010 at 10:31 AM, Maciej Stachowiak wrote: > > > > It's reasonable to use an ENABLE() flag for debugging features like this, > > in > my opinion. I don't know if we have any direct precedent. > > Doesn't ENABLE() require a feature define?
No, not necessarily. If the ENABLE() macro doesn't require something like a different set of export symbols on Mac OS X builds, then you don't have to do the whole feature define thing. Some ENABLE() macros are only defined in JavaScriptCore/wtf/Platform.h. If the macro resides in just one source file, I've seen render tree debugging macros added to just the source file and defined at the top. (If you can get by with putting the macro in one header file, that would work as well.) Dave _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
