According to <http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/features.gypi>, Chromium currently enables REGISTER_PROTOCOL_HANDLER but not CUSTOM_SCHEME_HANDLER. Until the Chromium project decides to ship CUSTOM_SCHEME_HANDLER, having two ENABLE flags is valuable. Please do not combine the two flags until everyone wishes to set them to the same value.
Adam On Thu, Jun 28, 2012 at 1:10 AM, DongWoo Im <[email protected]> wrote: > Dear WebKit! > > > There are two flags in WebKit - 'ENABLE_REGISTER_PROTOCOL_HANDLER' and > 'ENABLE_CUSTOM_SCHEME_HANDLER'. > How about delete one of them? > > > There is a feature named "Custom Scheme Hander" in the W3C HTML5 spec. : > http://dev.w3.org/html5/spec/Overview.html#custom-handlers > There are three APIs in the spec. - registerProtocolHandler, > isProtocolHandlerRegistered, and unregisterProtocolHandler. > Those three APIs are implemented in WebKit already. > > But I think there is a problem. > The problem is, we are using two flags for the one spec. > - 'registerProtocolHandler' function have been implemented behind the > 'REGISTER_PROTOCOL_HANDLER' flag. > - two other functions have been implemented behind the > 'ENABLE_CUSTOM_SCHEME_HANDLER' flag. > > > I think this could make confusion. > > Why don't we use only one flag for the one spec which has only three APIs? > Let's use only one flag - 'ENABLE_CUSTOM_SCHEME_HANDLER' . > > I've filed that bug already - https://bugs.webkit.org/show_bug.cgi?id=88614. > > > What do you think about this? > > > > > BR, > Dongwoo. > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
