On a related note, there is a gradual movement to pass more command line flags along with each test to DRT during run-webkit-tests (to toggle between pixel tests and non, change timeout values, etc.), and being able to ensure we reset the state to the default between each test is kinda necessary for this to work.
-- Dirk On Wed, Sep 26, 2012 at 2:00 PM, Eric Seidel <e...@webkit.org> wrote: > When overridePreferences was added back in the day: > http://trac.webkit.org/changeset/39212 > > The contract was that DRT would call resetDefaults between tests. I > don't know what the current status of resetToDefaults implementations > in other ports or in non-WK1 architectures. > > On Wed, Sep 26, 2012 at 3:53 PM, Brady Eidson <beid...@apple.com> wrote: >> >> On Sep 26, 2012, at 1:48 PM, Ryosuke Niwa <rn...@webkit.org> wrote: >> >> On Wed, Sep 26, 2012 at 1:44 PM, Simon Fraser <simon.fra...@apple.com> >> wrote: >>> >>> >>> First, direct calls on testRunner that just set preferences should be >>> migrated to internals.settings or testRunner.overridePreference calls, I >>> think (I don't know if either is preferred). >> >> >> I support the idea of unifying the approaches and just use >> internals.settings. However, the last time I checked, Alexey had some >> concerns about using internals due to settings may not be properly >> propagated to WebKit2 layer. Has this concern been addressed? >> >> >> In general I prefer the overridePreference() calls whenever they exist. >> >> internals.settings are not exposed in any real-world product whereas >> preferences exist in each platform's WebKit-layer API that they expose to >> their embedders in some form. >> >> ~Brady >> >> >> _______________________________________________ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo/webkit-dev >> > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
