On Dec 3, 2012 6:21 PM, "Dirk Schulze" <dschu...@adobe.com> wrote: > > > On Dec 3, 2012, at 1:15 PM, Benjamin Poulain <benja...@webkit.org> wrote: > > > On Mon, Dec 3, 2012 at 12:59 PM, Dirk Schulze <dschu...@adobe.com> wrote: > > Depends on the future. But for such a small patch, a new flag seems to be overdone. I looked into the patch, and adding the flag caused more code, then the actual feature (even if the computed style is missing). I believe we should remove the flag ASAP. Flags are for bigger new features of features that likely will change IMO. Both seems not to be the case for background-position. > > > > See http://trac.webkit.org/wiki/AddingFeatures > > > > "The policy for adding new (major) features to WebKit is:" > > major says everything IMO. background-position is not a major feature. > > However, to stay at the topic: Is there anything blocking 'background-position' with the new syntax? Any objections to remove the flags? If yes, I would like to know more about the problems. >
I can still remove the flag when everything is done. Probably tomorrow or so. > Greetings, > Dirk > > > I personally appreciate when authors take the time to have feature flags until the feature is finished. It has many advantages for making releases. > > > > Benjamin > > _______________________________________________ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > http://lists.webkit.org/mailman/listinfo/webkit-dev > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
