Hello,

TL;DR:  Please start using RELEASE_ASSERT_WITH_SECURITY_IMPLICATION() in place 
of ASSERT_WITH_SECURITY_IMPLICATION() for new/updated code.

It turns out that having some of these debug asserts enabled in release builds 
would have prevented security issues, so we’re going through and changing the 
ones that won’t impact performance immediately, and we will eliminate the rest 
of the debug asserts over time.  (Changing them all at once would incur too 
many performance regressions.)

I’ve also added a webkit-style-checker check to warn when using 
ASSERT_WITH_SECURITY_IMPLICATION() to deter new instances of the debug macro.

For reference:

Bug 178269: Add RELEASE_ASSERT_WITH_SECURITY_IMPLICATION() macro
<https://bugs.webkit.org/show_bug.cgi?id=178269 
<https://bugs.webkit.org/show_bug.cgi?id=178269>>
<https://trac.webkit.org/changeset/223421 
<https://trac.webkit.org/changeset/223421>>

Dave

_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Reply via email to