That's because our phpunit setup is incredibly fragile. I'm trying to fix it.
-Chad On Jun 1, 2011 12:09 PM, "Max Semenik" <maxsem.w...@gmail.com> wrote: > On 01.06.2011, 20:00 Roan wrote: > >> On Wed, Jun 1, 2011 at 5:28 PM, Chad <innocentkil...@gmail.com> wrote: >>> I don't think "revert in 72 hours if its unreviewed" is a good idea. It >>> just discourages people from contributing to areas in which we only >>> have one reviewer looking at code. >>> >> I also don't really like it. But I do think we should be more liberal >> about reverting things that won't be reviewed soon because they're >> e.g. too large and should be branched or broken up, or whatever. > >>> I *do* think we should enforce a 48hr "revert if broken" rule. If you >>> can't be bothered to clean up your breakages in within 48 hours of >>> putting your original patch in, it must not have been very important. >>> >> +1. Serious breakage should be reverted on sight, however. > > +1. "Serious" should include "breaking the tests" though - otherwise > we'll remain with our current situation when tests are broken > in multiple places and nobody knows who broke what: > > [19:39:08] <codurr> Something broke. See < http://ci.tesla.usability.wikimedia.org/cruisecontrol/buildresults/mw>. Possible culprits: aashrh/r89027 /r89028 /r89029 nbiabriket/r89035 krenkli/r89036 eryed/r89037 /r89038 eixal/r89039 /r89040 /r89041 /r89043 /r89044 /r89047 /r89049 /r89051 /r89061 /r89062 /r89063 /r89070 /r89071 /r89072 yaor_mdn/r89074 /r89075 /r89076 osnenl/r89079 /r89082 /r89083 /r89084 /r89085 /r89086 /r89087 eom-ylnphap/r89088 jedht/r89094 /r89099 /r89 > [19:39:08] <codurr> /r89108 /r89110 /r89111 /r89112 /r89113 /r89114 /r89115 /r89116 /r89117 /r89118 /r89119 iwkiunta/r89120 /r89122 /r89123 onraa/r89128 /r89129 /r89134 /r89138 ^nmdoe/r89144 /r89145 /r89149 /r89150 algsinrtt/r89166 /r89176 /r89179 /r89180 sxemma/r89181 /r89182 /r89186 ptolsaiedn/r89191 /r89197 /r89204 /r89205 /r89206 /r89207 /r89208 /r89218 wadreoujdene/r89219 /r89223 /r89224 rtemo/r89225 /r89226 /r89227 /r89228 /r89230 /r89241 oribn/r89243 /r89244 /r89 > [19:39:08] <codurr> kfoelokwrays/r89250 /r89251 /r89253 /r89254 awnurotkaot/r89258 /r89260 rnabsedi/r89261 /r89262 /r89263 > > -- > Best regards, > Max Semenik ([[User:MaxSem]]) > > > _______________________________________________ > Wikitech-l mailing list > Wikitech-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/wikitech-l _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
