On Wed, Jun 1, 2011 at 8:28 AM, Chad <innocentkil...@gmail.com> wrote:
> I *do* think we should enforce a 48hr "revert if broken" rule. If you > can't be bothered to clean up your breakages in within 48 hours of > putting your original patch in, it must not have been very important. > Officially speaking, since forever we have had an "it's acceptable to revert on sight if broken" rule. If you encounter something broken, correct responses include: * revert it immediately to a known good state; send an explanation to the author about what's wrong (usually a CR comment and reopening a 'fixed' bugzilla entry) * figure out the problem and fix it; send follow-up explanation to the author (usually a CR comment and a Bugzilla comment if it's a followup on a bug fix) * take a stab at the problem and recommend a solution to someone else who will fix it straight away; including a note on CR or Bugzilla summarizing your IRC discussion is wise in case it ends up getting dropped * tag it fixme and ask someone more familiar with the stuff than you to handle it -- brion _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
