On 15/01/13 12:44, Jeroen De Dauw wrote:
I have observed a difference in opinion between two groups of people on
gerrit, which unfortunately is causing bad blood on both sides. I'm
therefore interested in hearing your opinion about the following scenario:
Someone makes a sound commit. The commit has a clear commit message, though
there is a single typo in it. Is it helpful to -1 the commit because of the
typo?
This intricate, complex and important question deserves a long and
thoughtful answer.
In my opinion, if the typo is trivial (f.e. someone typed "fo" instead
of "of"), there is no need to -1 the commit, however if the typo
pertains to a crucial element of the commit (f.e. someone typed "fixed
wkidata bug") perhaps it should, since otherwise people who search
through commit messages won't be able to find commits that contain word
"wikidata".
_______________________________________________
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
