On 2013-01-04 Mikolaj Izdebski wrote: > For xz-java to be usable as an OSGi bundle certain attributes > required by the OSGi specification need to be present in the > manifest.
K. Daniel visited #tukaani on Thursday but I got online five minutes too late so I couldn't reply. Then I got an email from Stefan Bodewig (Apache Commons Compress developer) on the same day about the same subject. The next days I was busy, so I'm sorry that I didn't reply earlier. > The above patch was applied[1] in Fedora GNU/Linux distribution and it > was tested by Fedora developers. It would be nice if OSGi manifests > were included in upstream xz-java too. In addition to Bundle-SymbolicName, Bundle-Version, and Export-Package, Stefan Bodewig suggested adding Bundle-ManifestVersion, Bundle-Name, and Bundle-DocURL. I don't have much clue about any OSGi stuff, but I checked the OSGi wiki and these sounded reasonable. > [1] > http://pkgs.fedoraproject.org/cgit/xz-java.git/commit/?id=cd63efa72e4150b6303f995e829b31465bfcd6e9 Note that the committed patch hardcodes the bundle version number while the patch you included in your email doesn't. On the other hand, I think it is OK hardcode "org.tukaani.xz" in build.xml. I committed a patch: http://git.tukaani.org/?p=xz-java.git;a=commitdiff;h=101303b7e10e9618a83a06b1bfccd0b87e33acd6 Please let me know if you think it has a problem. Maybe I should make a new release some day to include this and xz-x.x-sources.jar fixes even though no actual Java code has been changed after 1.1. Thanks! -- Lasse Collin | IRC: Larhzu @ IRCnet & Freenode
