Hi Phil & Jim, Here is the updated webrev: http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.2/
Changes: - trimToSize() return void - fixed test + jtreg passed Bye, Laurent 2017-04-20 21:30 GMT+02:00 Jim Graham <james.gra...@oracle.com>: > Hi Laurent, > > The implementation looks good, except that the method chaining-style > return value seems out of place here. Similar trimToSize() methods in > Collections return void and none of the other methods in this area use the > method chaining paradigm. In the interest of maintaining a common design > theme throughout 2D this method should just return void. > > ...jim > > > On 4/18/17 11:49 PM, Laurent Bourgès wrote: > >> Hi, >> >> Here is a first attempt to propose a Path2D patch (based on JDK10): >> http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.0/ >> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8078192 >> >> Please review the Path2D changes, notably the javadoc (english) and the >> modified Path2DCopyConstructor test which checks >> all public Path2D methods on concrete classes (Path2D.Float, >> Path2D.Double, GeneralPath) after calling path.trimToSize() >> >> Cheers, >> Laurent >> > -- -- Laurent Bourgès
