Early next week is the hope.
-phil
On 05/16/2017 02:20 PM, Laurent Bourgès wrote:
Phil,
Did you get any answer from the CSR process on this bug ?
Laurent
2017-04-21 0:17 GMT+02:00 Philip Race <philip.r...@oracle.com
<mailto:philip.r...@oracle.com>>:
OK. Although we still need to wait for the CSR process.
-phil.
On 4/20/17, 3:05 PM, Laurent Bourgès wrote:
Sorry (bad shortcut);
Here is the fixed webrev:
http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.3/
<http://cr.openjdk.java.net/%7Elbourges/path2D/Path2D-8078192.3/>
Laurent
2017-04-21 0:04 GMT+02:00 Laurent Bourgès
<bourges.laur...@gmail.com <mailto:bourges.laur...@gmail.com>>:
Sorry for the typo, I added also a newline before @since:
2017-04-20 23:04 GMT+02:00 Philip Race
<philip.r...@oracle.com <mailto:philip.r...@oracle.com>>:
You have a capital letter here and I think it must be
lower case ..
2499 * @Since 10
-phil.
On 4/20/17, 1:58 PM, Laurent Bourgès wrote:
Hi Phil & Jim,
Here is the updated webrev:
http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.2/
<http://cr.openjdk.java.net/%7Elbourges/path2D/Path2D-8078192.2/>
Changes:
- trimToSize() return void
- fixed test + jtreg passed
Bye,
Laurent
2017-04-20 21:30 GMT+02:00 Jim Graham
<james.gra...@oracle.com <mailto:james.gra...@oracle.com>>:
Hi Laurent,
The implementation looks good, except that the
method chaining-style return value seems out of
place here. Similar trimToSize() methods in
Collections return void and none of the other
methods in this area use the method chaining
paradigm. In the interest of maintaining a common
design theme throughout 2D this method should just
return void.
...jim
On 4/18/17 11:49 PM, Laurent Bourgès wrote:
Hi,
Here is a first attempt to propose a Path2D
patch (based on JDK10):
http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.0/
<http://cr.openjdk.java.net/%7Elbourges/path2D/Path2D-8078192.0/>
JBS:
https://bugs.openjdk.java.net/browse/JDK-8078192
<https://bugs.openjdk.java.net/browse/JDK-8078192>
Please review the Path2D changes, notably the
javadoc (english) and the modified
Path2DCopyConstructor test which checks
all public Path2D methods on concrete classes
(Path2D.Float, Path2D.Double, GeneralPath) after
calling path.trimToSize()
Cheers,
Laurent
--
--
Laurent Bourgès
--
--
Laurent Bourgès
--
--
Laurent Bourgès
--
--
Laurent Bourgès
